Skip to content

Commit 5391c68

Browse files
authored
[AMDGPU][NFC] Fix clang frontend<->sema layering issue (llvm#162865)
llvm#140210 added `#include "clang/Frontend/FrontendDiagnostic.h"` to clang/lib/Sema/SemaAMDGPU.cpp, but Frontend itself has a dependency on Sema. This creates a layering issue as described in https://llvm.org/docs/CodingStandards.html#library-layering. Fortunately, d076608 made this easy to fix, as clang/Frontend/FrontendDiagnostic.h just forwards to clang/Basic/DiagnosticFrontend.h, so it's trivial to make this depend on basic instead of frontend.
1 parent 85dd8f4 commit 5391c68

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

clang/lib/Sema/SemaAMDGPU.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111
//===----------------------------------------------------------------------===//
1212

1313
#include "clang/Sema/SemaAMDGPU.h"
14+
#include "clang/Basic/DiagnosticFrontend.h"
1415
#include "clang/Basic/DiagnosticSema.h"
1516
#include "clang/Basic/TargetBuiltins.h"
16-
#include "clang/Frontend/FrontendDiagnostic.h"
1717
#include "clang/Sema/Ownership.h"
1818
#include "clang/Sema/Sema.h"
1919
#include "llvm/Support/AMDGPUAddrSpace.h"

0 commit comments

Comments
 (0)