[IPO] Avoid repeated hash lookups (NFC) (llvm#131720)

Author: kazutakahirata

llvm/lib/Transforms/IPO/ArgumentPromotion.cpp

@@ -236,13 +236,13 @@ doPromotion(Function *F, FunctionAnalysisManager &FAM,
     ArgNo = 0;
     for (Function::arg_iterator I = F->arg_begin(), E = F->arg_end(); I != E;
          ++I, ++AI, ++ArgNo) {
-      if (!ArgsToPromote.count(&*I)) {
+      auto ArgIt = ArgsToPromote.find(&*I);
+      if (ArgIt == ArgsToPromote.end()) {
         Args.push_back(*AI); // Unmodified argument
         ArgAttrVec.push_back(CallPAL.getParamAttrs(ArgNo));
       } else if (!I->use_empty()) {
         Value *V = *AI;
-        const auto &ArgParts = ArgsToPromote.find(&*I)->second;
-        for (const auto &Pair : ArgParts) {
+        for (const auto &Pair : ArgIt->second) {
           LoadInst *LI = IRB.CreateAlignedLoad(
               Pair.second.Ty,
               createByteGEP(IRB, DL, V, Pair.second.Ty, Pair.first),
@@ -266,7 +266,7 @@ doPromotion(Function *F, FunctionAnalysisManager &FAM,
           ArgAttrVec.push_back(AttributeSet());
         }
       } else {
-        assert(ArgsToPromote.count(&*I) && I->use_empty());
+        assert(I->use_empty());
         DeadArgs.emplace_back(AI->get());
       }
     }