Fix infinite loop crash in variable type inference (PowerShell#25696)

MartinGC94 · Amro Khalil · commit e038e687205b · 2025-08-13T00:51:43.000+04:00
diff --git a/src/System.Management.Automation/engine/parser/Position.cs b/src/System.Management.Automation/engine/parser/Position.cs
@@ -338,10 +338,7 @@ internal static bool IsAfter(this IScriptExtent extentToTest, IScriptExtent endE
 
         internal static bool IsWithin(this IScriptExtent extentToTest, IScriptExtent extent)
         {
-            return extentToTest.StartLineNumber >= extent.StartLineNumber &&
-                   extentToTest.EndLineNumber <= extent.EndLineNumber &&
-                   extentToTest.StartColumnNumber >= extent.StartColumnNumber &&
-                   extentToTest.EndColumnNumber <= extent.EndColumnNumber;
+            return extentToTest.StartOffset >= extent.StartOffset && extentToTest.EndOffset <= extent.EndOffset;
         }
 
         internal static bool IsAfter(this IScriptExtent extent, int line, int column)

Original file line number	Diff line number	Diff line change
`@@ -338,10 +338,7 @@ internal static bool IsAfter(this IScriptExtent extentToTest, IScriptExtent endE`
`338`	`338`
`339`	`339`	`internal static bool IsWithin(this IScriptExtent extentToTest, IScriptExtent extent)`
`340`	`340`	`{`
`341`		`- return extentToTest.StartLineNumber >= extent.StartLineNumber &&`
`342`		`- extentToTest.EndLineNumber <= extent.EndLineNumber &&`
`343`		`- extentToTest.StartColumnNumber >= extent.StartColumnNumber &&`
`344`		`- extentToTest.EndColumnNumber <= extent.EndColumnNumber;`
	`341`	`+ return extentToTest.StartOffset >= extent.StartOffset && extentToTest.EndOffset <= extent.EndOffset;`
`345`	`342`	`}`
`346`	`343`
`347`	`344`	`internal static bool IsAfter(this IScriptExtent extent, int line, int column)`