Skip to content

Commit 683d227

Browse files
Minor improvements (#2)
* Remove unused include * Add py.typed * Fix cast errors
1 parent 024c93d commit 683d227

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

src/amulet/io/binary_writer.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
#include <cstdint>
66
#include <cstring>
77
#include <functional>
8-
#include <iostream>
98
#include <string>
109
#include <limits>
1110

src/amulet/io/py.typed

Whitespace-only changes.

tests/test_amulet_io/_test_amulet_io.py.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,11 +131,11 @@ void test_read_string(EndianState endian, bool read_offset)
131131
if (!read_offset) {
132132
ASSERT_EQUAL(size_t, 0, reader.get_position())
133133
ASSERT_EQUAL(bool, true, reader.has_more_data())
134-
ASSERT_EQUAL(std::string, "test", reader.read_bytes(4))
134+
ASSERT_EQUAL(std::string_view, "test", reader.read_bytes(4))
135135
}
136136
ASSERT_EQUAL(size_t, 4, reader.get_position())
137137
ASSERT_EQUAL(bool, true, reader.has_more_data())
138-
ASSERT_EQUAL(std::string, "hello world", reader.read_size_and_bytes<std::uint16_t>())
138+
ASSERT_EQUAL(std::string_view, "hello world", reader.read_size_and_bytes<std::uint16_t>())
139139
ASSERT_EQUAL(size_t, 17, reader.get_position())
140140
ASSERT_EQUAL(bool, true, reader.has_more_data())
141141
if (endian == EndianState::Default) {

0 commit comments

Comments
 (0)