Fix air rendering (#38)

gentlegiantJGC · web-flow · commit cdcda1bd800e · 2024-12-03T20:12:25.000Z
Fixes Amulet-Team/Amulet-Map-Editor#1119 These two lines of code were to display the missing block if the block had textures but no elements which is the case for polygon mesh formats that we don't support. Minecraft Java 1.21.4 added a particle texture which broke this.
diff --git a/minecraft_model_reader/api/resource_pack/java/resource_pack_manager.py b/minecraft_model_reader/api/resource_pack/java/resource_pack_manager.py
@@ -356,7 +356,9 @@ def _load_block_model(self, model_path: str) -> BlockMesh:
         }
         transparent = Transparency.Partial
 
-        if java_model.get("textures", {}) and not java_model.get("elements"):
+        if set(java_model.get("textures", {})).difference(
+            {"particle"}
+        ) and not java_model.get("elements"):
             return self.missing_block
 
         for element in java_model.get("elements", {}):

Original file line number	Diff line number	Diff line change
`@@ -356,7 +356,9 @@ def _load_block_model(self, model_path: str) -> BlockMesh:`
`356`	`356`	`}`
`357`	`357`	`transparent = Transparency.Partial`
`358`	`358`
`359`		`- if java_model.get("textures", {}) and not java_model.get("elements"):`
	`359`	`+ if set(java_model.get("textures", {})).difference(`
	`360`	`+ {"particle"}`
	`361`	`+ ) and not java_model.get("elements"):`
`360`	`362`	`return self.missing_block`
`361`	`363`
`362`	`364`	`for element in java_model.get("elements", {}):`