fix codacy

Author: LiorBanai

Analogy.LogViewer.Example.UnitTests/UnitTest1.cs

@@ -5,9 +5,9 @@ namespace Analogy.LogViewer.Example.UnitTests
     [TestClass]
     public class UnitTest1
     {
-        [TestMethod]
-        public void TestMethod1()
-        {
-        }
+        //[TestMethod]
+        //public void TestMethod1()
+        //{
+        //}
     }
 }

Analogy.LogViewer.Example/IAnalogy/OnlineExampleDataProvider.cs

@@ -15,69 +15,68 @@ class OnlineExampleDataProvider : Analogy.LogViewer.Template.OnlineDataProvider
         public override string? OptionalTitle { get; set; }
         public override Guid Id { get; set; }
 
-        public override async Task<bool> CanStartReceiving() => await Task.FromResult(true);
+        public override Task<bool> CanStartReceiving() => Task.FromResult(true);
 
-        private readonly Timer SimulateOnlineMessages;
-        private int messageCount = 0;
+        private readonly Timer _simulateOnlineMessages;
+        private long _messageCount;
         readonly Random _random = new Random();
         readonly Array _values = Enum.GetValues(typeof(AnalogyLogLevel));
-        private readonly List<string> processes = Process.GetProcesses().Select(p => p.ProcessName).ToList();
-        private readonly string prefixMessage;
-        private readonly Random rnd = new Random();
+        private readonly List<string> _processes = Process.GetProcesses().Select(p => p.ProcessName).ToList();
+        private readonly string _prefixMessage;
+        private readonly Random _rnd = new Random();
 
         public override IEnumerable<(string originalHeader, string replacementHeader)> GetReplacementHeaders()
         {
             yield return ("Category", "Test");
         }
 
         public override (Color backgroundColor, Color foregroundColor) GetColorForMessage(IAnalogyLogMessage logMessage)
-            => logMessage.Level == AnalogyLogLevel.Unknown ? (Color.FromArgb(rnd.Next(256), rnd.Next(256), rnd.Next(256)), Color.FromArgb(rnd.Next(256), rnd.Next(256), rnd.Next(256))) : (Color.Empty, Color.Empty);
+            => logMessage.Level == AnalogyLogLevel.Unknown ? (Color.FromArgb(_rnd.Next(256), _rnd.Next(256), _rnd.Next(256)), Color.FromArgb(_rnd.Next(256), _rnd.Next(256), _rnd.Next(256))) : (Color.Empty, Color.Empty);
         public OnlineExampleDataProvider(string prefix, Guid guid)
         {
-            prefixMessage = prefix;
+            _prefixMessage = prefix;
             Id = guid;
             OptionalTitle = $"Analogy Example: Real time Data Provider {prefix}";
-            SimulateOnlineMessages = new Timer(100);
+            _simulateOnlineMessages = new Timer(100);
 
         }
         public override async Task InitializeDataProviderAsync(IAnalogyLogger logger)
         {
             await base.InitializeDataProviderAsync(logger);
 
-            SimulateOnlineMessages.Elapsed += (s, e) =>
+            _simulateOnlineMessages.Elapsed += (s, e) =>
             {
-                unchecked
+
+                AnalogyLogLevel randomLevel = (AnalogyLogLevel)_values.GetValue(_random.Next(_values.Length))!;
+                string randomProcess = _processes[_random.Next(_processes.Count)];
+                AnalogyLogMessage m = new AnalogyLogMessage
                 {
-                    AnalogyLogLevel randomLevel = (AnalogyLogLevel)_values.GetValue(_random.Next(_values.Length))!;
-                    string randomProcess = processes[_random.Next(processes.Count)];
-                    AnalogyLogMessage m = new AnalogyLogMessage
-                    {
-                        Text = $"{prefixMessage}: Generated message #{messageCount++}" + string.Join(Environment.NewLine, Enumerable.Range(0, _random.Next(1, 5)).Select(i => $"row {i}")),
-                        Level = randomLevel,
-                        Class = AnalogyLogClass.General,
-                        Source = "Example",
-                        User = Environment.UserName,
-                        Module = randomProcess,
-                        MachineName = Environment.MachineName,
-                        ThreadId = Thread.CurrentThread.ManagedThreadId,
-                        AdditionalInformation = new Dictionary<string, string>() { { "Random Column", _random.Next(0, 10).ToString() }, { "Random Column 2", _random.Next(0, 10).ToString() } }
+                    Text = $"{_prefixMessage}: Generated message #{_messageCount++}" + string.Join(Environment.NewLine, Enumerable.Range(0, _random.Next(1, 5)).Select(i => $"row {i}")),
+                    Level = randomLevel,
+                    Class = AnalogyLogClass.General,
+                    Source = "Example",
+                    User = Environment.UserName,
+                    Module = randomProcess,
+                    MachineName = Environment.MachineName,
+                    ThreadId = Thread.CurrentThread.ManagedThreadId,
+                    AdditionalInformation = new Dictionary<string, string> { { "Random Column", _random.Next(0, 10).ToString() }, { "Random Column 2", _random.Next(0, 10).ToString() } }
+
+                };
 
-                    };
+                MessageReady(this, new AnalogyLogMessageArgs(m, Environment.MachineName, "Example", Id));
 
-                    MessageReady(this, new AnalogyLogMessageArgs(m, Environment.MachineName, "Example", Id));
-                }
             };
         }
 
         public override Task StartReceiving()
         {
-            SimulateOnlineMessages.Start();
+            _simulateOnlineMessages.Start();
             return Task.CompletedTask;
         }
 
         public override Task StopReceiving()
         {
-            SimulateOnlineMessages?.Stop();
+            _simulateOnlineMessages?.Stop();
             Disconnected(this, new AnalogyDataSourceDisconnectedArgs("user disconnected", Environment.MachineName, Id));
             return Task.CompletedTask;
         }

Analogy.LogViewer.Example/IAnalogy/PrimaryFactory.cs

@@ -9,7 +9,7 @@ namespace Analogy.LogViewer.Example
 {
     public class PrimaryFactory : IAnalogyFactory
     {
-        internal static Guid Id = new Guid("4B1EBC0F-64DD-44A1-BC27-79DBFC6384CC");
+        internal static readonly Guid Id = new Guid("4B1EBC0F-64DD-44A1-BC27-79DBFC6384CC");
         public Guid FactoryId { get; set; } = Id;
 
         public string Title { get; set; } = "Analogy Examples";