SERVER-77158 apply performance-move-const-arg clang tidy rule for replication

mattBoros · Evergreen Agent · commit 57624bec5559 · 2023-10-08T16:24:08.000Z
diff --git a/src/mongo/db/repl/hello_response.cpp b/src/mongo/db/repl/hello_response.cpp
@@ -533,24 +533,24 @@ void HelloResponse::setReplSetVersion(long long version) {
     _setVersion = version;
 }
 
-void HelloResponse::addHost(const HostAndPort& host) {
+void HelloResponse::addHost(HostAndPort host) {
     _hostsSet = true;
-    _hosts.push_back(host);
+    _hosts.push_back(std::move(host));
 }
 
-void HelloResponse::addPassive(const HostAndPort& passive) {
+void HelloResponse::addPassive(HostAndPort passive) {
     _passivesSet = true;
-    _passives.push_back(passive);
+    _passives.push_back(std::move(passive));
 }
 
-void HelloResponse::addArbiter(const HostAndPort& arbiter) {
+void HelloResponse::addArbiter(HostAndPort arbiter) {
     _arbitersSet = true;
-    _arbiters.push_back(arbiter);
+    _arbiters.push_back(std::move(arbiter));
 }
 
-void HelloResponse::setPrimary(const HostAndPort& primary) {
+void HelloResponse::setPrimary(HostAndPort primary) {
     _primarySet = true;
-    _primary = primary;
+    _primary = std::move(primary);
 }
 
 void HelloResponse::setIsArbiterOnly(bool arbiterOnly) {
@@ -587,9 +587,9 @@ void HelloResponse::addTag(const std::string& tagKey, const std::string& tagValu
     _tags[tagKey] = tagValue;
 }
 
-void HelloResponse::setMe(const HostAndPort& me) {
+void HelloResponse::setMe(HostAndPort me) {
     _meSet = true;
-    _me = me;
+    _me = std::move(me);
 }
 
 void HelloResponse::setElectionId(const OID& electionId) {
diff --git a/src/mongo/db/repl/hello_response.h b/src/mongo/db/repl/hello_response.h
@@ -217,13 +217,13 @@ class HelloResponse {
 
     void setReplSetVersion(long long version);
 
-    void addHost(const HostAndPort& host);
+    void addHost(HostAndPort host);
 
-    void addPassive(const HostAndPort& passive);
+    void addPassive(HostAndPort passive);
 
-    void addArbiter(const HostAndPort& arbiter);
+    void addArbiter(HostAndPort arbiter);
 
-    void setPrimary(const HostAndPort& primary);
+    void setPrimary(HostAndPort primary);
 
     void setIsArbiterOnly(bool arbiterOnly);
 
@@ -239,7 +239,7 @@ class HelloResponse {
 
     void addTag(const std::string& tagKey, const std::string& tagValue);
 
-    void setMe(const HostAndPort& me);
+    void setMe(HostAndPort me);
 
     void setElectionId(const OID& electionId);
 
diff --git a/src/mongo/db/repl/noop_writer.cpp b/src/mongo/db/repl/noop_writer.cpp
@@ -87,8 +87,10 @@ class NoopWriter::PeriodicNoopRunner {
     using NoopWriteFn = std::function<void(OperationContext*)>;
 
 public:
-    PeriodicNoopRunner(Seconds waitTime, NoopWriteFn noopWrite)
-        : _thread([this, noopWrite, waitTime] { run(waitTime, std::move(noopWrite)); }) {}
+    PeriodicNoopRunner(const Seconds& waitTime, NoopWriteFn&& noopWrite)
+        : _thread([this, noopWrite = std::move(noopWrite), waitTime]() mutable {
+              run(waitTime, std::move(noopWrite));
+          }) {}
 
     ~PeriodicNoopRunner() {
         stdx::unique_lock<Latch> lk(_mutex);
@@ -99,7 +101,7 @@ class NoopWriter::PeriodicNoopRunner {
     }
 
 private:
-    void run(Seconds waitTime, NoopWriteFn noopWrite) {
+    void run(const Seconds& waitTime, NoopWriteFn&& noopWrite) {
         Client::initThread("NoopWriter");
 
         while (true) {
diff --git a/src/mongo/db/repl/oplog_applier_impl_test.cpp b/src/mongo/db/repl/oplog_applier_impl_test.cpp
@@ -828,13 +828,13 @@ TEST_F(OplogApplierImplTest, RenameCollectionCommandMultitenantAcrossTenantsRequ
 }
 
 OplogEntry makeInvalidateOp(OpTime opTime,
-                            NamespaceString nss,
+                            const NamespaceString& nss,
                             BSONObj document,
                             OperationSessionInfo sessionInfo,
                             mongo::UUID uuid) {
     return DurableOplogEntry(opTime,                     // optime
                              OpTypeEnum::kUpdate,        // opType
-                             std::move(nss),             // namespace
+                             nss,                        // namespace
                              uuid,                       // uuid
                              boost::none,                // fromMigrate
                              boost::none,                // checkExistenceForDiffInsert
diff --git a/src/mongo/db/repl/oplog_applier_impl_test_fixture.cpp b/src/mongo/db/repl/oplog_applier_impl_test_fixture.cpp
@@ -491,7 +491,7 @@ OplogEntry makeOplogEntry(OpTime opTime,
                           boost::optional<RetryImageEnum> needsRetryImage) {
     return {DurableOplogEntry(opTime,                     // optime
                               opType,                     // opType
-                              std::move(nss),             // namespace
+                              nss,                        // namespace
                               uuid,                       // uuid
                               fromMigrate,                // fromMigrate
                               boost::none,                // checkExistenceForDiffInsert
diff --git a/src/mongo/db/repl/oplog_entry.h b/src/mongo/db/repl/oplog_entry.h
@@ -117,7 +117,7 @@ class ReplOperation : public DurableReplOperation {
     static ReplOperation parseOwned(const IDLParserContext& ctxt, const BSONObj&& bsonObject) {
         ReplOperation o;
         o.parseProtected(ctxt, bsonObject);
-        o.setAnchor(std::move(bsonObject));
+        o.setAnchor(bsonObject);
         return o;
     }
 
diff --git a/src/mongo/db/repl/oplog_fetcher.cpp b/src/mongo/db/repl/oplog_fetcher.cpp
@@ -594,7 +594,7 @@ AggregateCommandRequest OplogFetcher::_makeAggregateCommandRequest(long long max
     BSONObjBuilder secondMatchBuilder(BSON("ts" << BSON("$gte" << startTs)));
     stages.emplace_back(DocumentSourceMatch::createFromBson(
         Document{{"$match", Document{secondMatchBuilder.obj()}}}.toBson().firstElement(), expCtx));
-    const auto serializedPipeline = Pipeline::create(std::move(stages), expCtx)->serializeToBson();
+    auto serializedPipeline = Pipeline::create(std::move(stages), expCtx)->serializeToBson();
 
     AggregateCommandRequest aggRequest(_nss, std::move(serializedPipeline));
     aggRequest.setReadConcern(_config.queryReadConcern.toBSONInner());
diff --git a/src/mongo/db/repl/primary_only_service.cpp b/src/mongo/db/repl/primary_only_service.cpp
@@ -805,14 +805,14 @@ std::shared_ptr<PrimaryOnlyService::Instance> PrimaryOnlyService::_insertNewInst
                    instance,
                    scopedExecutor = _scopedExecutor,
                    token = instanceSource.token(),
-                   instanceID] {
+                   instanceID]() mutable {
                 LOGV2_DEBUG(5123002,
                             3,
                             "Starting instance of PrimaryOnlyService",
                             "service"_attr = serviceName,
                             "instanceID"_attr = instanceID);
 
-                return instance->run(std::move(scopedExecutor), std::move(token));
+                return instance->run(std::move(scopedExecutor), token);
             })
             // TODO SERVER-61717 remove this error handler once instance are automatically released
             // at the end of run()
diff --git a/src/mongo/db/repl/replication_coordinator_impl.cpp b/src/mongo/db/repl/replication_coordinator_impl.cpp
@@ -2131,7 +2131,7 @@ ReplicationCoordinator::StatusAndDuration ReplicationCoordinatorImpl::awaitRepli
               "allDurable"_attr = _storage->getAllDurableTimestamp(_service),
               "progress"_attr = _getReplicationProgress(lock));
     }
-    return {std::move(status), duration_cast<Milliseconds>(timer.elapsed())};
+    return {status, duration_cast<Milliseconds>(timer.elapsed())};
 }
 
 SharedSemiFuture<void> ReplicationCoordinatorImpl::awaitReplicationAsyncNoWTimeout(
diff --git a/src/mongo/db/repl/shard_merge_recipient_service.cpp b/src/mongo/db/repl/shard_merge_recipient_service.cpp
@@ -1223,7 +1223,7 @@ void ShardMergeRecipientService::Instance::_keepBackupCursorAlive(const Cancella
     executor::RemoteCommandRequest getMoreRequest(
         _client->getServerHostAndPort(),
         nss.dbName(),
-        std::move(BSON("getMore" << cursorId << "collection" << nss.coll().toString())),
+        BSON("getMore" << cursorId << "collection" << nss.coll().toString()),
         nullptr);
     getMoreRequest.options.fireAndForget = true;
 
diff --git a/src/mongo/db/repl/task_runner.cpp b/src/mongo/db/repl/task_runner.cpp
@@ -184,7 +184,7 @@ void TaskRunner::_runTasks() {
         lk.unlock();
         // Cancel remaining tasks with a CallbackCanceled status.
         for (auto&& task : tasks) {
-            runSingleTask(std::move(task),
+            runSingleTask(task,
                           nullptr,
                           Status(ErrorCodes::CallbackCanceled,
                                  "this task has been canceled by a previously invoked task"));
diff --git a/src/mongo/db/repl/tenant_migration_donor_op_observer.cpp b/src/mongo/db/repl/tenant_migration_donor_op_observer.cpp
@@ -185,7 +185,7 @@ void onTransitionToAborted(OperationContext* opCtx,
  */
 class TenantMigrationDonorCommitOrAbortHandler final : public RecoveryUnit::Change {
 public:
-    TenantMigrationDonorCommitOrAbortHandler(const TenantMigrationDonorDocument donorStateDoc)
+    TenantMigrationDonorCommitOrAbortHandler(TenantMigrationDonorDocument donorStateDoc)
         : _donorStateDoc(std::move(donorStateDoc)) {}
 
     void commit(OperationContext* opCtx, boost::optional<Timestamp>) override {
diff --git a/src/mongo/db/repl/topology_coordinator.cpp b/src/mongo/db/repl/topology_coordinator.cpp
@@ -1135,7 +1135,7 @@ HeartbeatResponseAction TopologyCoordinator::processHeartbeatResponse(
                         "retriesElapsed"_attr = alreadyElapsed);
         }
     } else {
-        ReplSetHeartbeatResponse hbr = std::move(hbResponse.getValue());
+        ReplSetHeartbeatResponse hbr = hbResponse.getValue();
         LOGV2_DEBUG(
             21808, 3, "setUpValues: heartbeat response good", "memberId"_attr = member.getId());
         pingsInConfig++;

Original file line number	Diff line number	Diff line change
`@@ -533,24 +533,24 @@ void HelloResponse::setReplSetVersion(long long version) {`
`533`	`533`	`_setVersion = version;`
`534`	`534`	`}`
`535`	`535`
`536`		`-void HelloResponse::addHost(const HostAndPort& host) {`
	`536`	`+void HelloResponse::addHost(HostAndPort host) {`
`537`	`537`	`_hostsSet = true;`
`538`		`- _hosts.push_back(host);`
	`538`	`+ _hosts.push_back(std::move(host));`
`539`	`539`	`}`
`540`	`540`
`541`		`-void HelloResponse::addPassive(const HostAndPort& passive) {`
	`541`	`+void HelloResponse::addPassive(HostAndPort passive) {`
`542`	`542`	`_passivesSet = true;`
`543`		`- _passives.push_back(passive);`
	`543`	`+ _passives.push_back(std::move(passive));`
`544`	`544`	`}`
`545`	`545`
`546`		`-void HelloResponse::addArbiter(const HostAndPort& arbiter) {`
	`546`	`+void HelloResponse::addArbiter(HostAndPort arbiter) {`
`547`	`547`	`_arbitersSet = true;`
`548`		`- _arbiters.push_back(arbiter);`
	`548`	`+ _arbiters.push_back(std::move(arbiter));`
`549`	`549`	`}`
`550`	`550`
`551`		`-void HelloResponse::setPrimary(const HostAndPort& primary) {`
	`551`	`+void HelloResponse::setPrimary(HostAndPort primary) {`
`552`	`552`	`_primarySet = true;`
`553`		`- _primary = primary;`
	`553`	`+ _primary = std::move(primary);`
`554`	`554`	`}`
`555`	`555`
`556`	`556`	`void HelloResponse::setIsArbiterOnly(bool arbiterOnly) {`
`@@ -587,9 +587,9 @@ void HelloResponse::addTag(const std::string& tagKey, const std::string& tagValu`
`587`	`587`	`_tags[tagKey] = tagValue;`
`588`	`588`	`}`
`589`	`589`
`590`		`-void HelloResponse::setMe(const HostAndPort& me) {`
	`590`	`+void HelloResponse::setMe(HostAndPort me) {`
`591`	`591`	`_meSet = true;`
`592`		`- _me = me;`
	`592`	`+ _me = std::move(me);`
`593`	`593`	`}`
`594`	`594`
`595`	`595`	`void HelloResponse::setElectionId(const OID& electionId) {`
Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ class ReplOperation : public DurableReplOperation {`
`117`	`117`	`static ReplOperation parseOwned(const IDLParserContext& ctxt, const BSONObj&& bsonObject) {`
`118`	`118`	`ReplOperation o;`
`119`	`119`	`o.parseProtected(ctxt, bsonObject);`
`120`		`- o.setAnchor(std::move(bsonObject));`
	`120`	`+ o.setAnchor(bsonObject);`
`121`	`121`	`return o;`
`122`	`122`	`}`
`123`	`123`
Original file line number	Diff line number	Diff line change
`@@ -2131,7 +2131,7 @@ ReplicationCoordinator::StatusAndDuration ReplicationCoordinatorImpl::awaitRepli`
`2131`	`2131`	`"allDurable"_attr = _storage->getAllDurableTimestamp(_service),`
`2132`	`2132`	`"progress"_attr = _getReplicationProgress(lock));`
`2133`	`2133`	`}`
`2134`		`- return {std::move(status), duration_cast<Milliseconds>(timer.elapsed())};`
	`2134`	`+ return {status, duration_cast<Milliseconds>(timer.elapsed())};`
`2135`	`2135`	`}`
`2136`	`2136`
`2137`	`2137`	`SharedSemiFuture<void> ReplicationCoordinatorImpl::awaitReplicationAsyncNoWTimeout(`