-
Notifications
You must be signed in to change notification settings - Fork 605
Description
hey, found a bug with the dislike ratio bar. when you scroll down to read comments or something, the green/red bar under the like/dislike buttons just vanishes. when you scroll back up, it's gone completely. only comes back if you refresh the page or click like/dislike.
pretty annoying tbh, especially on longer videos where you're constantly scrolling.
- open any video (tried it on several)
- scroll down until the buttons go off screen
- scroll back up
- the bar is missing
the bar should still be there when i scroll back up
bar's gone until i interact with it somehow
my setup:
- firefox (arch linux)
- latest extension version
- happens on both old and new youtube design
what did i do:
looks like there's an isInViewport check in src/bar.js that removes the element when it goes off screen. probably meant to clean up stale elements from youtube's spa navigation, but it's also removing the bar when you just scroll normally.
maybe just let the browser handle off-screen elements? they don't really cost anything performance-wise.