Addressing review comments

Author: AnastasiyaChernikova

llvm/tools/llvm-exegesis/lib/SerialSnippetGenerator.cpp

@@ -109,51 +109,7 @@ static void appendCodeTemplates(const LLVMState &State,
   }
   case ExecutionMode::SERIAL_VIA_MEMORY_INSTR: {
     // Select back-to-back memory instruction.
-
-    auto &I = Variant.getInstr();
-    if (I.Description.mayLoad()) {
-      // If instruction is load, we can self-alias it in case when instruction
-      // overrides whole address register. For that we use provided scratch
-      // memory.
-
-      // TODO: now it is not checked if load writes the whole register.
-
-      auto DefOpIt = find_if(I.Operands, [](Operand const &op) {
-        return op.isDef() && op.isReg();
-      });
-
-      if (DefOpIt == I.Operands.end())
-        return;
-
-      const Operand &DefOp = *DefOpIt;
-      auto &ET = State.getExegesisTarget();
-      auto ScratchMemoryRegister = ET.getScratchMemoryRegister(
-          State.getTargetMachine().getTargetTriple());
-      auto &RegClass =
-          State.getTargetMachine().getMCRegisterInfo()->getRegClass(
-              DefOp.getExplicitOperandInfo().RegClass);
-
-      // Register classes of def operand and memory operand must be the same
-      // to perform aliasing.
-      if (!RegClass.contains(ScratchMemoryRegister))
-        return;
-
-      ET.fillMemoryOperands(Variant, ScratchMemoryRegister, 0);
-      Variant.getValueFor(DefOp) = MCOperand::createReg(ScratchMemoryRegister);
-
-      CodeTemplate CT;
-      CT.Execution = ExecutionModeBit;
-      if (CT.ScratchSpacePointerInReg == 0)
-        CT.ScratchSpacePointerInReg = ScratchMemoryRegister;
-
-      CT.Info = std::string(ExecutionClassDescription);
-      CT.Instructions.push_back(std::move(Variant));
-      CT.PreinitScratchMemory.emplace_back(ScratchMemoryRegister,
-                                           /* Offset */ 0);
-      CodeTemplates.push_back(std::move(CT));
-    }
-
-    // TODO: implement more cases
+    // TODO: Implement me.
     return;
   }
   case ExecutionMode::SERIAL_VIA_EXPLICIT_REGS: {

llvm/tools/llvm-exegesis/lib/SnippetFile.cpp

@@ -208,9 +208,6 @@ class BenchmarkCodeStreamer : public MCStreamer, public AsmCommentConsumer {
                     Align ByteAlignment, SMLoc Loc) override {}
 
   unsigned findRegisterByName(const StringRef RegName) const {
-    // TODO make use of RegNameToRegNo map
-    if (unsigned Reg = Target.findRegisterByName(RegName))
-      return Reg;
     std::optional<MCRegister> RegisterNumber =
         State.getRegisterNumberFromName(RegName);
     if (!RegisterNumber.has_value()) {