Merge pull request #67 from AndersTrier/AndersTrier/clippy_1.90.0

Clippy lints

Author: AndersTrier

clippy.toml

@@ -0,0 +1 @@
+doc-valid-idents = ["AArch64", "CRC32c", "HighwayHash", ".."]

src/decoder_result.rs

@@ -24,7 +24,7 @@ impl DecoderResult<'_> {
 
     /// Returns iterator over all restored original shards
     /// and their indexes, ordered by indexes.
-    pub fn restored_original_iter(&self) -> RestoredOriginal {
+    pub fn restored_original_iter(&self) -> RestoredOriginal<'_> {
         RestoredOriginal::new(self.work)
     }
 }

src/encoder_result.rs

@@ -28,7 +28,7 @@ impl EncoderResult<'_> {
     ///
     /// Recovery shards have indexes `0..recovery_count`
     /// and these same indexes must be used when decoding.
-    pub fn recovery_iter(&self) -> Recovery {
+    pub fn recovery_iter(&self) -> Recovery<'_> {
         Recovery::new(self.work)
     }
 }

src/engine/shards.rs

@@ -15,7 +15,7 @@ pub(crate) struct Shards {
 }
 
 impl Shards {
-    pub(crate) fn as_ref_mut(&mut self) -> ShardsRefMut {
+    pub(crate) fn as_ref_mut(&mut self) -> ShardsRefMut<'_> {
         ShardsRefMut::new(self.shard_count, self.shard_len_64, self.data.as_mut())
     }
 
@@ -190,7 +190,7 @@ impl<'a> ShardsRefMut<'a> {
 
     /// Splits this [`ShardsRefMut`] into two so that
     /// first includes shards `0..mid` and second includes shards `mid..`.
-    pub fn split_at_mut(&mut self, mid: usize) -> (ShardsRefMut, ShardsRefMut) {
+    pub fn split_at_mut(&mut self, mid: usize) -> (ShardsRefMut<'_>, ShardsRefMut<'_>) {
         let (a, b) = self.data.split_at_mut(mid * self.shard_len_64);
 
         (

src/rate.rs

@@ -124,7 +124,7 @@ where
     fn add_original_shard<T: AsRef<[u8]>>(&mut self, original_shard: T) -> Result<(), Error>;
 
     /// Like [`ReedSolomonEncoder::encode`](crate::ReedSolomonEncoder::encode).
-    fn encode(&mut self) -> Result<EncoderResult, Error>;
+    fn encode(&mut self) -> Result<EncoderResult<'_>, Error>;
 
     /// Consumes this encoder returning its [`Engine`] and [`EncoderWork`]
     /// so that they can be re-used by another encoder.
@@ -201,7 +201,7 @@ where
     ) -> Result<(), Error>;
 
     /// Like [`ReedSolomonDecoder::decode`](crate::ReedSolomonDecoder::decode).
-    fn decode(&mut self) -> Result<DecoderResult, Error>;
+    fn decode(&mut self) -> Result<DecoderResult<'_>, Error>;
 
     /// Consumes this decoder returning its [`Engine`] and [`DecoderWork`]
     /// so that they can be re-used by another decoder.

src/rate/decoder_work.rs

@@ -121,7 +121,7 @@ impl DecoderWork {
     // - Returned `FixedBitSet` may contain extra zero bits.
     pub(crate) fn decode_begin(
         &mut self,
-    ) -> Result<Option<(ShardsRefMut, usize, usize, &FixedBitSet)>, Error> {
+    ) -> Result<Option<(ShardsRefMut<'_>, usize, usize, &FixedBitSet)>, Error> {
         if self.original_received_count + self.recovery_received_count < self.original_count {
             Err(Error::NotEnoughShards {
                 original_count: self.original_count,

src/rate/encoder_work.rs

@@ -71,7 +71,7 @@ impl EncoderWork {
         }
     }
 
-    pub(crate) fn encode_begin(&mut self) -> Result<(ShardsRefMut, usize, usize), Error> {
+    pub(crate) fn encode_begin(&mut self) -> Result<(ShardsRefMut<'_>, usize, usize), Error> {
         if self.original_received_count == self.original_count {
             Ok((
                 self.shards.as_ref_mut(),

src/rate/rate_default.rs

@@ -114,7 +114,7 @@ impl<E: Engine> RateEncoder<E> for DefaultRateEncoder<E> {
         }
     }
 
-    fn encode(&mut self) -> Result<EncoderResult, Error> {
+    fn encode(&mut self) -> Result<EncoderResult<'_>, Error> {
         match &mut self.0 {
             InnerEncoder::High(high) => high.encode(),
             InnerEncoder::Low(low) => low.encode(),
@@ -258,7 +258,7 @@ impl<E: Engine> RateDecoder<E> for DefaultRateDecoder<E> {
         }
     }
 
-    fn decode(&mut self) -> Result<DecoderResult, Error> {
+    fn decode(&mut self) -> Result<DecoderResult<'_>, Error> {
         match &mut self.0 {
             InnerDecoder::High(high) => high.decode(),
             InnerDecoder::Low(low) => low.decode(),

src/rate/rate_high.rs

@@ -41,7 +41,7 @@ impl<E: Engine> RateEncoder<E> for HighRateEncoder<E> {
         self.work.add_original_shard(original_shard)
     }
 
-    fn encode(&mut self) -> Result<EncoderResult, Error> {
+    fn encode(&mut self) -> Result<EncoderResult<'_>, Error> {
         let (mut work, original_count, recovery_count) = self.work.encode_begin()?;
         let chunk_size = recovery_count.next_power_of_two();
         let engine = &self.engine;
@@ -169,7 +169,7 @@ impl<E: Engine> RateDecoder<E> for HighRateDecoder<E> {
         self.work.add_recovery_shard(index, recovery_shard)
     }
 
-    fn decode(&mut self) -> Result<DecoderResult, Error> {
+    fn decode(&mut self) -> Result<DecoderResult<'_>, Error> {
         let Some((mut work, original_count, recovery_count, received)) =
             self.work.decode_begin()?
         else {

src/rate/rate_low.rs

@@ -41,7 +41,7 @@ impl<E: Engine> RateEncoder<E> for LowRateEncoder<E> {
         self.work.add_original_shard(original_shard)
     }
 
-    fn encode(&mut self) -> Result<EncoderResult, Error> {
+    fn encode(&mut self) -> Result<EncoderResult<'_>, Error> {
         let (mut work, original_count, recovery_count) = self.work.encode_begin()?;
         let chunk_size = original_count.next_power_of_two();
         let engine = &self.engine;
@@ -169,7 +169,7 @@ impl<E: Engine> RateDecoder<E> for LowRateDecoder<E> {
         self.work.add_recovery_shard(index, recovery_shard)
     }
 
-    fn decode(&mut self) -> Result<DecoderResult, Error> {
+    fn decode(&mut self) -> Result<DecoderResult<'_>, Error> {
         let Some((mut work, original_count, recovery_count, received)) =
             self.work.decode_begin()?
         else {