Skip to content

Commit 5f242bc

Browse files
committed
Fixed apktool version output
1 parent e2784ce commit 5f242bc

File tree

2 files changed

+25
-5
lines changed

2 files changed

+25
-5
lines changed

APKToolGUI/ApkTool/Apktool.cs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,18 @@ public int ClearFramework()
252252
}
253253

254254
public string GetVersion()
255+
{
256+
using (JarProcess apktoolJar = new JarProcess(JavaPath, JarPath))
257+
{
258+
apktoolJar.EnableRaisingEvents = false;
259+
apktoolJar.Start("version");
260+
string version = apktoolJar.StandardOutput.ReadToEnd();
261+
apktoolJar.WaitForExit(3000);
262+
return version.Replace("\r\n", "");
263+
}
264+
}
265+
266+
public string GetVersionOld()
255267
{
256268
using (JarProcess apktoolJar = new JarProcess(JavaPath, JarPath))
257269
{

APKToolGUI/Forms/FormMain.cs

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
using System.Linq;
1717
using APKToolGUI.Controls;
1818
using Ionic.Zip;
19+
using System.Text.RegularExpressions;
1920

2021
namespace APKToolGUI
2122
{
@@ -668,8 +669,11 @@ public async void SetApktoolPath()
668669
}
669670

670671
string apktoolVersion = apktool.GetVersion();
671-
if (!String.IsNullOrWhiteSpace(apktoolVersion))
672-
ToLog(ApktoolEventType.None, String.Format(Language.APKToolVersion + " \"{0}\"", apktoolVersion));
672+
string apktoolVersionOld = apktool.GetVersionOld();
673+
if (!String.IsNullOrWhiteSpace(apktoolVersion) && !Regex.IsMatch(apktoolVersion, @"\r\n?|\n"))
674+
ToLog(ApktoolEventType.None, $"{Language.APKToolVersion} \"{apktoolVersion}\"");
675+
else if (!String.IsNullOrWhiteSpace(apktoolVersionOld) && !Regex.IsMatch(apktoolVersionOld, @"\r\n?|\n"))
676+
ToLog(ApktoolEventType.None, $"{Language.APKToolVersion} \"{apktoolVersionOld}\"");
673677
else
674678
ToLog(ApktoolEventType.Error, Language.CantDetectApktoolVersion);
675679

@@ -1393,12 +1397,16 @@ await Task.Factory.StartNew(() =>
13931397
{
13941398
ToLog(ApktoolEventType.None, javaVersion);
13951399
string apktoolVersion = apktool.GetVersion();
1396-
string apkeditorVersion = apkeditor.GetVersion();
1397-
if (!String.IsNullOrWhiteSpace(apktoolVersion))
1398-
ToLog(ApktoolEventType.None, String.Format(Language.APKToolVersion + " {0}", apktoolVersion));
1400+
string apktoolVersionOld = apktool.GetVersionOld();
1401+
1402+
if (!String.IsNullOrWhiteSpace(apktoolVersion) && !Regex.IsMatch(apktoolVersion, @"\r\n?|\n"))
1403+
ToLog(ApktoolEventType.None, $"{Language.APKToolVersion} {apktoolVersion}");
1404+
else if (!String.IsNullOrWhiteSpace(apktoolVersionOld) && !Regex.IsMatch(apktoolVersionOld, @"\r\n?|\n"))
1405+
ToLog(ApktoolEventType.None, $"{Language.APKToolVersion} {apktoolVersionOld}");
13991406
else
14001407
ToLog(ApktoolEventType.Error, Language.CantDetectApktoolVersion);
14011408

1409+
string apkeditorVersion = apkeditor.GetVersion();
14021410
if (!String.IsNullOrWhiteSpace(apkeditorVersion))
14031411
ToLog(ApktoolEventType.None, apkeditorVersion);
14041412
else

0 commit comments

Comments
 (0)