Skip to content
This repository was archived by the owner on Apr 9, 2024. It is now read-only.

Commit ec3b987

Browse files
committed
Use Function instead of Consumer
1 parent b7b7265 commit ec3b987

File tree

13 files changed

+67
-22
lines changed

13 files changed

+67
-22
lines changed

core/src/main/java/ch/andre601/advancedserverlist/core/AdvancedServerList.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,13 @@ private void load(){
119119

120120
getPluginLogger().info("Proxy: " + plugin.getPlatformName() + " " + plugin.getPlatformVersion());
121121

122+
if(getFileHandler().loadConfig()){
123+
getPluginLogger().info("Successfully loaded config.yml!");
124+
}else{
125+
getPluginLogger().warn("Unable to load config.yml! Check previous lines for errors.");
126+
return;
127+
}
128+
122129
if(getFileHandler().loadProfiles()){
123130
getPluginLogger().info("Successfully loaded " + getFileHandler().getProfiles().size() + " profiles!");
124131
}else{

core/src/main/java/ch/andre601/advancedserverlist/core/commands/CommandHandler.java

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,16 +43,23 @@ public void handle(CmdSender sender, String[] args){
4343
sender.sendMsg();
4444
sender.sendMsg("<aqua>/asl help <grey>- Shows this help.");
4545
sender.sendMsg();
46-
sender.sendMsg("<aqua>/asl reload <grey>- Reloads the profiles.");
46+
sender.sendMsg("<aqua>/asl reload <grey>- Reloads the config and profiles.");
4747
}else{
4848
sender.sendMsg("<red>You do not have the permissions to execute this command!");
4949
}
5050
}else
5151
if(args[0].equalsIgnoreCase("reload")){
5252
if(sender.hasPermission("advancedserverlist.command.reload")){
53+
sender.sendMsg("<grey>Reloading config.yml...");
54+
if(core.getFileHandler().reloadConfig()){
55+
sender.sendMsg("<green>Successfully reloaded <grey>config.yml</grey>!");
56+
}else{
57+
sender.sendMsg("<red>Error while reloading the config.yml.");
58+
}
59+
5360
sender.sendMsg("<grey>Reloading Profiles...");
5461
if(core.getFileHandler().reloadProfiles()){
55-
sender.sendMsg("<green>Successfully loaded %d Profiles!", core.getFileHandler().getProfiles().size());
62+
sender.sendMsg("<green>Successfully loaded <grey>%d</grey> Profiles!", core.getFileHandler().getProfiles().size());
5663
}else{
5764
sender.sendMsg("<red>Error while reloading Profiles. No profiles have been loaded.");
5865
}

core/src/main/java/ch/andre601/advancedserverlist/core/parsing/ComponentParser.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232

3333
import java.util.List;
3434
import java.util.Map;
35-
import java.util.function.Consumer;
35+
import java.util.function.Function;
3636

3737
public class ComponentParser{
3838

@@ -46,7 +46,7 @@ public class ComponentParser{
4646
replacer = new StringReplacer();
4747
}
4848

49-
private final String text;
49+
private String text;
5050

5151
private ComponentParser(String text){
5252
this.text = text;
@@ -65,8 +65,8 @@ public ComponentParser replacements(Map<String, Object> replacements){
6565
return this;
6666
}
6767

68-
public ComponentParser consumer(Consumer<String> consumer){
69-
consumer.accept(text);
68+
public ComponentParser function(Function<String, String> function){
69+
this.text = function.apply(text);
7070
return this;
7171
}
7272

core/src/main/java/ch/andre601/advancedserverlist/core/profiles/players/PlayerHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,6 @@ public String getPlayerByIp(String ip){
109109
return entry.getKey();
110110
}
111111

112-
return core.getFileHandler().getString("Anonamous", "unknown_player");
112+
return core.getFileHandler().getString("Anonymous", "unknown_player");
113113
}
114114
}

core/src/main/resources/config.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,4 @@
1-
unknown_player: "Anonamous"
1+
#
2+
# Used for when AdvancedServerList doesn't have a cached player to use for ${player name}
3+
#
4+
unknown_player: "Anonymous"

paper/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@
7777
<groupId>me.clip</groupId>
7878
<artifactId>placeholderapi</artifactId>
7979
<version>2.11.1</version>
80+
<scope>provided</scope>
8081
</dependency>
8182
</dependencies>
8283

paper/src/main/java/ch/andre601/advancedserverlist/paper/PaperCore.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import ch.andre601.advancedserverlist.core.interfaces.PluginCore;
3030
import ch.andre601.advancedserverlist.core.interfaces.PluginLogger;
3131
import ch.andre601.advancedserverlist.paper.commands.CmdAdvancedServerList;
32+
import ch.andre601.advancedserverlist.paper.events.JoinEvent;
3233
import ch.andre601.advancedserverlist.paper.events.PingEvent;
3334
import ch.andre601.advancedserverlist.paper.logging.PaperLogger;
3435
import org.bstats.bukkit.Metrics;
@@ -64,6 +65,7 @@ public void loadCommands(){
6465

6566
@Override
6667
public void loadEvents(){
68+
new JoinEvent(this);
6769
new PingEvent(this);
6870
}
6971

paper/src/main/java/ch/andre601/advancedserverlist/paper/events/JoinEvent.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ public class JoinEvent implements Listener{
3838

3939
public JoinEvent(PaperCore plugin){
4040
this.plugin = plugin;
41+
plugin.getServer().getPluginManager().registerEvents(this, plugin);
4142
}
4243

4344
@EventHandler

paper/src/main/java/ch/andre601/advancedserverlist/paper/events/PingEvent.java

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -70,19 +70,23 @@ public void onServerPing(PaperServerListPingEvent event){
7070
if(!profile.getMotd().isEmpty()){
7171
event.motd(ComponentParser.list(profile.getMotd())
7272
.replacements(replacements)
73-
.consumer(text -> {
73+
.function(text -> {
7474
if(plugin.getServer().getPluginManager().isPluginEnabled("PlaceholderAPI"))
75-
PlaceholderAPI.setPlaceholders(player, text);
75+
return PlaceholderAPI.setPlaceholders(player, text);
76+
77+
return text;
7678
})
7779
.toComponent());
7880
}
7981

8082
if(!profile.getPlayerCount().isEmpty()){
8183
event.setVersion(ComponentParser.text(profile.getPlayerCount())
8284
.replacements(replacements)
83-
.consumer(text -> {
85+
.function(text -> {
8486
if(plugin.getServer().getPluginManager().isPluginEnabled("PlaceholderAPI"))
85-
PlaceholderAPI.setPlaceholders(player, text);
87+
return PlaceholderAPI.setPlaceholders(player, text);
88+
89+
return text;
8690
})
8791
.toString());
8892
event.setProtocolVersion(-1);
@@ -100,9 +104,16 @@ private List<PlayerProfile> getPlayers(List<String> lines, Map<String, Object> r
100104
List<PlayerProfile> players = new ArrayList<>();
101105
lines.forEach(line -> players.add(Bukkit.createProfile(UUID.randomUUID(), ComponentParser.text(line)
102106
.replacements(replacements)
103-
.consumer(text -> {
104-
if(plugin.getServer().getPluginManager().isPluginEnabled("PlaceholderAPI"))
105-
PlaceholderAPI.setPlaceholders(player, text);
107+
.function(text -> {
108+
plugin.getPluginLogger().info("Before: " + text);
109+
if(plugin.getServer().getPluginManager().isPluginEnabled("PlaceholderAPI")){
110+
String after = PlaceholderAPI.setPlaceholders(player, text);
111+
112+
plugin.getPluginLogger().info("After: " + after);
113+
return after;
114+
}
115+
116+
return text;
106117
})
107118
.toString())));
108119

paper/src/main/resources/plugin.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@ description: '${plugin.description}'
55

66
main: 'ch.andre601.advancedserverlist.paper.PaperCore'
77

8+
api-version: 1.19
9+
10+
softdepend:
11+
- 'PlaceholderAPI'
12+
813
commands:
914
advancedserverlist:
1015
description: 'Main command of AdvancedServerList'

0 commit comments

Comments
 (0)