refactor(core): move profile_types.ts to primtives

tsc036 · thePunderWoman · commit 41466a7bbf3a · 2025-11-06T22:22:37.000Z
move profile_types.ts so the types can be used in Wiz code (cherry picked from commit cf47ce2)
diff --git a/devtools/projects/ng-devtools-backend/src/lib/hooks/profiler/native.ts b/devtools/projects/ng-devtools-backend/src/lib/hooks/profiler/native.ts
@@ -7,7 +7,6 @@
  */
 
 import {ɵProfilerEvent} from '@angular/core';
-
 import {getDirectiveHostElement} from '../../directive-forest';
 import {ngDebugClient} from '../../ng-debug-api/ng-debug-api';
 import {runOutsideAngular} from '../../utils';
diff --git a/packages/core/BUILD.bazel b/packages/core/BUILD.bazel
@@ -39,6 +39,7 @@ ng_project(
         "//packages/core/primitives/di",
         "//packages/core/primitives/dom-navigation",
         "//packages/core/primitives/event-dispatch",
+        "//packages/core/primitives/profiler",
         "//packages/core/primitives/signals",
         "//packages/core/src/compiler",
         "//packages/core/src/di/interface",
diff --git a/packages/core/primitives/profiler/BUILD.bazel b/packages/core/primitives/profiler/BUILD.bazel
@@ -0,0 +1,24 @@
+load("//tools:defaults.bzl", "ts_project")
+
+package(default_visibility = [
+    "//packages:__pkg__",
+    "//packages/core:__subpackages__",
+])
+
+ts_project(
+    name = "profiler",
+    srcs = glob(
+        [
+            "**/*.ts",
+        ],
+    ),
+)
+
+filegroup(
+    name = "files_for_docgen",
+    srcs = glob([
+        "*.ts",
+        "src/**/*.ts",
+    ]),
+    visibility = ["//visibility:public"],
+)
diff --git a/packages/core/primitives/profiler/README.md b/packages/core/primitives/profiler/README.md
@@ -0,0 +1,3 @@
+# Angular Profiler Types
+
+This directory contains types related to the [Angular Devtools Profiler](https://angular.dev/tools/devtools/profiler). These types are for code that needs to hook into the Angular Devtools Profiler lifecycle.
diff --git a/packages/core/primitives/profiler/src/profiler_types.ts b/packages/core/primitives/profiler/src/profiler_types.ts
diff --git a/packages/core/src/application/application_ref.ts b/packages/core/src/application/application_ref.ts
@@ -46,7 +46,7 @@ import {TESTABILITY} from '../testability/testability';
 import {NgZone} from '../zone/ng_zone';
 
 import {profiler} from '../render3/profiler';
-import {ProfilerEvent} from '../render3/profiler_types';
+import {ProfilerEvent} from '../../primitives/profiler/src/profiler_types';
 import {EffectScheduler} from '../render3/reactivity/root_effect_scheduler';
 import {isReactiveLViewConsumer} from '../render3/reactive_lview_consumer';
 import {ApplicationInitStatus} from './application_init';
diff --git a/packages/core/src/application/create_application.ts b/packages/core/src/application/create_application.ts
@@ -19,7 +19,7 @@ import {ChangeDetectionScheduler} from '../change_detection/scheduling/zoneless_
 import {ChangeDetectionSchedulerImpl} from '../change_detection/scheduling/zoneless_scheduling_impl';
 import {bootstrap} from '../platform/bootstrap';
 import {profiler} from '../render3/profiler';
-import {ProfilerEvent} from '../render3/profiler_types';
+import {ProfilerEvent} from '../../primitives/profiler/src/profiler_types';
 import {errorHandlerEnvironmentInitializer} from '../error_handler';
 import {RuntimeError, RuntimeErrorCode} from '../errors';
 import {PlatformRef} from '../platform/platform_ref';
diff --git a/packages/core/src/core_render3_private_export.ts b/packages/core/src/core_render3_private_export.ts
@@ -269,7 +269,10 @@ export {
 } from './render3/jit/partial';
 export {compilePipe as ɵcompilePipe} from './render3/jit/pipe';
 export {isNgModule as ɵisNgModule} from './render3/jit/util';
-export {Profiler as ɵProfiler, ProfilerEvent as ɵProfilerEvent} from './render3/profiler_types';
+export {
+  Profiler as ɵProfiler,
+  ProfilerEvent as ɵProfilerEvent,
+} from '../primitives/profiler/src/profiler_types';
 export {
   FrameworkAgnosticGlobalUtils as ɵFrameworkAgnosticGlobalUtils,
   GlobalDevModeUtils as ɵGlobalDevModeUtils,
diff --git a/packages/core/src/defer/rendering.ts b/packages/core/src/defer/rendering.ts
@@ -52,7 +52,7 @@ import {
   getTemplateIndexForState,
 } from './utils';
 import {profiler} from '../render3/profiler';
-import {ProfilerEvent} from '../render3/profiler_types';
+import {ProfilerEvent} from '../../primitives/profiler/src/profiler_types';
 import {addLViewToLContainer, removeLViewFromLContainer} from '../render3/view/container';
 
 /**
diff --git a/packages/core/src/render3/after_render/manager.ts b/packages/core/src/render3/after_render/manager.ts
@@ -18,7 +18,7 @@ import {type DestroyRef} from '../../linker/destroy_ref';
 import {NgZone} from '../../zone';
 import {AFTER_RENDER_SEQUENCES_TO_ADD, FLAGS, LView, LViewFlags} from '../interfaces/view';
 import {profiler} from '../profiler';
-import {ProfilerEvent} from '../profiler_types';
+import {ProfilerEvent} from '../../../primitives/profiler/src/profiler_types';
 import {markAncestorsForTraversal} from '../util/view_utils';
 import {AfterRenderPhase, AfterRenderRef} from './api';
 
diff --git a/packages/core/src/render3/component_ref.ts b/packages/core/src/render3/component_ref.ts
@@ -72,7 +72,7 @@ import {
   stringifyCSSSelectorList,
 } from './node_selector_matcher';
 import {profiler} from './profiler';
-import {ProfilerEvent} from './profiler_types';
+import {ProfilerEvent} from '../../primitives/profiler/src/profiler_types';
 import {executeContentQueries} from './queries/query_execution';
 import {enterView, leaveView} from './state';
 import {debugStringifyTypeForError, stringifyForError} from './util/stringify_utils';
diff --git a/packages/core/src/render3/debug/chrome_dev_tools_performance.ts b/packages/core/src/render3/debug/chrome_dev_tools_performance.ts
@@ -10,7 +10,7 @@ import {isTypeProvider} from '../../di/provider_collection';
 import {assertDefined, assertEqual} from '../../util/assert';
 import {performanceMarkFeature} from '../../util/performance';
 import {setProfiler} from '../profiler';
-import {Profiler, ProfilerEvent} from '../profiler_types';
+import {Profiler, ProfilerEvent} from '../../../primitives/profiler/src/profiler_types';
 import {stringifyForError} from '../util/stringify_utils';
 import {
   InjectorProfiler,
diff --git a/packages/core/src/render3/hooks.ts b/packages/core/src/render3/hooks.ts
@@ -35,7 +35,7 @@ import {
   TView,
 } from './interfaces/view';
 import {profiler} from './profiler';
-import {ProfilerEvent} from './profiler_types';
+import {ProfilerEvent} from '../../primitives/profiler/src/profiler_types';
 import {isInCheckNoChangesMode} from './state';
 
 /**
diff --git a/packages/core/src/render3/instructions/change_detection.ts b/packages/core/src/render3/instructions/change_detection.ts
@@ -67,7 +67,7 @@ import {
 
 import {isDestroyed} from '../interfaces/type_checks';
 import {profiler} from '../profiler';
-import {ProfilerEvent} from '../profiler_types';
+import {ProfilerEvent} from '../../../primitives/profiler/src/profiler_types';
 import {executeViewQueryFn, refreshContentQueries} from '../queries/query_execution';
 import {runEffectsInView} from '../reactivity/view_effect_runner';
 import {executeTemplate} from './shared';
diff --git a/packages/core/src/render3/instructions/render.ts b/packages/core/src/render3/instructions/render.ts
@@ -22,7 +22,7 @@ import {
   TView,
 } from '../interfaces/view';
 import {profiler} from '../profiler';
-import {ProfilerEvent} from '../profiler_types';
+import {ProfilerEvent} from '../../../primitives/profiler/src/profiler_types';
 import {executeViewQueryFn, refreshContentQueries} from '../queries/query_execution';
 import {enterView, leaveView} from '../state';
 import {getComponentLViewByIndex, isCreationMode} from '../util/view_utils';
diff --git a/packages/core/src/render3/instructions/shared.ts b/packages/core/src/render3/instructions/shared.ts
@@ -57,7 +57,7 @@ import {
 import {assertTNodeType} from '../node_assert';
 import {isNodeMatchingSelectorList} from '../node_selector_matcher';
 import {profiler} from '../profiler';
-import {ProfilerEvent} from '../profiler_types';
+import {ProfilerEvent} from '../../../primitives/profiler/src/profiler_types';
 import {
   getCurrentDirectiveIndex,
   getCurrentTNode,
diff --git a/packages/core/src/render3/node_manipulation.ts b/packages/core/src/render3/node_manipulation.ts
@@ -79,7 +79,7 @@ import {
 } from './interfaces/view';
 import {assertTNodeType} from './node_assert';
 import {profiler} from './profiler';
-import {ProfilerEvent} from './profiler_types';
+import {ProfilerEvent} from '../../primitives/profiler/src/profiler_types';
 import {getLViewParent, getNativeByTNode, unwrapRNode} from './util/view_utils';
 import {allLeavingAnimations} from '../animation/longest_animation';
 import {Injector} from '../di';
diff --git a/packages/core/src/render3/profiler.ts b/packages/core/src/render3/profiler.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import {type Profiler} from './profiler_types';
+import {type Profiler} from '../../primitives/profiler/src/profiler_types';
 
 const profilerCallbacks: Profiler[] = [];
 
diff --git a/packages/core/src/render3/view/listeners.ts b/packages/core/src/render3/view/listeners.ts
@@ -20,7 +20,7 @@ import {
   unwrapRNode,
 } from '../util/view_utils';
 import {profiler} from '../profiler';
-import {ProfilerEvent} from '../profiler_types';
+import {ProfilerEvent} from '../../../primitives/profiler/src/profiler_types';
 import {markViewDirty} from '../instructions/mark_view_dirty';
 import type {RElement} from '../interfaces/renderer_dom';
 import type {GlobalTargetResolver, Renderer} from '../interfaces/renderer';
diff --git a/packages/core/test/acceptance/BUILD.bazel b/packages/core/test/acceptance/BUILD.bazel
@@ -24,6 +24,7 @@ ts_project(
         "//packages/common/locales",
         "//packages/compiler",
         "//packages/core",
+        "//packages/core/primitives/profiler",
         "//packages/core/primitives/signals",
         "//packages/core/src/di/interface",
         "//packages/core/src/util",
diff --git a/packages/core/test/acceptance/profiler_spec.ts b/packages/core/test/acceptance/profiler_spec.ts
@@ -7,7 +7,7 @@
  */
 
 import {setProfiler, profiler} from '../../src/render3/profiler';
-import {ProfilerEvent} from '../../src/render3/profiler_types';
+import {ProfilerEvent} from '../../primitives/profiler/src/profiler_types';
 import {TestBed} from '../../testing';
 
 import {

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+# Angular Profiler Types`
	`2`	`+`
	`3`	`+This directory contains types related to the [Angular Devtools Profiler](https://angular.dev/tools/devtools/profiler). These types are for code that needs to hook into the Angular Devtools Profiler lifecycle.`