refactor(animations): drop warning functions in production (angular#59408)

Prior to this commit, functions that issued warnings were not wrapped with `ngDevMode` at the point
of invocation but had the `ngDevMode` check inside. This meant they acted as no-ops in production.
In this commit, we wrap them externally with `ngDevMode`, so they are entirely removed.

PR Close angular#59408

Author: arturovt

packages/animations/browser/src/dsl/animation.ts

@@ -35,8 +35,10 @@ export class Animation {
     if (errors.length) {
       throw validationFailed(errors);
     }
-    if (warnings.length) {
-      warnValidation(warnings);
+    if (typeof ngDevMode === 'undefined' || ngDevMode) {
+      if (warnings.length) {
+        warnValidation(warnings);
+      }
     }
     this._animationAst = ast;
   }

packages/animations/browser/src/render/animation_engine_next.ts

@@ -61,8 +61,10 @@ export class AnimationEngine {
       if (errors.length) {
         throw triggerBuildFailed(name, errors);
       }
-      if (warnings.length) {
-        warnTriggerBuild(name, warnings);
+      if (typeof ngDevMode === 'undefined' || ngDevMode) {
+        if (warnings.length) {
+          warnTriggerBuild(name, warnings);
+        }
       }
       trigger = buildTrigger(name, ast, this._normalizer);
       this._triggerCache[cacheKey] = trigger;

packages/animations/browser/src/render/timeline_animation_engine.ts

@@ -58,8 +58,10 @@ export class TimelineAnimationEngine {
     if (errors.length) {
       throw registerFailed(errors);
     } else {
-      if (warnings.length) {
-        warnRegister(warnings);
+      if (typeof ngDevMode === 'undefined' || ngDevMode) {
+        if (warnings.length) {
+          warnRegister(warnings);
+        }
       }
       this._animations.set(id, ast);
     }

packages/animations/browser/src/warning_helpers.ts

@@ -15,31 +15,27 @@ function createListOfWarnings(warnings: string[]): string {
 }
 
 export function warnValidation(warnings: string[]): void {
-  (typeof ngDevMode === 'undefined' || ngDevMode) &&
-    console.warn(`animation validation warnings:${createListOfWarnings(warnings)}`);
+  console.warn(`animation validation warnings:${createListOfWarnings(warnings)}`);
 }
 
 export function warnTriggerBuild(name: string, warnings: string[]): void {
-  (typeof ngDevMode === 'undefined' || ngDevMode) &&
-    console.warn(
-      `The animation trigger "${name}" has built with the following warnings:${createListOfWarnings(
-        warnings,
-      )}`,
-    );
+  console.warn(
+    `The animation trigger "${name}" has built with the following warnings:${createListOfWarnings(
+      warnings,
+    )}`,
+  );
 }
 
 export function warnRegister(warnings: string[]): void {
-  (typeof ngDevMode === 'undefined' || ngDevMode) &&
-    console.warn(`Animation built with the following warnings:${createListOfWarnings(warnings)}`);
+  console.warn(`Animation built with the following warnings:${createListOfWarnings(warnings)}`);
 }
 
 export function triggerParsingWarnings(name: string, warnings: string[]): void {
-  (typeof ngDevMode === 'undefined' || ngDevMode) &&
-    console.warn(
-      `Animation parsing for the ${name} trigger presents the following warnings:${createListOfWarnings(
-        warnings,
-      )}`,
-    );
+  console.warn(
+    `Animation parsing for the ${name} trigger presents the following warnings:${createListOfWarnings(
+      warnings,
+    )}`,
+  );
 }
 
 export function pushUnrecognizedPropertiesWarning(warnings: string[], props: string[]): void {