Impulse length option

Andrews54757 · Andrews54757 · commit c5038bbd46a6 · 2025-09-19T17:26:58.000-04:00
diff --git a/chrome/_locales/de/messages.json b/chrome/_locales/de/messages.json
@@ -779,6 +779,9 @@
     "audioconvolver_normalize": {
         "message": "Normalisieren"
     },
+    "audioconvolver_impulselength": {
+        "message": "Impuls Länge"
+    },
     "audioconvolver_impulseresponse": {
         "message": "Impulsantwort"
     },
diff --git a/chrome/_locales/en/messages.json b/chrome/_locales/en/messages.json
@@ -779,6 +779,9 @@
     "audioconvolver_normalize": {
         "message": "Normalize"
     },
+    "audioconvolver_impulselength": {
+        "message": "Impulse Length"
+    },
     "audioconvolver_impulseresponse": {
         "message": "Impulse Response"
     },
diff --git a/chrome/_locales/es/messages.json b/chrome/_locales/es/messages.json
@@ -779,6 +779,9 @@
     "audioconvolver_normalize": {
         "message": "Normalizar"
     },
+    "audioconvolver_impulselength": {
+        "message": "Longitud del Impulso"
+    },
     "audioconvolver_impulseresponse": {
         "message": "Respuesta al Impulso"
     },
diff --git a/chrome/_locales/fr/messages.json b/chrome/_locales/fr/messages.json
@@ -779,6 +779,9 @@
     "audioconvolver_normalize": {
         "message": "Normaliser"
     },
+    "audioconvolver_impulselength": {
+        "message": "Durée de l'impulsion"
+    },
     "audioconvolver_impulseresponse": {
         "message": "Réponse impulsionnelle"
     },
diff --git a/chrome/_locales/id/messages.json b/chrome/_locales/id/messages.json
@@ -779,6 +779,9 @@
     "audioconvolver_normalize": {
         "message": "Normalisasi"
     },
+    "audioconvolver_impulselength": {
+        "message": "Panjang Impuls"
+    },
     "audioconvolver_impulseresponse": {
         "message": "Respon Impuls"
     },
diff --git a/chrome/_locales/it/messages.json b/chrome/_locales/it/messages.json
@@ -779,6 +779,9 @@
     "audioconvolver_normalize": {
         "message": "Normalizza"
     },
+    "audioconvolver_impulselength": {
+        "message": "Lunghezza Impulso"
+    },
     "audioconvolver_impulseresponse": {
         "message": "Risposta all'Impulso"
     },
diff --git a/chrome/_locales/ja/messages.json b/chrome/_locales/ja/messages.json
@@ -779,6 +779,9 @@
     "audioconvolver_normalize": {
         "message": "正規化"
     },
+    "audioconvolver_impulselength": {
+        "message": "インパルス長"
+    },
     "audioconvolver_impulseresponse": {
         "message": "インパルス応答"
     },
diff --git a/chrome/_locales/ko/messages.json b/chrome/_locales/ko/messages.json
@@ -779,6 +779,9 @@
     "audioconvolver_normalize": {
         "message": "정규화"
     },
+    "audioconvolver_impulselength": {
+        "message": "임펄스 길이"
+    },
     "audioconvolver_impulseresponse": {
         "message": "임펄스 응답"
     },
diff --git a/chrome/_locales/ms/messages.json b/chrome/_locales/ms/messages.json
@@ -779,6 +779,9 @@
     "audioconvolver_normalize": {
         "message": "Normalize"
     },
+    "audioconvolver_impulselength": {
+        "message": "Impulse Length"
+    },
     "audioconvolver_impulseresponse": {
         "message": "Impulse Response"
     },
diff --git a/chrome/_locales/nl/messages.json b/chrome/_locales/nl/messages.json
@@ -779,6 +779,9 @@
     "audioconvolver_normalize": {
         "message": "Normaliseren"
     },
+    "audioconvolver_impulselength": {
+        "message": "Impulslengte"
+    },
     "audioconvolver_impulseresponse": {
         "message": "Impulsrespons"
     },
diff --git a/chrome/_locales/pl/messages.json b/chrome/_locales/pl/messages.json
@@ -779,6 +779,9 @@
     "audioconvolver_normalize": {
         "message": "Normalizuj"
     },
+    "audioconvolver_impulselength": {
+        "message": "Długość impulsu"
+    },
     "audioconvolver_impulseresponse": {
         "message": "Odpowiedź impulsowa"
     },
diff --git a/chrome/_locales/pt_BR/messages.json b/chrome/_locales/pt_BR/messages.json
@@ -779,6 +779,9 @@
     "audioconvolver_normalize": {
         "message": "Normalizar"
     },
+    "audioconvolver_impulselength": {
+        "message": "Duração do impulso"
+    },
     "audioconvolver_impulseresponse": {
         "message": "Resposta ao impulso"
     },
diff --git a/chrome/_locales/ru/messages.json b/chrome/_locales/ru/messages.json
@@ -779,6 +779,9 @@
     "audioconvolver_normalize": {
         "message": "Нормализация"
     },
+    "audioconvolver_impulselength": {
+        "message": "Длина импульса"
+    },
     "audioconvolver_impulseresponse": {
         "message": "Импульсная характеристика"
     },
diff --git a/chrome/_locales/tr/messages.json b/chrome/_locales/tr/messages.json
@@ -779,6 +779,9 @@
     "audioconvolver_normalize": {
         "message": "Normalize Et"
     },
+    "audioconvolver_impulselength": {
+        "message": "İmpuls Uzunluğu"
+    },
     "audioconvolver_impulseresponse": {
         "message": "İmpuls Tepkisi"
     },
diff --git a/chrome/_locales/zh_CN/messages.json b/chrome/_locales/zh_CN/messages.json
@@ -779,6 +779,9 @@
     "audioconvolver_normalize": {
         "message": "归一化"
     },
+    "audioconvolver_impulselength": {
+        "message": "脉冲长度"
+    },
     "audioconvolver_impulseresponse": {
         "message": "脉冲响应"
     },
diff --git a/chrome/_locales/zh_TW/messages.json b/chrome/_locales/zh_TW/messages.json
@@ -779,6 +779,9 @@
     "audioconvolver_normalize": {
         "message": "正規化"
     },
+    "audioconvolver_impulselength": {
+        "message": "脈衝長度"
+    },
     "audioconvolver_impulseresponse": {
         "message": "脈衝響應"
     },
diff --git a/chrome/player/assets/fluidplayer/css/fluidplayer.css b/chrome/player/assets/fluidplayer/css/fluidplayer.css
@@ -3050,7 +3050,7 @@ input.crosstalk_calculator_input {
 /* ---------- Controls row ---------- */
 .convolver_controls {
   display: grid;
-  grid-template-columns: 1fr 1fr;
+  grid-template-columns: 1fr 1fr 1fr;
   align-items: center;
   justify-content: space-between;
   gap: 12px;
@@ -3178,4 +3178,45 @@ input.crosstalk_calculator_input {
 
 .convolver_channel_label.disabled {
     color: rgba(255, 255, 255, 0.6);
+}
+
+.convolver_impulse_length_container {
+    display: flex;
+    flex-direction: row;
+    align-items: center;
+    border: 1px solid rgba(255, 255, 255, 0.2);
+    border-radius: 3px;
+    line-height: 30px;
+    padding: 0px 10px;
+    gap: 4px;
+}
+
+.convolver_impulse_length_container .convolver_impulse_length_label {
+    font-size: 13px;
+    color: rgba(255, 255, 255, 0.8);
+    white-space: nowrap;
+    user-select: none;
+}
+
+.convolver_impulse_length_container .convolver_impulse_length_input {
+    width: 50px;
+    height: 20px;
+    line-height: 20px;
+    border-radius: 2px;
+    text-align: center;
+    font-size: 12px;
+    color: rgba(255, 255, 255, 0.8);
+    background-color: rgba(255, 255, 255, 0.1);
+    border: none;
+    outline: none;
+}
+
+.convolver_impulse_length_container .convolver_impulse_length_input:focus {
+    outline: 1px solid rgba(255, 255, 255, 0.5);
+}
+
+.convolver_impulse_length_container .convolver_impulse_length_input::-webkit-inner-spin-button,
+.convolver_impulse_length_container .convolver_impulse_length_input::-webkit-outer-spin-button {
+    -webkit-appearance: none;
+    margin: 0;
 }
diff --git a/chrome/player/ui/audio/OutputConvolver.mjs b/chrome/player/ui/audio/OutputConvolver.mjs
@@ -7,8 +7,6 @@ import {AbstractAudioModule} from './AbstractAudioModule.mjs';
 import {AudioConvolverControl} from './config/AudioConvolverControl.mjs';
 import {CHANNEL_NAMES, MAX_AUDIO_CHANNELS} from './config/AudioProfile.mjs';
 
-const IMPULSE_LENGTH = 4096; // max length of impulse response in samples
-
 export class OutputConvolver extends AbstractAudioModule {
   constructor(configManager) {
     super('OutputConvolver');
@@ -76,6 +74,7 @@ export class OutputConvolver extends AbstractAudioModule {
     const channelData = audioData.getChannelData(0);
 
     // trim to IMPULSE_LENGTH
+    const IMPULSE_LENGTH = this.config ? this.config.bufferSize : 2048;
     if (channelData.length > IMPULSE_LENGTH) {
       const trimmedData = channelData.slice(0, IMPULSE_LENGTH);
       const newBuffer = this.audioContext.createBuffer(1, IMPULSE_LENGTH, audioData.sampleRate);
@@ -112,6 +111,7 @@ export class OutputConvolver extends AbstractAudioModule {
     this.ui.convolverToggle.textContent = this.config.enabled ? Localize.getMessage('audioconvolver_enabled') : Localize.getMessage('audioconvolver_disabled');
     this.ui.downmixToggle.classList.toggle('enabled', this.config.downmix);
     this.ui.downmixToggle.textContent = this.config.downmix ? Localize.getMessage('audioconvolver_downmix_on') : Localize.getMessage('audioconvolver_downmix_off');
+    this.ui.impulseLengthInput.value = this.config.bufferSize;
 
     for (const channel of this.convolverChannels) {
       const channelConfig = this.config.channels[channel.id];
@@ -288,6 +288,40 @@ export class OutputConvolver extends AbstractAudioModule {
       this.saveConfig();
     });
 
+    this.ui.impulseLengthContainer = WebUtils.create('div', null, 'convolver_impulse_length_container');
+    this.ui.convolverControls.appendChild(this.ui.impulseLengthContainer);
+
+    const impulseLengthLabel = WebUtils.create('div', null, 'convolver_impulse_length_label');
+    impulseLengthLabel.textContent = Localize.getMessage('audioconvolver_impulselength');
+    this.ui.impulseLengthContainer.appendChild(impulseLengthLabel);
+    const impulseLengthInput = WebUtils.create('input', null, 'convolver_impulse_length_input');
+    impulseLengthInput.type = 'number';
+    impulseLengthInput.addEventListener('keydown', (e) => {
+      e.stopPropagation();
+    });
+    impulseLengthInput.addEventListener('keyup', (e) => {
+      e.stopPropagation();
+    });
+    impulseLengthInput.addEventListener('change', () => {
+      if (!this.config) {
+        return;
+      }
+      let val = parseInt(impulseLengthInput.value);
+      if (isNaN(val) || val < 128) {
+        val = 128;
+      } else if (val > 16384) {
+        val = 16384;
+      }
+      impulseLengthInput.value = val;
+      this.config.bufferSize = val;
+      this.saveConfig();
+      this.loadImpulseResponses();
+    });
+
+    this.ui.impulseLengthInput = impulseLengthInput;
+    this.ui.impulseLengthContainer.appendChild(impulseLengthInput);
+
+
     this.ui.convolverChannelTable = WebUtils.create('div', null, 'convolver_channel_table');
     this.ui.convolverContainer.appendChild(this.ui.convolverChannelTable);
 
diff --git a/chrome/player/ui/audio/config/AudioConvolverControl.mjs b/chrome/player/ui/audio/config/AudioConvolverControl.mjs
@@ -31,9 +31,11 @@ export class AudioConvolverChannel {
 }
 
 export class AudioConvolverControl {
-  constructor(enabled, downmix, channels) {
+  constructor(enabled, downmix, bufferSize, channels) {
     this.enabled = !!enabled;
     this.downmix = !!downmix;
+    this.bufferSize = bufferSize;
+
     this.channels = channels || [];
   }
 
@@ -48,20 +50,20 @@ export class AudioConvolverControl {
         newChannels.push(AudioConvolverChannel.default(i));
       }
     }
-    return new AudioConvolverControl(obj.enabled, obj.downmix, newChannels);
+    return new AudioConvolverControl(obj.enabled, obj.downmix, obj.bufferSize ?? 2048, newChannels);
   }
 
   static default() {
     const channels = [];
     for (let i = 0; i < MAX_AUDIO_CHANNELS; i++) {
       channels.push(AudioConvolverChannel.default(i));
     }
-    return new AudioConvolverControl(false, true, channels);
+    return new AudioConvolverControl(false, true, 2048, channels);
   }
 
   isDefault() {
     const def = AudioConvolverControl.default();
-    if (this.enabled !== def.enabled || this.downmix !== def.downmix) {
+    if (this.enabled !== def.enabled || this.downmix !== def.downmix || this.bufferSize !== def.bufferSize) {
       return false;
     }
     if (this.channels.length !== def.channels.length) {
@@ -79,6 +81,7 @@ export class AudioConvolverControl {
     return {
       enabled: this.enabled,
       downmix: this.downmix,
+      bufferSize: this.bufferSize,
       channels: this.channels.filter((ch) => !ch.isDefault()).map((ch) => ch.toObj()),
     };
   }
diff --git a/combined-locales.json b/combined-locales.json
@@ -4679,6 +4679,24 @@
         "zh_CN": "归一化",
         "zh_TW": "正規化"
     },
+    "audioconvolver_impulselength": {
+        "en": "Impulse Length",
+        "de": "Impuls Länge",
+        "es": "Longitud del Impulso",
+        "fr": "Durée de l'impulsion",
+        "id": "Panjang Impuls",
+        "it": "Lunghezza Impulso",
+        "ja": "インパルス長",
+        "ko": "임펄스 길이",
+        "ms": "Impulse Length",
+        "nl": "Impulslengte",
+        "pl": "Długość impulsu",
+        "pt_BR": "Duração do impulso",
+        "ru": "Длина импульса",
+        "tr": "İmpuls Uzunluğu",
+        "zh_CN": "脉冲长度",
+        "zh_TW": "脈衝長度"
+    },
     "audioconvolver_impulseresponse": {
         "en": "Impulse Response",
         "de": "Impulsantwort",
