The list adapter was not being updated properly when the test suite was ran

Author: Fuzion24

app/src/main/java/fuzion24/device/vulnerability/test/adapter/RecyclerAdapter.java

@@ -31,11 +31,16 @@
 public class RecyclerAdapter extends RecyclerView.Adapter<RecyclerView.ViewHolder> {
 
     private static final String TAG = "RecycleAdapter";
-    final private List<Pair<VulnerabilityTestResult, VulnerabilityDescriptor>> mResults;
+    private List<Pair<VulnerabilityTestResult, VulnerabilityDescriptor>> mResults;
     private Context mContext;
 
     public RecyclerAdapter(Context context, List<VulnerabilityTestResult> itemList) {
         this.mContext = context;
+        this.mResults = buildResultDescriptionMap(context, itemList);
+    }
+
+
+    private static List<Pair<VulnerabilityTestResult, VulnerabilityDescriptor>> buildResultDescriptionMap(Context context, List<VulnerabilityTestResult> itemList){
         List<Pair<VulnerabilityTestResult, VulnerabilityDescriptor>> res = new ArrayList<>();
 
         try {
@@ -61,7 +66,14 @@ public int compare(Pair<VulnerabilityTestResult, VulnerabilityDescriptor> lhs, P
         }catch(Exception e){
             e.printStackTrace();
         }
-        mResults = res;
+        return res;
+
+    }
+
+
+    public void updateResults(List<VulnerabilityTestResult> itemList){
+        mResults = buildResultDescriptionMap(mContext, itemList);
+        notifyDataSetChanged();
     }
 
     @Override

app/src/main/java/fuzion24/device/vulnerability/test/ui/MainActivity.java

@@ -125,7 +125,7 @@ public boolean onOptionsItemSelected(MenuItem item) {
         switch (itemId) {
             case R.id.menu_export_results:
             case R.id.menu_share_results:
-                if (testResults == null) {
+                if (testResults == null || testResults.isEmpty()) {
                     Snackbar.make(coordinatorLayout, R.string.run_tests, Snackbar.LENGTH_LONG).setAction(R.string.start, new View.OnClickListener() {
                         @Override
                         public void onClick(View v) {
@@ -206,7 +206,6 @@ private JSONObject serializeResults(List<VulnerabilityTestResult> results, Devic
         return combinedResults;
     }
 
-
     private void runTestsSuit() {
         new VulnerabilityTestRunner(MainActivity.this, true, new ResultsCallback() {
             @Override
@@ -217,7 +216,7 @@ public void finished(final List<VulnerabilityTestResult> results) {
                 testResults.addAll(results);
 
                 emptyView.setVisibility(View.GONE);
-                recyclerAdapter.notifyDataSetChanged();
+                recyclerAdapter.updateResults(results);
             }
         }).execute();
     }