Skip to content

Commit d7319c4

Browse files
committed
Compartor requires return value to be >0 <0
1 parent 77d8572 commit d7319c4

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

app/src/main/java/fuzion24/device/vulnerability/test/adapter/RecyclerAdapter.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import android.graphics.Color;
55
import android.support.v7.widget.RecyclerView;
66
import android.text.TextUtils;
7+
import android.util.Log;
78
import android.util.Pair;
89
import android.view.LayoutInflater;
910
import android.view.View;
@@ -29,6 +30,7 @@
2930

3031
public class RecyclerAdapter extends RecyclerView.Adapter<RecyclerView.ViewHolder> {
3132

33+
private static final String TAG = "RecycleAdapter";
3234
final private List<Pair<VulnerabilityTestResult, VulnerabilityDescriptor>> mResults;
3335
private Context mContext;
3436

@@ -40,7 +42,11 @@ public RecyclerAdapter(Context context, List<VulnerabilityTestResult> itemList)
4042
Map<String, VulnerabilityDescriptor> vMap = VulnerabilityDescriptor.getParsedVulnMap(context);
4143

4244
for (VulnerabilityTestResult vtr : itemList) {
43-
VulnerabilityDescriptor vd = vMap.get(vtr.getCVEorID());
45+
String cveOrId = vtr.getCVEorID();
46+
VulnerabilityDescriptor vd = vMap.get(cveOrId);
47+
if(vd == null){
48+
Log.d(TAG, cveOrId + " has a null vulnerability descriptor");
49+
}
4450
res.add(Pair.create(vtr, vd));
4551
}
4652

@@ -49,7 +55,7 @@ public RecyclerAdapter(Context context, List<VulnerabilityTestResult> itemList)
4955
public int compare(Pair<VulnerabilityTestResult, VulnerabilityDescriptor> lhs, Pair<VulnerabilityTestResult, VulnerabilityDescriptor> rhs) {
5056
VulnerabilityDescriptor lhDesc = lhs.second;
5157
VulnerabilityDescriptor rhDesc = rhs.second;
52-
return lhDesc.getCVEDate().before(rhDesc.getCVEDate()) ? 0 : 1;
58+
return lhDesc.getCVEDate().before(rhDesc.getCVEDate()) ? 1 : -1;
5359
}
5460
});
5561
}catch(Exception e){

0 commit comments

Comments
 (0)