Merge pull request #78 from AnduroProject/AN-476-add-preconf-output-validation

including tx validation on consensus level and change size validation…

Author: sucildossj

src/policy/policy.cpp

@@ -172,6 +172,12 @@ bool IsStandardTx(const CTransaction& tx, const std::optional<unsigned>& max_dat
         } else if ((whichType == TxoutType::MULTISIG) && (!permit_bare_multisig)) {
             reason = "bare-multisig";
             return false;
+
+        } else if (IsDust(txout, dust_relay_fee)) {
+            if ((tx.nVersion != TRANSACTION_COORDINATE_ASSET_CREATE_VERSION && tx.nVersion != TRANSACTION_COORDINATE_ASSET_TRANSFER_VERSION && tx.nVersion != TRANSACTION_PRECONF_VERSION) || txout.nValue == 0) {
+               reason = "dust";
+               return false;
+            }
         }
     }
 

src/primitives/transaction.cpp

@@ -144,6 +144,7 @@ std::string CTransaction::ToString() const
 }
 
 bool CTransaction::HasValidOutputCount() const {
+
    if(this->version == TRANSACTION_PRECONF_VERSION || this->version == TRANSACTION_COORDINATE_ASSET_CREATE_VERSION) {
        return this->vout.size() > 1;
    }

src/validation.cpp

@@ -3312,7 +3312,6 @@ bool Chainstate::ConnectSignedBlock(const SignedBlock& block) {
     std::vector<PrecomputedTransactionData> txsdata(block.vtx.size());
     for (unsigned int i = 0; i < block.vtx.size(); i++) {
         CTransactionRef ptx = block.vtx[i];
-
         const CTransaction& tx = *ptx;
         if (i != 0) {
             if (tx.version == TRANSACTION_PRECONF_VERSION && !tx.HasValidOutputCount()) {