misc: clippy :^)

Signed-off-by: Anhad Singh <[email protected]>

Author: Andy-Python-Programmer

.vscode/settings.json

@@ -16,4 +16,5 @@
         "termios.h": "c",
         "termios-c_iflag.h": "c"
     },
+    "rust-analyzer.check.command": "clippy",
 }

src/aero_kernel/build.rs

@@ -73,8 +73,8 @@ fn main() -> Result<(), Box<dyn Error>> {
     inc_files = inc_files
         .iter()
         .map(|e| {
-            let e = e.split("/").collect::<Vec<_>>();
-            e[..e.len() - 1].join("/").to_string()
+            let e = e.split('/').collect::<Vec<_>>();
+            e[..e.len() - 1].join("/")
         })
         .collect::<Vec<_>>();
 

src/aero_kernel/src/acpi/hpet.rs

@@ -36,8 +36,6 @@ pub(super) struct Hpet {
 
 impl Hpet {
     pub fn new(sdt: &'static Sdt) -> Self {
-        let this = unsafe { ptr::read((sdt as *const Sdt) as *const Self) };
-
-        this
+        unsafe { ptr::read((sdt as *const Sdt) as *const Self) }
     }
 }

src/aero_kernel/src/acpi/rsdp.rs

@@ -199,14 +199,14 @@ pub(super) fn find_rsdt_address(rsdp_address: VirtAddr) -> RsdtAddress {
         assert!(valid, "rsdp: failed to validate RSDP v20 checksum");
 
         let xsdt_address = PhysAddr::new(v20.xsdt_address).as_hhdm_virt();
-        return RsdtAddress::Xsdt(xsdt_address);
+        RsdtAddress::Xsdt(xsdt_address)
     } else {
         let v10 = unsafe { &*(rsdp_address.as_ptr() as *const Rsdp10) };
         let valid = validate_rsdt_checksum(v10);
 
         assert!(valid, "rsdp: failed to validate RSDP v10 checksum");
 
         let rsdt_address = PhysAddr::new(v10.rsdt_address as u64).as_hhdm_virt();
-        return RsdtAddress::Rsdt(rsdt_address);
+        RsdtAddress::Rsdt(rsdt_address)
     }
 }

src/aero_kernel/src/arch/x86_64/apic.rs

@@ -404,7 +404,7 @@ pub fn io_apic_set_redirect(vec: u8, gsi: u32, flags: u16, status: i32) {
         let ioredtbl = (gsi - entry.global_system_interrupt_base) * 2 + 16;
 
         unsafe {
-            io_apic_write(io_apic, ioredtbl + 0, redirect as _);
+            io_apic_write(io_apic, ioredtbl, redirect as _);
             io_apic_write(io_apic, ioredtbl + 1, (redirect as u64 >> 32) as _);
         }
 
@@ -468,5 +468,5 @@ pub fn init() -> ApicType {
         INTERRUPT_CONTROLLER.switch_to_apic();
     }
 
-    return apic_type;
+    apic_type
 }

src/aero_kernel/src/arch/x86_64/interrupts/exceptions.rs

@@ -116,7 +116,7 @@ pub fn breakpoint(stack: &mut InterruptErrorStack) {
     //
     // So we will set the RIP to RIP - 1, pointing to the int3
     // instruction.
-    (*stack).stack.iret.rip -= 1;
+    stack.stack.iret.rip -= 1;
 }
 
 pub(super) fn page_fault(stack: &mut InterruptErrorStack) {

src/aero_kernel/src/arch/x86_64/interrupts/mod.rs

@@ -259,7 +259,7 @@ pub fn allocate_vector() -> u8 {
     static IDT_FREE_VECTOR: Mutex<u8> = Mutex::new(32);
 
     let mut fvector = IDT_FREE_VECTOR.lock();
-    let fcopy = fvector.clone();
+    let fcopy = *fvector;
 
     if fcopy == 0xf0 {
         panic!("allocate_vector: vector allocation exhausted")

src/aero_kernel/src/arch/x86_64/mod.rs

@@ -165,7 +165,7 @@ extern "C" fn arch_aero_main() -> ! {
         .first()
         .expect("limine: no framebuffer found!");
 
-    rendy::init(&*framebuffer, &command_line);
+    rendy::init(framebuffer, &command_line);
     logger::set_rendy_debug(true);
 
     interrupts::init();

src/aero_kernel/src/arch/x86_64/task.rs

@@ -240,8 +240,8 @@ impl ArchTask {
             user: true,
 
             // The FS and GS bases are inherited from the parent process.
-            fs_base: self.fs_base.clone(),
-            gs_base: self.gs_base.clone(),
+            fs_base: self.fs_base,
+            gs_base: self.gs_base,
 
             fpu_storage: Some(fpu_storage),
         })
@@ -296,8 +296,8 @@ impl ArchTask {
             user: true,
 
             // The FS and GS bases are inherited from the parent process.
-            fs_base: self.fs_base.clone(),
-            gs_base: self.gs_base.clone(),
+            fs_base: self.fs_base,
+            gs_base: self.gs_base,
 
             fpu_storage: Some(fpu_storage),
         })

src/aero_kernel/src/arch/x86_64/tls.rs

@@ -175,6 +175,6 @@ where
     let lock = CPU_INFO.lock();
 
     for info in lock.iter() {
-        f(&info);
+        f(info);
     }
 }