Refactoring DateTimeOnly

Author: AngeloDotNet

src/NET6CustomLibrary/DateTime/Converters/DateOnlyConverter.cs

@@ -1,22 +1,22 @@
 namespace NET6CustomLibrary.DateTime.Converters;
 
-//public class DateOnlyConverter : JsonConverter<DateOnly>
-//{
-//    public override DateOnly Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
-//    {
-//        var value = reader.GetString();
-//        return DateOnly.Parse(value);
-//    }
-
-//    public override void Write(Utf8JsonWriter writer, DateOnly value, JsonSerializerOptions options)
-//        => writer.WriteStringValue(value.ToString("yyyy-MM-dd"));
-//}
-
-public class DateOnlyConverter : ValueConverter<DateOnly, System.DateTime>
+public class DateOnlyConverter : JsonConverter<DateOnly>
 {
-    public DateOnlyConverter() : base(
-            dateOnly => dateOnly.ToDateTime(TimeOnly.MinValue),
-            dateTime => DateOnly.FromDateTime(dateTime))
+    public override DateOnly Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
     {
+        var value = reader.GetString();
+        return DateOnly.Parse(value);
     }
-}
+
+    public override void Write(Utf8JsonWriter writer, DateOnly value, JsonSerializerOptions options)
+        => writer.WriteStringValue(value.ToString("yyyy-MM-dd"));
+}
+
+//public class DateOnlyConverter : ValueConverter<DateOnly, System.DateTime>
+//{
+//    public DateOnlyConverter() : base(
+//            dateOnly => dateOnly.ToDateTime(TimeOnly.MinValue),
+//            dateTime => DateOnly.FromDateTime(dateTime))
+//    {
+//    }
+//}

src/NET6CustomLibrary/DateTime/Converters/TimeOnlyConverter.cs

@@ -1,24 +1,24 @@
 namespace NET6CustomLibrary.DateTime.Converters;
 
-//public class TimeOnlyConverter : JsonConverter<TimeOnly>
-//{
-//    public override TimeOnly Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
-//    {
-//        var value = reader.GetString();
-//        return TimeOnly.Parse(value!);
-//    }
-
-//    //public override void Write(Utf8JsonWriter writer, TimeOnly value, JsonSerializerOptions options)
-//    //    => writer.WriteStringValue(value.ToString("HH:mm:ss.fff"));
-//    public override void Write(Utf8JsonWriter writer, TimeOnly value, JsonSerializerOptions options)
-//        => writer.WriteStringValue(value.ToString("HH:mm:ss"));
-//}
-
-public class TimeOnlyConverter : ValueConverter<TimeOnly, TimeSpan>
+public class TimeOnlyConverter : JsonConverter<TimeOnly>
 {
-    public TimeOnlyConverter() : base(
-            timeOnly => timeOnly.ToTimeSpan(),
-            timeSpan => TimeOnly.FromTimeSpan(timeSpan))
+    public override TimeOnly Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
     {
+        var value = reader.GetString();
+        return TimeOnly.Parse(value!);
     }
-}
+
+    //public override void Write(Utf8JsonWriter writer, TimeOnly value, JsonSerializerOptions options)
+    //    => writer.WriteStringValue(value.ToString("HH:mm:ss.fff"));
+    public override void Write(Utf8JsonWriter writer, TimeOnly value, JsonSerializerOptions options)
+        => writer.WriteStringValue(value.ToString("HH:mm:ss"));
+}
+
+//public class TimeOnlyConverter : ValueConverter<TimeOnly, TimeSpan>
+//{
+//    public TimeOnlyConverter() : base(
+//            timeOnly => timeOnly.ToTimeSpan(),
+//            timeSpan => TimeOnly.FromTimeSpan(timeSpan))
+//    {
+//    }
+//}

src/NET6CustomLibrary/Extensions/DependencyInjection.cs

@@ -59,8 +59,8 @@ public static IMvcBuilder AddDateTimeJsonOptions(this IMvcBuilder builder)
         builder.AddJsonOptions(options =>
         {
             options.JsonSerializerOptions.DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull;
-            //options.JsonSerializerOptions.Converters.Add(new DateOnlyConverter());
-            //options.JsonSerializerOptions.Converters.Add(new TimeOnlyConverter());
+            options.JsonSerializerOptions.Converters.Add(new DateOnlyConverter());
+            options.JsonSerializerOptions.Converters.Add(new TimeOnlyConverter());
             options.JsonSerializerOptions.Converters.Add(new UtcDateTimeConverter());
         });