Refactor tests to use GetAllPagingAsync method

Replaced outdated and commented-out code in the `Tests` class with direct calls to the `GetAllPagingAsync` method for retrieving paginated data. Simplified test methods by removing intermediate query variables and ensuring consistency in the approach to pagination.

Updated the following test methods:
- `GetPaginatedEntitiesWithoutWhereAsync`: Removed old code and used `GetAllPagingAsync` with `pageNumber`, `pageSize`, `includes`, and `orderBy`.
- `GetPaginatedEntitiesWithoutIncludeAsync`: Replaced old code with `GetAllPagingAsync` using `pageNumber`, `pageSize`, `includes`, and `filter`.
- `GetPagingEntitiesAsync`: Updated to use `GetAllPagingAsync` with `pageNumber`, `pageSize`, `includes`, `orderBy`, and `ascending` for descending order.

Assertions remain unchanged, ensuring correctness of results. These changes streamline the tests and align them with the updated repository method.

Author: AngeloDotNet

src/ClassLibrary.EFCore.Tests/Tests.cs

@@ -171,9 +171,6 @@ public async Task GetPaginatedEntitiesAsync()
         await dbContext.Database.EnsureDeletedAsync();
         await dbContext.Database.EnsureCreatedAsync();
 
-        //var query = await repository.GetAllAsync(includes: q => q.Include(p => p.Indirizzo), filter: w => w.Id <= 10);
-        //var entities = await repository.GetPaginatedAsync(query, 2, 5);
-
         var entities = await repository.GetAllPagingAsync(pageNumber: 2, pageSize: 5, includes: q => q.Include(p => p.Indirizzo), filter: w => w.Id <= 10);
         var itemCount = entities.Items.Count;
 
@@ -182,26 +179,6 @@ public async Task GetPaginatedEntitiesAsync()
         Assert.Contains(entities.Items, x => x.Id == 8);
     }
 
-    //[Fact]
-    //public async Task GetPaginatedEntitiesWithoutIncludeAsync()
-    //{
-    //    using var dbContext = GetDbContext();
-    //    var repository = new Repository<Persone, int>(dbContext);
-
-    //    await dbContext.Database.EnsureDeletedAsync();
-    //    await dbContext.Database.EnsureCreatedAsync();
-
-    //    //var query = await repository.GetAllAsync(includes: q => q.Include(p => p.Indirizzo), filter: w => w.Id <= 10);
-    //    //var entities = await repository.GetPaginatedAsync(query, 2, 5);
-
-    //    var entities = await repository.GetAllPagingAsync(pageNumber: 2, pageSize: 5, includes: q => q.Include(p => p.Indirizzo), filter: w => w.Id <= 10);
-    //    var itemCount = entities.Items.Count;
-
-    //    Assert.NotNull(entities);
-    //    Assert.Equal(5, itemCount);
-    //    Assert.Contains(entities.Items, x => x.Id == 8);
-    //}
-
     [Fact]
     public async Task GetPaginatedEntitiesWithoutWhereAsync()
     {
@@ -211,9 +188,6 @@ public async Task GetPaginatedEntitiesWithoutWhereAsync()
         await dbContext.Database.EnsureDeletedAsync();
         await dbContext.Database.EnsureCreatedAsync();
 
-        //var query = await repository.GetAllAsync(includes: q => q.Include(p => p.Indirizzo), filter: null!, orderBy: x => x.Id);
-        //var entities = await repository.GetPaginatedAsync(query, 1, 5);
-
         var entities = await repository.GetAllPagingAsync(pageNumber: 1, pageSize: 5, includes: q => q.Include(p => p.Indirizzo), orderBy: x => x.Id);
         var itemCount = entities.Items.Count;
 
@@ -231,16 +205,12 @@ public async Task GetPaginatedEntitiesDescendingOrderTypeAsync()
         await dbContext.Database.EnsureDeletedAsync();
         await dbContext.Database.EnsureCreatedAsync();
 
-        //var query = await repository.GetAllAsync(includes: q => q.Include(p => p.Indirizzo), filter: null!, orderBy: x => x.Id, ascending: false);
-        //var entities = await repository.GetPaginatedAsync(query, 1, 5);
-
         var entities = await repository.GetAllPagingAsync(pageNumber: 1, pageSize: 5, includes: q => q.Include(p => p.Indirizzo), orderBy: x => x.Id, ascending: false);
         var itemCount = entities.Items.Count;
 
         Assert.NotNull(entities);
         Assert.Equal(5, itemCount);
         Assert.Equal(10, Assert.IsType<Persone>(entities.Items.First()).Id);
-        //Assert.Contains(query, x => x.Id == 8);
         Assert.Contains(entities.Items, x => x.Id == 8);
     }