comment

AngheloAlf · AngheloAlf · commit b3c092ff53eb · 2025-09-02T15:23:56.000-04:00
diff --git a/objdiff-core/src/arch/mips.rs b/objdiff-core/src/arch/mips.rs
@@ -125,6 +125,8 @@ impl ArchMips {
             let Ok(name) = obj_symbol.name() else { continue };
             if let Some(prefix) = name.strip_suffix(".NON_MATCHING") {
                 ignored_symbols.insert(obj_symbol.index().0);
+                // Only remove the prefixless symbols if we are on the Base side of the diff,
+                // to allow diffing against target objects that contain `.NON_MATCHING` markers.
                 if diff_side == DiffSide::Base
                     && let Some(target_symbol) = object.symbol_by_name(prefix)
                 {

Original file line number	Diff line number	Diff line change
`@@ -125,6 +125,8 @@ impl ArchMips {`
`125`	`125`	`let Ok(name) = obj_symbol.name() else { continue };`
`126`	`126`	`if let Some(prefix) = name.strip_suffix(".NON_MATCHING") {`
`127`	`127`	`ignored_symbols.insert(obj_symbol.index().0);`
	`128`	`+ // Only remove the prefixless symbols if we are on the Base side of the diff,`
	`129`	+ // to allow diffing against target objects that contain `.NON_MATCHING` markers.
`128`	`130`	`if diff_side == DiffSide::Base`
`129`	`131`	`&& let Some(target_symbol) = object.symbol_by_name(prefix)`
`130`	`132`	`{`