Skip to content

Commit 24ec419

Browse files
committed
Fix HtmlDifferenceEngineTest
1 parent a8263ce commit 24ec419

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

src/AngleSharp.Diffing.Tests/Core/HtmlDifferenceEngineTest.cs

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -357,13 +357,15 @@ public void Test2()
357357
results.ShouldBeEmpty();
358358
}
359359

360-
[Fact(DisplayName = "When comparer returns SkipChildren from an element comparison, child nodes are not compared")]
361-
public void Test3()
360+
[Theory(DisplayName = "When comparer returns SkipChildren flag from an element comparison, child nodes are not compared")]
361+
[InlineData(CompareResult.Same | CompareResult.SkipChildren)]
362+
[InlineData(CompareResult.Skip | CompareResult.SkipChildren)]
363+
public void Test3(CompareResult compareResult)
362364
{
363365
var sut = CreateHtmlDiffer(
364366
nodeMatcher: OneToOneNodeListMatcher,
365367
nodeFilter: NoneNodeFilter,
366-
nodeComparer: c => c.Control.Node.NodeName == "P" ? CompareResult.Same | CompareResult.SkipChildren : throw new Exception("NODE COMPARER SHOULD NOT BE CALLED ON CHILD NODES"),
368+
nodeComparer: c => c.Control.Node.NodeName == "P" ? compareResult : throw new Exception("NODE COMPARER SHOULD NOT BE CALLED ON CHILD NODES"),
367369
attrMatcher: AttributeNameMatcher,
368370
attrFilter: NoneAttrFilter,
369371
attrComparer: SameResultAttrComparer
@@ -374,13 +376,15 @@ public void Test3()
374376
results.ShouldBeEmpty();
375377
}
376378

377-
[Fact(DisplayName = "When comparer returns SkipAttributes from an element comparison, attributes are not compared")]
378-
public void Test4()
379+
[Theory(DisplayName = "When comparer returns SkipAttributes flag from an element comparison, attributes are not compared")]
380+
[InlineData(CompareResult.Same | CompareResult.SkipAttributes)]
381+
[InlineData(CompareResult.Skip | CompareResult.SkipAttributes)]
382+
public void Test4(CompareResult compareResult)
379383
{
380384
var sut = CreateHtmlDiffer(
381385
nodeMatcher: OneToOneNodeListMatcher,
382386
nodeFilter: NoneNodeFilter,
383-
nodeComparer: c => CompareResult.Same | CompareResult.SkipAttributes,
387+
nodeComparer: c => compareResult,
384388
attrMatcher: AttributeNameMatcher,
385389
attrFilter: NoneAttrFilter,
386390
attrComparer: SameResultAttrComparer

src/AngleSharp.Diffing/Core/HtmlDifferenceEngine.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ private IEnumerable<IDiff> CompareElement(in Comparison comparison)
111111
result.Add(new NodeDiff(comparison));
112112
}
113113

114-
if (compareRes != CompareResult.Skip)
114+
if (!compareRes.HasFlag(CompareResult.Skip))
115115
{
116116
if (!compareRes.HasFlag(CompareResult.SkipAttributes))
117117
result.AddRange(CompareElementAttributes(comparison));

0 commit comments

Comments
 (0)