Skip to content
This repository was archived by the owner on Jun 22, 2020. It is now read-only.

Commit dc5278f

Browse files
committed
fix: use correct types for order
1 parent 945c8a7 commit dc5278f

File tree

4 files changed

+15
-99
lines changed

4 files changed

+15
-99
lines changed

projects/table-builder/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@angular-ru/ng-table-builder",
3-
"version": "0.29.0",
3+
"version": "0.30.0",
44
"license": "MIT",
55
"bugs": {
66
"url": "https://github.com/Angular-RU/ng-table-builder/issues"

projects/table-builder/src/lib/table/interfaces/table-builder.external.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,5 +113,5 @@ export type ProduceDisableFn = ((item: TableRow) => boolean) | null;
113113

114114
export interface OrderedField {
115115
field: string;
116-
order: string;
116+
order: 'ASC' | 'DESC';
117117
}

projects/table-builder/src/lib/table/services/sortable/sortable.service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { EventEmitter, Injectable, NgZone } from '@angular/core';
22

33
import { TABLE_GLOBAL_OPTIONS } from '../../config/table-global-options';
44
import { OrderedField, TableRow } from '../../interfaces/table-builder.external';
5-
import { KeyMap, Resolver } from '../../interfaces/table-builder.internal';
5+
import { Any, KeyMap, Resolver } from '../../interfaces/table-builder.internal';
66
import { WebWorkerThreadService } from '../../worker/worker-thread.service';
77
import { sortWorker } from './sort.worker';
88
import { SortableMessage, SortOrderType } from './sortable.interfaces';
@@ -66,7 +66,7 @@ export class SortableService {
6666
Object.entries(this.definition).forEach(
6767
([key, ordered]: [string, SortOrderType], index: number): void => {
6868
this.positionMap[key] = index + 1;
69-
orderedFields.push({ field: key, order: ordered.toLocaleUpperCase() });
69+
orderedFields.push({ field: key, order: ordered.toLocaleUpperCase() as Any });
7070
}
7171
);
7272

yarn.lock

Lines changed: 11 additions & 95 deletions
Original file line numberDiff line numberDiff line change
@@ -1860,19 +1860,11 @@ app-root-path@^2.1.0, app-root-path@^2.2.1:
18601860
resolved "https://registry.npmjs.org/app-root-path/-/app-root-path-2.2.1.tgz#d0df4a682ee408273583d43f6f79e9892624bc9a"
18611861
integrity sha512-91IFKeKk7FjfmezPKkwtaRvSpnUc4gDwPAjA1YZ9Gn0q0PPeW+vbeUsZuyDwjI7+QTHhcLen2v25fi/AmhvbJA==
18621862

1863-
aproba@^1.0.3, aproba@^1.1.1:
1863+
aproba@^1.1.1:
18641864
version "1.2.0"
18651865
resolved "https://registry.npmjs.org/aproba/-/aproba-1.2.0.tgz#6802e6264efd18c790a1b0d517f0f2627bf2c94a"
18661866
integrity sha512-Y9J6ZjXtoYh8RnXVCMOU/ttDmk1aBjunq9vO0ta5x85WDQiQfUF9sIPBITdbiiIVcBo03Hi3jMxigBtsddlXRw==
18671867

1868-
are-we-there-yet@~1.1.2:
1869-
version "1.1.5"
1870-
resolved "https://registry.npmjs.org/are-we-there-yet/-/are-we-there-yet-1.1.5.tgz#4b35c2944f062a8bfcda66410760350fe9ddfc21"
1871-
integrity sha512-5hYdAkZlcG8tOLujVDTgCT+uPX0VnpAH28gWsLfzpXYm7wP6mp5Q/gYyR7YQ0cKVJcXJnl3j2kpBan13PtQf6w==
1872-
dependencies:
1873-
delegates "^1.0.0"
1874-
readable-stream "^2.0.6"
1875-
18761868
argparse@^1.0.7:
18771869
version "1.0.10"
18781870
resolved "https://registry.npmjs.org/argparse/-/argparse-1.0.10.tgz#bcd6791ea5ae09725e17e5ad988134cd40b3d911"
@@ -2908,11 +2900,6 @@ console-browserify@^1.1.0:
29082900
resolved "https://registry.npmjs.org/console-browserify/-/console-browserify-1.2.0.tgz#67063cef57ceb6cf4993a2ab3a55840ae8c49336"
29092901
integrity sha512-ZMkYO/LkF17QvCPqM0gxw8yUzigAOZOSWSHg91FH6orS7vcEj5dVZTidN2fQ14yBSdg97RqhSNwLUXInd52OTA==
29102902

2911-
console-control-strings@^1.0.0, console-control-strings@~1.1.0:
2912-
version "1.1.0"
2913-
resolved "https://registry.npmjs.org/console-control-strings/-/console-control-strings-1.1.0.tgz#3d7cf4464db6446ea644bf4b39507f9851008e8e"
2914-
integrity sha1-PXz0Rk22RG6mRL9LOVB/mFEAjo4=
2915-
29162903
constants-browserify@^1.0.0:
29172904
version "1.0.0"
29182905
resolved "https://registry.npmjs.org/constants-browserify/-/constants-browserify-1.0.0.tgz#c20b96d8c617748aaf1c16021760cd27fcb8cb75"
@@ -3210,7 +3197,7 @@ [email protected], debug@~3.1.0:
32103197
dependencies:
32113198
ms "2.0.0"
32123199

3213-
debug@^3.0.0, debug@^3.1.0, debug@^3.1.1, debug@^3.2.5, debug@^3.2.6:
3200+
debug@^3.0.0, debug@^3.1.0, debug@^3.1.1, debug@^3.2.5:
32143201
version "3.2.6"
32153202
resolved "https://registry.npmjs.org/debug/-/debug-3.2.6.tgz#e83d17de16d8a7efb7717edbe5fb10135eee629b"
32163203
integrity sha512-mel+jf7nrtEl5Pn1Qx46zARXKDpBbvzezse7p7LqINmdoIk8PYP5SySaxEmYv6TZ0JyEKA1hsCId6DIhgITtWQ==
@@ -3321,11 +3308,6 @@ delayed-stream@~1.0.0:
33213308
resolved "https://registry.npmjs.org/delayed-stream/-/delayed-stream-1.0.0.tgz#df3ae199acadfb7d440aaae0b29e2272b24ec619"
33223309
integrity sha1-3zrhmayt+31ECqrgsp4icrJOxhk=
33233310

3324-
delegates@^1.0.0:
3325-
version "1.0.0"
3326-
resolved "https://registry.npmjs.org/delegates/-/delegates-1.0.0.tgz#84c6e159b81904fdca59a0ef44cd870d31250f9a"
3327-
integrity sha1-hMbhWbgZBP3KWaDvRM2HDTElD5o=
3328-
33293311
depd@~1.1.2:
33303312
version "1.1.2"
33313313
resolved "https://registry.npmjs.org/depd/-/depd-1.1.2.tgz#9bcd52e14c097763e749b274c4346ed2e560b5a9"
@@ -3354,11 +3336,6 @@ detect-indent@^6.0.0:
33543336
resolved "https://registry.npmjs.org/detect-indent/-/detect-indent-6.0.0.tgz#0abd0f549f69fc6659a254fe96786186b6f528fd"
33553337
integrity sha512-oSyFlqaTHCItVRGK5RmrmjB+CmaMOW7IaNA/kdxqhoa6d17j/5ce9O9eWXmV/KEdRwqpQA+Vqe8a8Bsybu4YnA==
33563338

3357-
detect-libc@^1.0.2:
3358-
version "1.0.3"
3359-
resolved "https://registry.npmjs.org/detect-libc/-/detect-libc-1.0.3.tgz#fa137c4bd698edf55cd5cd02ac559f91a4c4ba9b"
3360-
integrity sha1-+hN8S9aY7fVc1c0CrFWfkaTEups=
3361-
33623339
33633340
version "3.1.0"
33643341
resolved "https://registry.npmjs.org/detect-newline/-/detect-newline-3.1.0.tgz#576f5dfc63ae1a192ff192d8ad3af6308991b651"
@@ -4395,20 +4372,6 @@ functional-red-black-tree@^1.0.1:
43954372
resolved "https://registry.npmjs.org/functional-red-black-tree/-/functional-red-black-tree-1.0.1.tgz#1b0ab3bd553b2a0d6399d29c0e3ea0b252078327"
43964373
integrity sha1-GwqzvVU7Kg1jmdKcDj6gslIHgyc=
43974374

4398-
gauge@~2.7.3:
4399-
version "2.7.4"
4400-
resolved "https://registry.npmjs.org/gauge/-/gauge-2.7.4.tgz#2c03405c7538c39d7eb37b317022e325fb018bf7"
4401-
integrity sha1-LANAXHU4w51+s3sxcCLjJfsBi/c=
4402-
dependencies:
4403-
aproba "^1.0.3"
4404-
console-control-strings "^1.0.0"
4405-
has-unicode "^2.0.0"
4406-
object-assign "^4.1.0"
4407-
signal-exit "^3.0.0"
4408-
string-width "^1.0.1"
4409-
strip-ansi "^3.0.1"
4410-
wide-align "^1.1.0"
4411-
44124375
genfun@^5.0.0:
44134376
version "5.0.0"
44144377
resolved "https://registry.npmjs.org/genfun/-/genfun-5.0.0.tgz#9dd9710a06900a5c4a5bf57aca5da4e52fe76537"
@@ -4637,11 +4600,6 @@ has-symbols@^1.0.0, has-symbols@^1.0.1:
46374600
resolved "https://registry.npmjs.org/has-symbols/-/has-symbols-1.0.1.tgz#9f5214758a44196c406d9bd76cebf81ec2dd31e8"
46384601
integrity sha512-PLcsoqu++dmEIZB+6totNFKq/7Do+Z0u4oT0zKOJNl3lYK6vGwwu2hjHs+68OEZbTjiUE9bgOABXbP/GvrS0Kg==
46394602

4640-
has-unicode@^2.0.0:
4641-
version "2.0.1"
4642-
resolved "https://registry.npmjs.org/has-unicode/-/has-unicode-2.0.1.tgz#e0e6fe6a28cf51138855e086d1691e771de2a8b9"
4643-
integrity sha1-4Ob+aijPUROIVeCG0Wkedx3iqLk=
4644-
46454603
has-value@^0.3.1:
46464604
version "0.3.1"
46474605
resolved "https://registry.npmjs.org/has-value/-/has-value-0.3.1.tgz#7b1f58bada62ca827ec0a2078025654845995e1f"
@@ -4867,7 +4825,7 @@ [email protected]:
48674825
run-node "^1.0.0"
48684826
slash "^3.0.0"
48694827

4870-
[email protected], iconv-lite@^0.4.24, iconv-lite@^0.4.4, iconv-lite@~0.4.13:
4828+
[email protected], iconv-lite@^0.4.24, iconv-lite@~0.4.13:
48714829
version "0.4.24"
48724830
resolved "https://registry.npmjs.org/iconv-lite/-/iconv-lite-0.4.24.tgz#2022b4b25fbddc21d2f524974a474aafe733908b"
48734831
integrity sha512-v3MXnZAcvnywkTUEZomIActle7RXXeedOR31wwl7VlyoXO4Qi9arvSenNQWne1TcRwhCL1HwLI21bEqdpj8/rA==
@@ -6681,15 +6639,6 @@ natural-compare@^1.4.0:
66816639
resolved "https://registry.npmjs.org/natural-compare/-/natural-compare-1.4.0.tgz#4abebfeed7541f2c27acfb29bdbbd15c8d5ba4f7"
66826640
integrity sha1-Sr6/7tdUHywnrPspvbvRXI1bpPc=
66836641

6684-
needle@^2.2.1:
6685-
version "2.3.3"
6686-
resolved "https://registry.npmjs.org/needle/-/needle-2.3.3.tgz#a041ad1d04a871b0ebb666f40baaf1fb47867117"
6687-
integrity sha512-EkY0GeSq87rWp1hoq/sH/wnTWgFVhYlnIkbJ0YJFfRgEFlz2RraCjBpFQ+vrEgEdp0ThfyHADmkChEhcb7PKyw==
6688-
dependencies:
6689-
debug "^3.2.6"
6690-
iconv-lite "^0.4.4"
6691-
sax "^1.2.4"
6692-
66936642
66946643
version "0.6.2"
66956644
resolved "https://registry.npmjs.org/negotiator/-/negotiator-0.6.2.tgz#feacf7ccf525a77ae9634436a64883ffeca346fb"
@@ -6813,22 +6762,6 @@ node-notifier@^5.4.2:
68136762
shellwords "^0.1.1"
68146763
which "^1.3.0"
68156764

6816-
node-pre-gyp@*:
6817-
version "0.14.0"
6818-
resolved "https://registry.npmjs.org/node-pre-gyp/-/node-pre-gyp-0.14.0.tgz#9a0596533b877289bcad4e143982ca3d904ddc83"
6819-
integrity sha512-+CvDC7ZttU/sSt9rFjix/P05iS43qHCOOGzcr3Ry99bXG7VX953+vFyEuph/tfqoYu8dttBkE86JSKBO2OzcxA==
6820-
dependencies:
6821-
detect-libc "^1.0.2"
6822-
mkdirp "^0.5.1"
6823-
needle "^2.2.1"
6824-
nopt "^4.0.1"
6825-
npm-packlist "^1.1.6"
6826-
npmlog "^4.0.2"
6827-
rc "^1.2.7"
6828-
rimraf "^2.6.1"
6829-
semver "^5.3.0"
6830-
tar "^4.4.2"
6831-
68326765
node-releases@^1.1.47, node-releases@^1.1.50:
68336766
version "1.1.51"
68346767
resolved "https://registry.npmjs.org/node-releases/-/node-releases-1.1.51.tgz#70d0e054221343d2966006bfbd4d98622cc00bd0"
@@ -6843,7 +6776,7 @@ node-sass-tilde-importer@^1.0.0:
68436776
dependencies:
68446777
find-parent-dir "^0.3.0"
68456778

6846-
nopt@^4.0.1, nopt@~4.0.1:
6779+
nopt@~4.0.1:
68476780
version "4.0.3"
68486781
resolved "https://registry.npmjs.org/nopt/-/nopt-4.0.3.tgz#a375cad9d02fd921278d954c2254d5aa57e15e48"
68496782
integrity sha512-CvaGwVMztSMJLOeXPrez7fyfObdZqNUK1cPAEzLHrTybIua9pMdmmPR5YwtfNftIOMv3DPUhFaxsZMNTQO20Kg==
@@ -6925,7 +6858,7 @@ npm-package-arg@^6.0.0, npm-package-arg@^6.1.0:
69256858
semver "^5.6.0"
69266859
validate-npm-package-name "^3.0.0"
69276860

6928-
npm-packlist@^1.1.12, npm-packlist@^1.1.6:
6861+
npm-packlist@^1.1.12:
69296862
version "1.4.8"
69306863
resolved "https://registry.npmjs.org/npm-packlist/-/npm-packlist-1.4.8.tgz#56ee6cc135b9f98ad3d51c1c95da22bbb9b2ef3e"
69316864
integrity sha512-5+AZgwru5IevF5ZdnFglB5wNlHG1AOOuw28WhUq8/8emhBmLv6jX5by4WJCh7lW0uSYZYS6DXqIsyZVIXRZU9A==
@@ -6972,16 +6905,6 @@ npm-run-path@^2.0.0:
69726905
dependencies:
69736906
path-key "^2.0.0"
69746907

6975-
npmlog@^4.0.2:
6976-
version "4.1.2"
6977-
resolved "https://registry.npmjs.org/npmlog/-/npmlog-4.1.2.tgz#08a7f2a8bf734604779a9efa4ad5cc717abb954b"
6978-
integrity sha512-2uUqazuKlTaSI/dC8AzicUck7+IrEaOnN/e0jd3Xtt1KcGpwx30v50mL7oPyr/h9bL3E4aZccVwpwP+5W9Vjkg==
6979-
dependencies:
6980-
are-we-there-yet "~1.1.2"
6981-
console-control-strings "~1.1.0"
6982-
gauge "~2.7.3"
6983-
set-blocking "~2.0.0"
6984-
69856908
num2fraction@^1.2.2:
69866909
version "1.2.2"
69876910
resolved "https://registry.npmjs.org/num2fraction/-/num2fraction-1.2.2.tgz#6f682b6a027a4e9ddfa4564cd2589d1d4e669ede"
@@ -7892,7 +7815,7 @@ [email protected]:
78927815
loader-utils "^1.1.0"
78937816
schema-utils "^2.0.1"
78947817

7895-
rc@^1.2.7, rc@^1.2.8:
7818+
rc@^1.2.8:
78967819
version "1.2.8"
78977820
resolved "https://registry.npmjs.org/rc/-/rc-1.2.8.tgz#cd924bf5200a075b83c188cd6b9e211b7fc0d3ed"
78987821
integrity sha512-y3bGgqKj3QBdxLbLkomlohkvsA8gdAiUQlSBJnBhfn+BPxg4bc62d8TcBW15wavDfgexCgccckhcZvywyQYPOw==
@@ -7987,7 +7910,7 @@ read-pkg@^5.0.0, read-pkg@^5.1.1:
79877910
parse-json "^5.0.0"
79887911
type-fest "^0.6.0"
79897912

7990-
"readable-stream@1 || 2", readable-stream@^2.0.0, readable-stream@^2.0.1, readable-stream@^2.0.2, readable-stream@^2.0.6, readable-stream@^2.1.5, readable-stream@^2.2.2, readable-stream@^2.3.3, readable-stream@^2.3.6, readable-stream@~2.3.6:
7913+
"readable-stream@1 || 2", readable-stream@^2.0.0, readable-stream@^2.0.1, readable-stream@^2.0.2, readable-stream@^2.1.5, readable-stream@^2.2.2, readable-stream@^2.3.3, readable-stream@^2.3.6, readable-stream@~2.3.6:
79917914
version "2.3.7"
79927915
resolved "https://registry.npmjs.org/readable-stream/-/readable-stream-2.3.7.tgz#1eca1cf711aef814c04f62252a36a62f6cb23b57"
79937916
integrity sha512-Ebho8K4jIbHAxnuxi7o42OrZgF/ZTNcsZj6nRKyUmkhLFq8CHItp/fy6hQZuZmP/n3yZ9VBUbp4zz/mX8hmYPw==
@@ -8301,7 +8224,7 @@ [email protected]:
83018224
dependencies:
83028225
glob "^7.1.3"
83038226

8304-
rimraf@^2.5.4, rimraf@^2.6.1, rimraf@^2.6.2, rimraf@^2.6.3:
8227+
rimraf@^2.5.4, rimraf@^2.6.2, rimraf@^2.6.3:
83058228
version "2.7.1"
83068229
resolved "https://registry.npmjs.org/rimraf/-/rimraf-2.7.1.tgz#35797f13a7fdadc566142c29d4f07ccad483e3ec"
83078230
integrity sha512-uWjbaKIK3T1OSVptzX7Nl6PvQ3qAGtKEtVRjRuazjfL3Bx5eI409VZSqgND+4UNnmzLVdPj9FqFJNPqBZFve4w==
@@ -8586,7 +8509,7 @@ [email protected]:
85868509
parseurl "~1.3.3"
85878510
send "0.17.1"
85888511

8589-
set-blocking@^2.0.0, set-blocking@~2.0.0:
8512+
set-blocking@^2.0.0:
85908513
version "2.0.0"
85918514
resolved "https://registry.npmjs.org/set-blocking/-/set-blocking-2.0.0.tgz#045f9782d011ae9a6803ddd382b24392b3d890f7"
85928515
integrity sha1-BF+XgtARrppoA93TgrJDkrPYkPc=
@@ -9038,7 +8961,7 @@ string-width@^1.0.1:
90388961
is-fullwidth-code-point "^1.0.0"
90398962
strip-ansi "^3.0.0"
90408963

9041-
"string-width@^1.0.2 || 2", string-width@^2.0.0, string-width@^2.1.1:
8964+
string-width@^2.0.0, string-width@^2.1.1:
90428965
version "2.1.1"
90438966
resolved "https://registry.npmjs.org/string-width/-/string-width-2.1.1.tgz#ab93f27a8dc13d28cac815c462143a6d9012ae9e"
90448967
integrity sha512-nOqH59deCq9SRHlxq1Aw85Jnt4w6KvLKqWVik6oA9ZklXLNIOlqg4F2yrT1MVaTjAqvVwdfeZ7w7aCvJD7ugkw==
@@ -9231,7 +9154,7 @@ tapable@^1.0.0, tapable@^1.1.3:
92319154
resolved "https://registry.npmjs.org/tapable/-/tapable-1.1.3.tgz#a1fccc06b58db61fd7a45da2da44f5f3a3e67ba2"
92329155
integrity sha512-4WK/bYZmj8xLr+HUCODHGF1ZFzsYffasLUgEiMBY4fgtltdO6B4WJtlSbPaDTLpYTcGVwM2qLnFTICEcNxs3kA==
92339156

9234-
tar@^4.4.2, tar@^4.4.8:
9157+
tar@^4.4.8:
92359158
version "4.4.13"
92369159
resolved "https://registry.npmjs.org/tar/-/tar-4.4.13.tgz#43b364bc52888d555298637b10d60790254ab525"
92379160
integrity sha512-w2VwSrBoHa5BsSyH+KxEqeQBAllHhccyMFVHtGtdMpF4W7IRWfZjFiQceJPChOeTsSDVUpER2T8FA93pr0L+QA==
@@ -10045,13 +9968,6 @@ which@^1.2.9, which@^1.3.0, which@^1.3.1:
100459968
dependencies:
100469969
isexe "^2.0.0"
100479970

10048-
wide-align@^1.1.0:
10049-
version "1.1.3"
10050-
resolved "https://registry.npmjs.org/wide-align/-/wide-align-1.1.3.tgz#ae074e6bdc0c14a431e804e624549c633b000457"
10051-
integrity sha512-QGkOQc8XL6Bt5PwnsExKBPuMKBxnGxWWW3fU55Xt4feHozMUhdUMaBCk290qpm/wG5u/RSKzwdAC4i51YigihA==
10052-
dependencies:
10053-
string-width "^1.0.2 || 2"
10054-
100559971
widest-line@^3.1.0:
100569972
version "3.1.0"
100579973
resolved "https://registry.npmjs.org/widest-line/-/widest-line-3.1.0.tgz#8292333bbf66cb45ff0de1603b136b7ae1496eca"

0 commit comments

Comments
 (0)