Fix uninitialized memory read

Author: kintel

CPP/CMakeLists.txt

@@ -80,7 +80,7 @@ if (NOT (CLIPPER2_USINGZ STREQUAL "ONLY"))
   if (MSVC)
     target_compile_options(Clipper2 PRIVATE /W4 /WX)
   else()
-    target_compile_options(Clipper2 PRIVATE -Wall -Wextra -Wpedantic -Werror)
+    target_compile_options(Clipper2 PRIVATE -Wall -Wextra -Wpedantic -Werror -Werror=uninitialized)
     target_link_libraries(Clipper2 PUBLIC -lm)
   endif()
 endif()
@@ -105,7 +105,7 @@ if (NOT (CLIPPER2_USINGZ STREQUAL "OFF"))
   if (MSVC)
     target_compile_options(Clipper2Z PRIVATE /W4 /WX)
   else()
-    target_compile_options(Clipper2Z PRIVATE -Wall -Wextra -Wpedantic -Werror)
+    target_compile_options(Clipper2Z PRIVATE -Wall -Wextra -Wpedantic -Werror -Werror=uninitialized)
     target_link_libraries(Clipper2Z PUBLIC -lm)
   endif()
 endif()

CPP/Clipper2Lib/src/clipper.triangulation.cpp

@@ -1202,7 +1202,7 @@ namespace Clipper2Lib
 
   TriangulateResult Triangulate(const PathsD& pp, int decPlaces, PathsD& solution, bool useDelaunay)
   {
-    int ec;
+    int ec = 0;
     double scale;
     TriangulateResult result;
     if (decPlaces <= 0) scale = 1;

CPP/Examples/Inflate/Inflate.cpp

@@ -86,7 +86,7 @@ static void DoSimpleShapes()
   // POLYGON JOINTYPES SVG:
 
   // 1. triangle offset - with large miter
-  int err, scale = 100;
+  int err = 0, scale = 100;
   PathsD p, solution;
   p.push_back(MakePathD({ 30,150, 60,350, 0,350 }));
   solution.insert(solution.end(), p.begin(), p.end());

CPP/Tests/TestOffsets.cpp

@@ -46,7 +46,7 @@ TEST(Clipper2Tests, TestOffsets2) { // see #448 & #456
   Paths64 subject, solution;
   ClipperOffset c;
   subject.push_back(MakePath({ 50,50, 100,50, 100,150, 50,150, 0,100 }));
-  int err;
+  int err = 0;
   subject = ScalePaths<int64_t, int64_t>(subject, scale, err);
   c.AddPaths(subject, JoinType::Round, EndType::Polygon);
   c.ArcTolerance(arc_tol);