🐛 Update group deselection logic for Blockbench 4.12.0

Author: SnaveSutit

src/blockbench-additions/outliner-elements/blockDisplay.ts

@@ -154,9 +154,8 @@ export class BlockDisplay extends ResizableOutlinerElement {
 	}
 
 	select() {
-		if (Group.first_selected) {
-			Group.first_selected.unselect()
-		}
+		Group.all.forEachReverse(el => el.unselect())
+
 		if (!Pressing.ctrl && !Pressing.shift) {
 			if (Cube.selected.length) {
 				Cube.selected.forEachReverse(el => el.unselect())
@@ -437,7 +436,7 @@ export const CREATE_ACTION = createAction(`${PACKAGE.name}:create_block_display`
 		}
 
 		selected.forEachReverse(el => el.unselect())
-		Group.first_selected && Group.first_selected.unselect()
+		Group.all.forEachReverse(el => el.unselect())
 		vanillaBlockDisplay.select()
 
 		Undo.finishEdit('Create Vanilla Block Display', {

src/blockbench-additions/outliner-elements/itemDisplay.ts

@@ -151,9 +151,8 @@ export class ItemDisplay extends ResizableOutlinerElement {
 	}
 
 	select() {
-		if (Group.first_selected) {
-			Group.first_selected.unselect()
-		}
+		Group.all.forEachReverse(el => el.unselect())
+
 		if (!Pressing.ctrl && !Pressing.shift) {
 			if (Cube.selected.length) {
 				Cube.selected.forEachReverse(el => el.unselect())
@@ -425,7 +424,7 @@ export const CREATE_ACTION = createAction(`${PACKAGE.name}:create_item_display`,
 		}
 
 		selected.forEachReverse(el => el.unselect())
-		Group.first_selected && Group.first_selected.unselect()
+		Group.all.forEachReverse(el => el.unselect())
 		vanillaItemDisplay.select()
 
 		Undo.finishEdit('Create Vanilla Item Display', {

src/blockbench-additions/outliner-elements/textDisplay.ts

@@ -209,9 +209,7 @@ export class TextDisplay extends ResizableOutlinerElement {
 	}
 
 	select() {
-		if (Group.first_selected) {
-			Group.first_selected.unselect()
-		}
+		Group.all.forEachReverse(el => el.unselect())
 
 		if (!Pressing.ctrl && !Pressing.shift) {
 			if (Cube.selected.length) {
@@ -544,13 +542,13 @@ export const CREATE_ACTION = createAction(`${PACKAGE.name}:create_text_display`,
 			textDisplay.extend({ position: group.origin.slice() as ArrayVector3 })
 		}
 
-		textDisplay.forEachReverse(el => el.unselect())
-		Group.first_selected && Group.first_selected.unselect()
+		selected.forEachReverse(el => el.unselect())
+		Group.all.forEachReverse(el => el.unselect())
 		textDisplay.select()
 
 		Undo.finishEdit('Create Text Display', {
 			outliner: true,
-			elements: textDisplay,
+			elements: selected,
 			selection: true,
 		})