Skip to content

Commit 5125830

Browse files
committed
🛠️ Fix Display Entity Muli-Select Issues.
1 parent 2e42e36 commit 5125830

File tree

2 files changed

+20
-14
lines changed

2 files changed

+20
-14
lines changed

src/components/vanillaBlockDisplayElementPanel.svelte

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,30 +6,33 @@
66
</script>
77

88
<script lang="ts">
9-
let selected = VanillaBlockDisplay.selected.at(0)
9+
let selectedDisplay = VanillaBlockDisplay.selected.at(0)
1010
1111
let block = new Valuable<string>('')
1212
let error = new Valuable<string>('')
13+
let visible = false
1314
1415
events.UPDATE_SELECTION.subscribe(() => {
15-
selected = VanillaBlockDisplay.selected.at(0)
16-
if (!selected) {
16+
selectedDisplay = VanillaBlockDisplay.selected.at(0)
17+
if (!selectedDisplay || selected.length > 1) {
1718
block = new Valuable('')
1819
error = new Valuable('')
20+
visible = false
1921
return
2022
}
21-
block = selected._block
22-
error = selected.error
23+
block = selectedDisplay._block
24+
error = selectedDisplay.error
25+
visible = true
2326
})
2427
</script>
2528

26-
<p class="panel_toolbar_label label" style={!!selected ? '' : 'visibility:hidden; height: 0px;'}>
29+
<p class="panel_toolbar_label label" style={!!visible ? '' : 'visibility:hidden; height: 0px;'}>
2730
{translate('panel.vanilla_block_display.title')}
2831
</p>
2932

3033
<div
3134
class="toolbar custom-toolbar"
32-
style={!!selected ? '' : 'visibility:hidden; height: 0px;'}
35+
style={!!visible ? '' : 'visibility:hidden; height: 0px;'}
3336
title={translate('panel.vanilla_block_display.description')}
3437
>
3538
<div class="content" style="width: 95%;">

src/components/vanillaItemDisplayElementPanel.svelte

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,30 +6,33 @@
66
</script>
77

88
<script lang="ts">
9-
let selected = VanillaItemDisplay.selected.at(0)
9+
let selectedDisplay = VanillaItemDisplay.selected.at(0)
1010
1111
let item = new Valuable<string>('')
1212
let error = new Valuable<string>('')
13+
let visible = false
1314
1415
events.UPDATE_SELECTION.subscribe(() => {
15-
selected = VanillaItemDisplay.selected.at(0)
16-
if (!selected) {
16+
selectedDisplay = VanillaItemDisplay.selected.at(0)
17+
if (!selectedDisplay || selected.length > 1) {
1718
item = new Valuable('')
1819
error = new Valuable('')
20+
visible = false
1921
return
2022
}
21-
item = selected._item
22-
error = selected.error
23+
item = selectedDisplay._item
24+
error = selectedDisplay.error
25+
visible = true
2326
})
2427
</script>
2528

26-
<p class="panel_toolbar_label label" style={!!selected ? '' : 'visibility:hidden; height: 0px;'}>
29+
<p class="panel_toolbar_label label" style={!!visible ? '' : 'visibility:hidden; height: 0px;'}>
2730
{translate('panel.vanilla_item_display.title')}
2831
</p>
2932

3033
<div
3134
class="toolbar custom-toolbar"
32-
style={!!selected ? '' : 'visibility:hidden; height: 0px;'}
35+
style={!!visible ? '' : 'visibility:hidden; height: 0px;'}
3336
title={translate('panel.vanilla_item_display.description')}
3437
>
3538
<div class="content" style="width: 95%;">

0 commit comments

Comments
 (0)