Skip to content

Commit 9c7aafb

Browse files
committed
fix settings ui issues
1 parent 7fd94b4 commit 9c7aafb

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

src/ui/dialogs/settings.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -224,13 +224,18 @@ export function registerSettingRenderer(type, renderer) {
224224
RenderTemplates[type] = renderer(React)
225225
}
226226
}
227-
const SettingInput = ({ namespace, name, template }) => {
227+
const SettingInput = (p) => {
228+
const { namespace, name, template } = p
228229
const [value, setValue] = useState(settings[namespace][name])
229230
const [isValid, setIsValid] = useState(true)
230231
const [isVisible, setIsVisible] = useState(true)
231232
const [rerender, setRerender] = useState(0)
232-
updateSettingsUiActions[`${namespace}.${name}`] = () =>
233-
setRerender(Math.random())
233+
useEffect(() => {
234+
updateSettingsUiActions[`${namespace}.${name}`] = () =>
235+
setRerender(Math.random())
236+
return () =>
237+
(updateSettingsUiActions[`${namespace}.${name}`] = () => {})
238+
}, [])
234239
useEffect(() => {
235240
// setValue(settings[namespace][name])
236241
return settings.watch(namespace + '.' + name, (v) => {

0 commit comments

Comments
 (0)