Skip to content

Commit 51983c2

Browse files
committed
Fix variable naming conflicts causing changed test behavior
1 parent 9627329 commit 51983c2

File tree

1 file changed

+31
-15
lines changed

1 file changed

+31
-15
lines changed

nbs/02_shell.ipynb

Lines changed: 31 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -779,8 +779,8 @@
779779
"text/plain": [
780780
"[{'name': 'stdout',\n",
781781
" 'output_type': 'stream',\n",
782-
" 'text': ['CPU times: user 1e+03 ns, sys: 0 ns, total: 1e+03 ns\\n',\n",
783-
" 'Wall time: 2.15 us\\n']},\n",
782+
" 'text': ['CPU times: user 2 us, sys: 0 ns, total: 2 us\\n',\n",
783+
" 'Wall time: 1.91 us\\n']},\n",
784784
" {'data': {'text/plain': ['2']},\n",
785785
" 'metadata': {},\n",
786786
" 'output_type': 'execute_result',\n",
@@ -998,8 +998,8 @@
998998
}
999999
],
10001000
"source": [
1001-
"o = s.run('from IPython.display import Markdown,display; print(0); print(1); display(Markdown(\"*2*\")); Markdown(\"*1*\")')\n",
1002-
"o"
1001+
"o1 = s.run('from IPython.display import Markdown,display; print(0); print(1); display(Markdown(\"*2*\")); Markdown(\"*1*\")')\n",
1002+
"o1"
10031003
]
10041004
},
10051005
{
@@ -1091,12 +1091,20 @@
10911091
{
10921092
"data": {
10931093
"text/html": [
1094-
"<pre ><code class=''>0\n",
1095-
"1\n",
1096-
"</code></pre>\n",
1097-
"<p><em>2</em></p>\n",
1094+
"<pre ><code class=''>---------------------------------------------------------------------------\n",
1095+
"TimeoutError Traceback (most recent call last)\n",
1096+
"File &lt;ipython-input-1-a5c3817716b6&gt;:1\n",
1097+
"----&gt; 1 import time; time.sleep(1.1)\n",
1098+
"\n",
1099+
"Cell In[6], line 7, in run_cell.&lt;locals&gt;.handler(*args)\n",
1100+
" 5 if not timeout: timeout = self.timeout\n",
1101+
" 6 if timeout:\n",
1102+
"----&gt; 7 def handler(*args): raise TimeoutError()\n",
1103+
" 8 signal.signal(signal.SIGALRM, handler)\n",
1104+
" 9 signal.alarm(timeout)\n",
10981105
"\n",
1099-
"<p><em>1</em></p>\n"
1106+
"TimeoutError: \n",
1107+
"</code></pre>\n"
11001108
],
11011109
"text/plain": [
11021110
"<IPython.core.display.HTML object>"
@@ -1126,12 +1134,20 @@
11261134
{
11271135
"data": {
11281136
"text/html": [
1129-
"<pre ><code class=''>0\n",
1130-
"1\n",
1131-
"</code></pre>\n",
1132-
"<p><em>2</em></p>\n",
1137+
"<pre ><code class='nohighlight hljs'><span class=\"ansi-red-fg\">---------------------------------------------------------------------------</span>\n",
1138+
"<span class=\"ansi-red-fg\">TimeoutError</span> Traceback (most recent call last)\n",
1139+
"<span class=\"ansi-cyan-fg\">File </span><span class=\"ansi-green-fg\">&lt;ipython-input-1-a5c3817716b6&gt;:1</span>\n",
1140+
"<span class=\"ansi-green-fg\">----&gt; </span><span class=\"ansi-green-fg\">1</span> <span class=\"ansi-bold\" style=\"color: rgb(0,135,0)\">import</span><span style=\"color: rgb(188,188,188)\"> </span><span class=\"ansi-blue-intense-fg ansi-bold\">time</span>; time.sleep(<span class=\"ansi-green-fg\">1.1</span>)\n",
1141+
"\n",
1142+
"<span class=\"ansi-cyan-fg\">Cell</span><span class=\"ansi-cyan-fg\"> </span><span class=\"ansi-green-fg\">In[6]</span><span class=\"ansi-green-fg\">, line 7</span>, in <span class=\"ansi-cyan-fg\">run_cell.&lt;locals&gt;.handler</span><span class=\"ansi-blue-fg\">(*args)</span>\n",
1143+
"<span class=\"ansi-green-fg\"> 5</span> <span class=\"ansi-bold\" style=\"color: rgb(0,135,0)\">if</span> <span class=\"ansi-bold\" style=\"color: rgb(175,0,255)\">not</span> timeout: timeout = <span style=\"color: rgb(0,135,0)\">self</span>.timeout\n",
1144+
"<span class=\"ansi-green-fg\"> 6</span> <span class=\"ansi-bold\" style=\"color: rgb(0,135,0)\">if</span> timeout:\n",
1145+
"<span class=\"ansi-green-fg\">----&gt; </span><span class=\"ansi-green-fg\">7</span> <span class=\"ansi-bold\" style=\"color: rgb(0,135,0)\">def</span><span style=\"color: rgb(188,188,188)\"> </span><span class=\"ansi-blue-fg\">handler</span>(*args): <span class=\"ansi-bold\" style=\"color: rgb(0,135,0)\">raise</span> <span class=\"ansi-bold\" style=\"color: rgb(215,95,95)\">TimeoutError</span>()\n",
1146+
"<span class=\"ansi-green-fg\"> 8</span> signal.signal(signal.SIGALRM, handler)\n",
1147+
"<span class=\"ansi-green-fg\"> 9</span> signal.alarm(timeout)\n",
11331148
"\n",
1134-
"<p><em>1</em></p>\n"
1149+
"<span class=\"ansi-red-fg\">TimeoutError</span>: \n",
1150+
"</code></pre>\n"
11351151
],
11361152
"text/plain": [
11371153
"<IPython.core.display.HTML object>"
@@ -1806,7 +1822,7 @@
18061822
"===========================================================================\n",
18071823
"\n",
18081824
"While Executing Cell #2:\n",
1809-
"['Traceback (most recent call last):\\n', ' File \"/var/folders/_8/cpj54rdn0w1fjskv7g8bn2fr0000gn/T/ipykernel_96814/1421292703.py\", line 3, in <module>\\n s.execute(\\'../tests/error.ipynb\\', exc_stop=True)\\n', ' File \"/var/folders/_8/cpj54rdn0w1fjskv7g8bn2fr0000gn/T/ipykernel_96814/3609882568.py\", line 18, in execute\\n self.run_all(nb, exc_stop=exc_stop, preproc=preproc, postproc=postproc,\\n', ' File \"/var/folders/_8/cpj54rdn0w1fjskv7g8bn2fr0000gn/T/ipykernel_96814/3068237356.py\", line 19, in run_all\\n if self.exc and exc_stop: raise self.exc from None\\n ^^^^^^^^^^^^^^^^^^^^^^^^\\n', ' File \"/Users/iflath/.venv/lib/python3.12/site-packages/IPython/core/interactiveshell.py\", line 3546, in run_code\\n exec(code_obj, self.user_global_ns, self.user_ns)\\n', ' File \"<ipython-input-1-b968a57a586e>\", line 3, in <module>\\n foo()\\n', ' File \"/Users/iflath/git/fastai/execnb/tests/err.py\", line 2, in foo\\n assert 13 == 98\\n ^^^^^^^^\\n', 'AssertionError\\n']\n",
1825+
"['Traceback (most recent call last):\\n', ' File \"/var/folders/_8/cpj54rdn0w1fjskv7g8bn2fr0000gn/T/ipykernel_97767/1421292703.py\", line 3, in <module>\\n s.execute(\\'../tests/error.ipynb\\', exc_stop=True)\\n', ' File \"/var/folders/_8/cpj54rdn0w1fjskv7g8bn2fr0000gn/T/ipykernel_97767/3609882568.py\", line 18, in execute\\n self.run_all(nb, exc_stop=exc_stop, preproc=preproc, postproc=postproc,\\n', ' File \"/var/folders/_8/cpj54rdn0w1fjskv7g8bn2fr0000gn/T/ipykernel_97767/3068237356.py\", line 19, in run_all\\n if self.exc and exc_stop: raise self.exc from None\\n ^^^^^^^^^^^^^^^^^^^^^^^^\\n', ' File \"/Users/iflath/.venv/lib/python3.12/site-packages/IPython/core/interactiveshell.py\", line 3546, in run_code\\n exec(code_obj, self.user_global_ns, self.user_ns)\\n', ' File \"<ipython-input-1-b968a57a586e>\", line 3, in <module>\\n foo()\\n', ' File \"/Users/iflath/git/fastai/execnb/tests/err.py\", line 2, in foo\\n assert 13 == 98\\n ^^^^^^^^\\n', 'AssertionError\\n']\n",
18101826
"\n"
18111827
]
18121828
}

0 commit comments

Comments
 (0)