Skip to content

Commit 969ec40

Browse files
committed
undo ft handling
1 parent 1aea3e3 commit 969ec40

File tree

2 files changed

+22
-18
lines changed

2 files changed

+22
-18
lines changed

execnb/shell.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,12 +129,10 @@ def _out_nb(o, fmt):
129129
if o.stdout: res.append(_out_stream(o.stdout, 'stdout'))
130130
if o.stderr: res.append(_out_stream(o.stderr, 'stderr'))
131131
if o.exception: res.append(_out_exc(o.exception))
132-
r = o.result.result
133-
if hasattr(r, '__ft__'): r = r.__ft__()
134-
res.result = r
132+
res.result = o.result.result
135133
for x in o.display_objects: res.append(_mk_out(x.data, x.metadata))
136-
if r is not None and not o.quiet and not isinstance_str(r, 'FT'):
137-
res.append(_mk_out(*fmt.format(r), 'execute_result'))
134+
if res.result is not None and not o.quiet:
135+
res.append(_mk_out(*fmt.format(res.result), 'execute_result'))
138136
if 'execution_count' not in o: o['execution_count']=None
139137
for p in res:
140138
if p["output_type"]=="execute_result": p['execution_count'] = o['execution_count']

nbs/02_shell.ipynb

Lines changed: 19 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -713,12 +713,10 @@
713713
" if o.stdout: res.append(_out_stream(o.stdout, 'stdout'))\n",
714714
" if o.stderr: res.append(_out_stream(o.stderr, 'stderr'))\n",
715715
" if o.exception: res.append(_out_exc(o.exception))\n",
716-
" r = o.result.result\n",
717-
" if hasattr(r, '__ft__'): r = r.__ft__()\n",
718-
" res.result = r\n",
716+
" res.result = o.result.result\n",
719717
" for x in o.display_objects: res.append(_mk_out(x.data, x.metadata))\n",
720-
" if r is not None and not o.quiet and not isinstance_str(r, 'FT'):\n",
721-
" res.append(_mk_out(*fmt.format(r), 'execute_result'))\n",
718+
" if res.result is not None and not o.quiet:\n",
719+
" res.append(_mk_out(*fmt.format(res.result), 'execute_result'))\n",
722720
" if 'execution_count' not in o: o['execution_count']=None\n",
723721
" for p in res:\n",
724722
" if p[\"output_type\"]==\"execute_result\": p['execution_count'] = o['execution_count']\n",
@@ -791,8 +789,8 @@
791789
"text/plain": [
792790
"[{'name': 'stdout',\n",
793791
" 'output_type': 'stream',\n",
794-
" 'text': ['CPU times: user 1 us, sys: 0 ns, total: 1 us\\n',\n",
795-
" 'Wall time: 3.1 us\\n']},\n",
792+
" 'text': ['CPU times: user 2 us, sys: 0 ns, total: 2 us\\n',\n",
793+
" 'Wall time: 1.91 us\\n']},\n",
796794
" {'data': {'text/plain': ['2']},\n",
797795
" 'metadata': {},\n",
798796
" 'output_type': 'execute_result',\n",
@@ -936,7 +934,7 @@
936934
"text": [
937935
"\u001b[91m---------------------------------------------------------------------------\u001b[39m\n",
938936
"\u001b[91mNameError\u001b[39m Traceback (most recent call last)\n",
939-
"\u001b[96mCell\u001b[39m\u001b[96m \u001b[39m\u001b[32mIn[34]\u001b[39m\u001b[32m, line 1\u001b[39m\n",
937+
"\u001b[96mCell\u001b[39m\u001b[96m \u001b[39m\u001b[32mIn[35]\u001b[39m\u001b[32m, line 1\u001b[39m\n",
940938
"\u001b[92m----> \u001b[39m\u001b[92m1\u001b[39m \u001b[38;5;81mtry\u001b[39m\u001b[38;5;15m:\u001b[39m\u001b[38;5;15m \u001b[39m\u001b[38;5;15mf\u001b[39m\u001b[38;5;15m(\u001b[39m\u001b[38;5;15m)\u001b[39m\n",
941939
"\u001b[92m 2\u001b[39m \u001b[38;5;81mexcept\u001b[39m\u001b[38;5;15m \u001b[39m\u001b[38;5;148mException\u001b[39m\u001b[38;5;15m \u001b[39m\u001b[38;5;81mas\u001b[39m\u001b[38;5;15m \u001b[39m\u001b[38;5;15me\u001b[39m\u001b[38;5;15m:\u001b[39m\n",
942940
"\u001b[92m 3\u001b[39m \u001b[38;5;15m \u001b[39m\u001b[38;5;15mex\u001b[39m\u001b[38;5;15m \u001b[39m\u001b[38;5;204m=\u001b[39m\u001b[38;5;15m \u001b[39m\u001b[38;5;15me\u001b[39m\n",
@@ -1119,7 +1117,11 @@
11191117
"----> 1 import time; time.sleep(1.1)\n",
11201118
"\n",
11211119
"Cell In[6], line 7, in run_cell.<locals>.handler(*args)\n",
1122-
"----> 7 def handler(*args): raise TimeoutError()\n",
1120+
" 5 if not timeout: timeout = self.timeout\n",
1121+
" 6 if timeout:\n",
1122+
"----> 7 def handler(*args): raise TimeoutError()\n",
1123+
" 8 signal.signal(signal.SIGALRM, handler)\n",
1124+
" 9 signal.alarm(timeout)\n",
11231125
"\n",
11241126
"TimeoutError: \n",
11251127
"</code></pre>\n"
@@ -1158,7 +1160,11 @@
11581160
"<span class=\"ansi-green-fg\">----&gt; </span><span class=\"ansi-green-fg\">1</span> <span class=\"ansi-bold\" style=\"color: rgb(0,135,0)\">import</span><span style=\"color: rgb(188,188,188)\"> </span><span class=\"ansi-blue-intense-fg ansi-bold\">time</span>; time.sleep(<span class=\"ansi-green-fg\">1.1</span>)\n",
11591161
"\n",
11601162
"<span class=\"ansi-cyan-fg\">Cell</span><span class=\"ansi-cyan-fg\"> </span><span class=\"ansi-green-fg\">In[6]</span><span class=\"ansi-green-fg\">, line 7</span>, in <span class=\"ansi-cyan-fg\">run_cell.&lt;locals&gt;.handler</span><span class=\"ansi-blue-fg\">(*args)</span>\n",
1161-
"<span class=\"ansi-green-fg\">----&gt; </span><span class=\"ansi-green-fg\">7</span> <span class=\"ansi-bold\" style=\"color: rgb(0,135,0)\">def</span><span style=\"color: rgb(188,188,188)\"> </span><span class=\"ansi-blue-fg\">handler</span>(*args): <span class=\"ansi-bold\" style=\"color: rgb(0,135,0)\">raise</span> <span class=\"ansi-bold\" style=\"color: rgb(215,95,95)\">TimeoutError</span>()\n",
1163+
"<span class=\"ansi-green-fg\"> 5</span> <span class=\"ansi-bold\" style=\"color: rgb(0,135,0)\">if</span> <span class=\"ansi-bold\" style=\"color: rgb(175,0,255)\">not</span> timeout: timeout = <span style=\"color: rgb(0,135,0)\">self</span>.timeout\n",
1164+
"<span class=\"ansi-green-fg\"> 6</span> <span class=\"ansi-bold\" style=\"color: rgb(0,135,0)\">if</span> timeout:\n",
1165+
"<span class=\"ansi-green-fg\">----&gt; </span><span class=\"ansi-green-fg\">7</span> <span class=\"ansi-bold\" style=\"color: rgb(0,135,0)\">def</span><span style=\"color: rgb(188,188,188)\"> </span><span class=\"ansi-blue-fg\">handler</span>(*args): <span class=\"ansi-bold\" style=\"color: rgb(0,135,0)\">raise</span> <span class=\"ansi-bold\" style=\"color: rgb(215,95,95)\">TimeoutError</span>()\n",
1166+
"<span class=\"ansi-green-fg\"> 8</span> signal.signal(signal.SIGALRM, handler)\n",
1167+
"<span class=\"ansi-green-fg\"> 9</span> signal.alarm(timeout)\n",
11621168
"\n",
11631169
"<span class=\"ansi-red-fg\">TimeoutError</span>: \n",
11641170
"</code></pre>\n"
@@ -1837,11 +1843,11 @@
18371843
"\n",
18381844
"While Executing Cell #2:\n",
18391845
"Traceback (most recent call last):\n",
1840-
" File \"/var/folders/ss/34z569j921v58v8n1n_8z7h40000gn/T/ipykernel_26206/1421292703.py\", line 3, in <module>\n",
1846+
" File \"/var/folders/ss/34z569j921v58v8n1n_8z7h40000gn/T/ipykernel_32164/1421292703.py\", line 3, in <module>\n",
18411847
" s.execute('../tests/error.ipynb', exc_stop=True)\n",
1842-
" File \"/var/folders/ss/34z569j921v58v8n1n_8z7h40000gn/T/ipykernel_26206/3609882568.py\", line 18, in execute\n",
1848+
" File \"/var/folders/ss/34z569j921v58v8n1n_8z7h40000gn/T/ipykernel_32164/3609882568.py\", line 18, in execute\n",
18431849
" self.run_all(nb, exc_stop=exc_stop, preproc=preproc, postproc=postproc,\n",
1844-
" File \"/var/folders/ss/34z569j921v58v8n1n_8z7h40000gn/T/ipykernel_26206/3068237356.py\", line 19, in run_all\n",
1850+
" File \"/var/folders/ss/34z569j921v58v8n1n_8z7h40000gn/T/ipykernel_32164/3068237356.py\", line 19, in run_all\n",
18451851
" if self.exc and exc_stop: raise self.exc from None\n",
18461852
" ^^^^^^^^^^^^^^^^^^^^^^^^\n",
18471853
" File \"/Users/jhoward/uvws/.venv/lib/python3.12/site-packages/IPython/core/interactiveshell.py\", line 3549, in run_code\n",

0 commit comments

Comments
 (0)