fixes #85

Author: jph00

fastcore/utils.py

@@ -98,10 +98,10 @@ def store_attr(names=None, self=None, but=None, **attrs):
     "Store params named in comma-separated `names` from calling context into attrs in `self`"
     fr = sys._getframe(1)
     args = fr.f_code.co_varnames[:fr.f_code.co_argcount]
-    if self is None: self = fr.f_locals[args[0]]
+    if self: args = ('self', *args)
+    else: self = fr.f_locals[args[0]]
     if not hasattr(self, '__stored_args__'): self.__stored_args__ = {}
     if attrs: return _store_attr(self, **attrs)
-
     ns = re.split(', *', names) if names else args[1:]
     _store_attr(self, **{n:fr.f_locals[n] for n in ns if n not in L(but)})
 

nbs/02_utils.ipynb

@@ -294,7 +294,7 @@
     {
      "data": {
       "text/plain": [
-       "<__main__._t at 0x7f79887ee6d0>"
+       "<__main__._t at 0x7fd7b4badb90>"
       ]
      },
      "execution_count": null,
@@ -507,10 +507,10 @@
     "    \"Store params named in comma-separated `names` from calling context into attrs in `self`\"\n",
     "    fr = sys._getframe(1)\n",
     "    args = fr.f_code.co_varnames[:fr.f_code.co_argcount]\n",
-    "    if self is None: self = fr.f_locals[args[0]]\n",
+    "    if self: args = ('self', *args)\n",
+    "    else: self = fr.f_locals[args[0]]\n",
     "    if not hasattr(self, '__stored_args__'): self.__stored_args__ = {}\n",
     "    if attrs: return _store_attr(self, **attrs)\n",
-    "    \n",
     "    ns = re.split(', *', names) if names else args[1:]\n",
     "    _store_attr(self, **{n:fr.f_locals[n] for n in ns if n not in L(but)})"
    ]
@@ -738,6 +738,28 @@
     "assert t.a==1"
    ]
   },
+  {
+   "cell_type": "markdown",
+   "metadata": {},
+   "source": [
+    "You can also use store_attr inside functions."
+   ]
+  },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "metadata": {},
+   "outputs": [],
+   "source": [
+    "def create_T(a, b):\n",
+    "    t = SimpleNamespace()\n",
+    "    store_attr(self=t)\n",
+    "    return t\n",
+    "\n",
+    "t = create_T(a=1, b=2)\n",
+    "assert t.a==1 and t.b==2"
+   ]
+  },
   {
    "cell_type": "code",
    "execution_count": null,