fixes #246

Author: jph00

fastcore/parallel.py

@@ -63,7 +63,7 @@ def __init__(self, max_workers=defaults.cpus, on_exc=print, pause=0, **kwargs):
         if self.not_parallel: max_workers=1
         super().__init__(max_workers, **kwargs)
 
-    def map(self, f, items, timeout=None, chunksize=1, *args, **kwargs):
+    def map(self, f, items, *args, timeout=None, chunksize=1, **kwargs):
         self.lock = Manager().Lock()
         g = partial(f, *args, **kwargs)
         if self.not_parallel: return map(g, items)
@@ -81,7 +81,7 @@ def __init__(self, max_workers=defaults.cpus, on_exc=print, pause=0, **kwargs):
         if self.not_parallel: max_workers=1
         super().__init__(max_workers, **kwargs)
 
-    def map(self, f, items, timeout=None, chunksize=1, *args, **kwargs):
+    def map(self, f, items, *args, timeout=None, chunksize=1, **kwargs):
         self.lock = Manager().Lock()
         g = partial(f, *args, **kwargs)
         if self.not_parallel: return map(g, items)

nbs/03a_parallel.ipynb

@@ -70,15 +70,7 @@
    "cell_type": "code",
    "execution_count": null,
    "metadata": {},
-   "outputs": [
-    {
-     "name": "stdout",
-     "output_type": "stream",
-     "text": [
-      "first\n"
-     ]
-    }
-   ],
+   "outputs": [],
    "source": [
     "@threaded\n",
     "def _1():\n",
@@ -110,7 +102,15 @@
    "cell_type": "code",
    "execution_count": null,
    "metadata": {},
-   "outputs": [],
+   "outputs": [
+    {
+     "name": "stdout",
+     "output_type": "stream",
+     "text": [
+      "first\n"
+     ]
+    }
+   ],
    "source": [
     "@startthread\n",
     "def _():\n",
@@ -160,8 +160,7 @@
      "name": "stdout",
      "output_type": "stream",
      "text": [
-      "firstsecond\n",
-      "\n"
+      "first\n"
      ]
     }
    ],
@@ -194,7 +193,7 @@
     "        if self.not_parallel: max_workers=1\n",
     "        super().__init__(max_workers, **kwargs)\n",
     "\n",
-    "    def map(self, f, items, timeout=None, chunksize=1, *args, **kwargs):\n",
+    "    def map(self, f, items, *args, timeout=None, chunksize=1, **kwargs):\n",
     "        self.lock = Manager().Lock()\n",
     "        g = partial(f, *args, **kwargs)\n",
     "        if self.not_parallel: return map(g, items)\n",
@@ -219,7 +218,7 @@
     "        if self.not_parallel: max_workers=1\n",
     "        super().__init__(max_workers, **kwargs)\n",
     "\n",
-    "    def map(self, f, items, timeout=None, chunksize=1, *args, **kwargs):\n",
+    "    def map(self, f, items, *args, timeout=None, chunksize=1, **kwargs):\n",
     "        self.lock = Manager().Lock()\n",
     "        g = partial(f, *args, **kwargs)\n",
     "        if self.not_parallel: return map(g, items)\n",
@@ -238,7 +237,7 @@
       "text/markdown": [
        "<h4 id=\"ProcessPoolExecutor\" class=\"doc_header\"><code>class</code> <code>ProcessPoolExecutor</code><a href=\"\" class=\"source_link\" style=\"float:right\">[source]</a></h4>\n",
        "\n",
-       "> <code>ProcessPoolExecutor</code>(**`max_workers`**=*`64`*, **`on_exc`**=*`print`*, **`pause`**=*`0`*, **\\*\\*`kwargs`**) :: [`ProcessPoolExecutor`](/03a.html#ProcessPoolExecutor)\n",
+       "> <code>ProcessPoolExecutor</code>(**`max_workers`**=*`64`*, **`on_exc`**=*`print`*, **`pause`**=*`0`*, **\\*\\*`kwargs`**) :: [`ProcessPoolExecutor`](/parallel.html#ProcessPoolExecutor)\n",
        "\n",
        "Same as Python's ProcessPoolExecutor, except can pass `max_workers==0` for serial execution"
       ],
@@ -258,15 +257,7 @@
    "cell_type": "code",
    "execution_count": null,
    "metadata": {},
-   "outputs": [
-    {
-     "name": "stdout",
-     "output_type": "stream",
-     "text": [
-      "second\n"
-     ]
-    }
-   ],
+   "outputs": [],
    "source": [
     "#export\n",
     "try: from fastprogress import progress_bar\n",
@@ -377,11 +368,11 @@
      "name": "stdout",
      "output_type": "stream",
      "text": [
-      "0 2020-11-27 09:27:28.845698\n",
-      "1 2020-11-27 09:27:29.096662\n",
-      "2 2020-11-27 09:27:29.347888\n",
-      "3 2020-11-27 09:27:29.597825\n",
-      "4 2020-11-27 09:27:29.849458\n"
+      "0 2020-12-11 18:28:04.960255\n",
+      "1 2020-12-11 18:28:05.211221\n",
+      "2 2020-12-11 18:28:05.461427\n",
+      "3 2020-12-11 18:28:05.711582\n",
+      "4 2020-12-11 18:28:05.962502\n"
      ]
     }
    ],
@@ -537,7 +528,7 @@
       "Converted 01_basics.ipynb.\n",
       "Converted 02_foundation.ipynb.\n",
       "Converted 03_xtras.ipynb.\n",
-      "Converted 03a.ipynb.\n",
+      "Converted 03a_parallel.ipynb.\n",
       "Converted 03b_net.ipynb.\n",
       "Converted 04_dispatch.ipynb.\n",
       "Converted 05_transform.ipynb.\n",