fixes #132

Author: jph00

fastcore/utils.py

@@ -99,7 +99,7 @@ def exec_local(code, var_name):
 
 # Cell
 def risinstance(types, obj=None):
-    "Curried `isinstance` but with args reversed, suitable for `partial`"
+    "Curried `isinstance` but with args reversed"
     if not obj: return partial(risinstance,types)
     return isinstance(obj, types)
 
@@ -586,8 +586,10 @@ def urlread(url, data=None, **kwargs):
     if data is not None:
         if not isinstance(data, (str,bytes)): data = urlencode(data)
         if not isinstance(data, bytes): data = data.encode('ascii')
-    req=urllib.request.Request(url,headers={'User-Agent': 'Mozilla/5.0'})
-    with urlopen(req, data=data) as res: return res.read()
+    cls = urllib.request.Request
+    if not isinstance(url,cls): url = cls(url)
+    url.headers['User-Agent'] = 'Mozilla/5.0'
+    with urlopen(url, data=data) as res: return res.read()
 
 # Cell
 def urljson(url, data=None):

nbs/02_utils.ipynb

@@ -296,7 +296,7 @@
     {
      "data": {
       "text/plain": [
-       "<__main__._t at 0x7f150b4c2f40>"
+       "<__main__._t at 0x7f8a3f586e50>"
       ]
      },
      "execution_count": null,
@@ -2194,7 +2194,7 @@
     {
      "data": {
       "text/plain": [
-       "['d', 'f', 'e', 'g', 'h', 'b', 'c', 'a']"
+       "['h', 'a', 'c', 'f', 'd', 'e', 'b', 'g']"
       ]
      },
      "execution_count": null,
@@ -3189,8 +3189,10 @@
     "    if data is not None:\n",
     "        if not isinstance(data, (str,bytes)): data = urlencode(data)\n",
     "        if not isinstance(data, bytes): data = data.encode('ascii')\n",
-    "    req=urllib.request.Request(url,headers={'User-Agent': 'Mozilla/5.0'})\n",
-    "    with urlopen(req, data=data) as res: return res.read()"
+    "    cls = urllib.request.Request\n",
+    "    if not isinstance(url,cls): url = cls(url)\n",
+    "    url.headers['User-Agent'] = 'Mozilla/5.0'\n",
+    "    with urlopen(url, data=data) as res: return res.read()"
    ]
   },
   {