fixes #327

Author: jph00

fastcore/__init__.py

@@ -1 +1 @@
-__version__ = "1.3.20"
+__version__ = "1.3.21"

fastcore/net.py

@@ -134,15 +134,17 @@ def urlcheck(url, timeout=10):
 # Cell
 def urlclean(url):
     "Remove fragment, params, and querystring from `url` if present"
-    return urlunparse(urlparse(url)[:3]+('','',''))
+    return urlunparse(urlparse(str(url))[:3]+('','',''))
 
 # Cell
 def urlsave(url, dest=None):
     "Retrieve `url` and save based on its name"
     res = urlread(urlwrap(url), decode=False)
-    if dest is None: dest = Path(url).name
-    name = urlclean(dest)
-    Path(name).write_bytes(res)
+    name = urlclean(Path(url).name)
+    if dest is None: dest = name
+    dest = Path(dest)
+    if dest.is_dir(): dest = dest/name
+    Path(dest).write_bytes(res)
     return dest
 
 # Cell

nbs/03b_net.ipynb

@@ -348,7 +348,7 @@
     "#export\n",
     "def urlclean(url):\n",
     "    \"Remove fragment, params, and querystring from `url` if present\"\n",
-    "    return urlunparse(urlparse(url)[:3]+('','',''))"
+    "    return urlunparse(urlparse(str(url))[:3]+('','',''))"
    ]
   },
   {
@@ -370,12 +370,32 @@
     "def urlsave(url, dest=None):\n",
     "    \"Retrieve `url` and save based on its name\"\n",
     "    res = urlread(urlwrap(url), decode=False)\n",
-    "    if dest is None: dest = Path(url).name\n",
-    "    name = urlclean(dest)\n",
-    "    Path(name).write_bytes(res)\n",
+    "    name = urlclean(Path(url).name)\n",
+    "    if dest is None: dest = name\n",
+    "    dest = Path(dest)\n",
+    "    if dest.is_dir(): dest = dest/name\n",
+    "    Path(dest).write_bytes(res)\n",
     "    return dest"
    ]
   },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "metadata": {},
+   "outputs": [
+    {
+     "name": "stdout",
+     "output_type": "stream",
+     "text": [
+      "[Path('/tmp/tmpr3kv5gq_/index.html')]\n"
+     ]
+    }
+   ],
+   "source": [
+    "#skip\n",
+    "with tempfile.TemporaryDirectory() as d: urlsave('http://www.google.com/index.html', d)"
+   ]
+  },
   {
    "cell_type": "code",
    "execution_count": null,
@@ -626,7 +646,8 @@
       "Converted 05_transform.ipynb.\n",
       "Converted 07_meta.ipynb.\n",
       "Converted 08_script.ipynb.\n",
-      "Converted index.ipynb.\n"
+      "Converted index.ipynb.\n",
+      "Converted parallel_win.ipynb.\n"
      ]
     }
    ],

settings.ini

@@ -7,7 +7,7 @@ author = Jeremy Howard and Sylvain Gugger
 author_email = [email protected]
 copyright = fast.ai
 branch = master
-version = 1.3.20
+version = 1.3.21
 min_python = 3.6
 audience = Developers
 language = English