fixes #157

Author: jph00

fastcore/dispatch.py

@@ -167,17 +167,17 @@ def __call__(self, f):
 #nbdev_comment _all_=['cast']
 
 # Cell
-def retain_meta(x, res, copy_meta=False):
+def retain_meta(x, res, as_copy=False):
     "Call `res.set_meta(x)`, if it exists"
-    if hasattr(res,'set_meta'): res.set_meta(x, copy_meta=copy_meta)
+    if hasattr(res,'set_meta'): res.set_meta(x, as_copy=as_copy)
     return res
 
 # Cell
-def default_set_meta(self, x, copy_meta=False):
+def default_set_meta(self, x, as_copy=False):
     "Copy over `_meta` from `x` to `res`, if it's missing"
     if hasattr(x, '_meta') and not hasattr(self, '_meta'):
         meta = x._meta
-        if copy_meta: meta = copy(meta)
+        if as_copy: meta = copy(meta)
         self._meta = meta
     return self
 
@@ -194,7 +194,7 @@ def cast(x, typ):
     return retain_meta(x, res)
 
 # Cell
-def retain_type(new, old=None, typ=None, copy_meta=False):
+def retain_type(new, old=None, typ=None, as_copy=False):
     "Cast `new` to type of `old` or `typ` if it's a superclass"
     # e.g. old is TensorImage, new is Tensor - if not subclass then do nothing
     if new is None: return
@@ -204,7 +204,7 @@ def retain_type(new, old=None, typ=None, copy_meta=False):
         typ = old if isinstance(old,type) else type(old)
     # Do nothing the new type is already an instance of requested type (i.e. same type)
     if typ==NoneType or isinstance(new, typ): return new
-    return retain_meta(old, cast(new, typ), copy_meta=copy_meta)
+    return retain_meta(old, cast(new, typ), as_copy=as_copy)
 
 # Cell
 def retain_types(new, old=None, typs=None):

nbs/04_dispatch.ipynb

@@ -1319,9 +1319,9 @@
    "outputs": [],
    "source": [
     "#export\n",
-    "def retain_meta(x, res, copy_meta=False):\n",
+    "def retain_meta(x, res, as_copy=False):\n",
     "    \"Call `res.set_meta(x)`, if it exists\"\n",
-    "    if hasattr(res,'set_meta'): res.set_meta(x, copy_meta=copy_meta)\n",
+    "    if hasattr(res,'set_meta'): res.set_meta(x, as_copy=as_copy)\n",
     "    return res"
    ]
   },
@@ -1332,11 +1332,11 @@
    "outputs": [],
    "source": [
     "#export\n",
-    "def default_set_meta(self, x, copy_meta=False):\n",
+    "def default_set_meta(self, x, as_copy=False):\n",
     "    \"Copy over `_meta` from `x` to `res`, if it's missing\"\n",
     "    if hasattr(x, '_meta') and not hasattr(self, '_meta'):\n",
     "        meta = x._meta\n",
-    "        if copy_meta: meta = copy(meta)\n",
+    "        if as_copy: meta = copy(meta)\n",
     "        self._meta = meta\n",
     "    return self"
    ]
@@ -1420,7 +1420,7 @@
    "outputs": [],
    "source": [
     "#export\n",
-    "def retain_type(new, old=None, typ=None, copy_meta=False):\n",
+    "def retain_type(new, old=None, typ=None, as_copy=False):\n",
     "    \"Cast `new` to type of `old` or `typ` if it's a superclass\"\n",
     "    # e.g. old is TensorImage, new is Tensor - if not subclass then do nothing\n",
     "    if new is None: return\n",
@@ -1430,7 +1430,7 @@
     "        typ = old if isinstance(old,type) else type(old)\n",
     "    # Do nothing the new type is already an instance of requested type (i.e. same type)\n",
     "    if typ==NoneType or isinstance(new, typ): return new\n",
-    "    return retain_meta(old, cast(new, typ), copy_meta=copy_meta)"
+    "    return retain_meta(old, cast(new, typ), as_copy=as_copy)"
    ]
   },
   {
@@ -1551,13 +1551,14 @@
      "output_type": "stream",
      "text": [
       "Converted 00_test.ipynb.\n",
-      "Converted 01_foundation.ipynb.\n",
-      "Converted 02_utils.ipynb.\n",
-      "Converted 03_dispatch.ipynb.\n",
-      "Converted 04_transform.ipynb.\n",
-      "Converted 05_logargs.ipynb.\n",
-      "Converted 06_meta.ipynb.\n",
-      "Converted 07_script.ipynb.\n",
+      "Converted 01_basics.ipynb.\n",
+      "Converted 02_foundation.ipynb.\n",
+      "Converted 03_xtras.ipynb.\n",
+      "Converted 04_dispatch.ipynb.\n",
+      "Converted 05_transform.ipynb.\n",
+      "Converted 06_logargs.ipynb.\n",
+      "Converted 07_meta.ipynb.\n",
+      "Converted 08_script.ipynb.\n",
       "Converted index.ipynb.\n"
      ]
     }