fixes #226

Author: jph00

fastcore/basics.py

@@ -293,7 +293,7 @@ def store_attr(names=None, self=None, but='', cast=False, store_args=None, **att
     anno = annotations(self) if cast else {}
     if not attrs:
         if names and isinstance(names,str): names = re.split(', *', names)
-        ns = names if names else args[1:]
+        ns = names if names else getattr(self, '__slots__', args[1:])
         attrs = {n:fr.f_locals[n] for n in ns}
     if isinstance(but,str): but = re.split(', *', but)
     attrs = {k:v for k,v in attrs.items() if k not in but}

fastcore/xtras.py

@@ -254,7 +254,7 @@ def urlrequest(url, verb, headers=None, route=None, query=None, data=None, json_
     if route: url = url.format(**route)
     if query: url += '?' + urlencode(query)
     if data: data = (json.dumps if json_data else urlencode)(data).encode('ascii')
-    return Request(url, headers=headers or {}, data=data or None, method=verb)
+    return Request(url, headers=headers or {}, data=data or None, method=verb.upper())
 
 # Cell
 def loads(s, encoding=None, cls=None, object_hook=None, parse_float=None,

nbs/01_basics.ipynb

@@ -1578,7 +1578,7 @@
     "    anno = annotations(self) if cast else {}\n",
     "    if not attrs:\n",
     "        if names and isinstance(names,str): names = re.split(', *', names)\n",
-    "        ns = names if names else args[1:]\n",
+    "        ns = names if names else getattr(self, '__slots__', args[1:])\n",
     "        attrs = {n:fr.f_locals[n] for n in ns}\n",
     "    if isinstance(but,str): but = re.split(', *', but)\n",
     "    attrs = {k:v for k,v in attrs.items() if k not in but}\n",

nbs/03_xtras.ipynb

@@ -1389,7 +1389,7 @@
     "    if route: url = url.format(**route)\n",
     "    if query: url += '?' + urlencode(query)\n",
     "    if data: data = (json.dumps if json_data else urlencode)(data).encode('ascii')\n",
-    "    return Request(url, headers=headers or {}, data=data or None, method=verb)"
+    "    return Request(url, headers=headers or {}, data=data or None, method=verb.upper())"
    ]
   },
   {