Merge pull request #308 from pradeepbbl/issue/304-fix-archive-dowload

fix #304 UnicodeDecodeError while downloading git archive

Author: Hamel Husain

fastcore/net.py

@@ -172,6 +172,10 @@ def urlsend(url, verb, headers=None, route=None, query=None, data=None, json_dat
     "Send request with `urlrequest`, converting result to json if `return_json`"
     req = urlrequest(url, verb, headers, route=route, query=query, data=data, json_data=json_data)
     if debug: debug(req)
+
+    if route and route.get('archive_format', None):
+        return urlread(req, decode=False, return_json=False, return_headers=return_headers)
+
     return urlread(req, return_json=return_json, return_headers=return_headers)
 
 # Cell

nbs/03b_net.ipynb

@@ -490,9 +490,43 @@
     "    \"Send request with `urlrequest`, converting result to json if `return_json`\"\n",
     "    req = urlrequest(url, verb, headers, route=route, query=query, data=data, json_data=json_data)\n",
     "    if debug: debug(req)\n",
+    "    \n",
+    "    if route and route.get('archive_format', None):\n",
+    "        return urlread(req, decode=False, return_json=False, return_headers=return_headers)\n",
+    "    \n",
     "    return urlread(req, return_json=return_json, return_headers=return_headers)"
    ]
   },
+  {
+   "cell_type": "markdown",
+   "metadata": {},
+   "source": [
+    "Test [ghapi.actions.download_artifact](https://docs.github.com/rest/reference/actions#download-an-artifact)"
+   ]
+  },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "metadata": {},
+   "outputs": [],
+   "source": [
+    "\n",
+    "url = \"https://github.com/fastai/ghapi/archive/refs/tags/0.1.15.zip\"\n",
+    "header={'Accept': 'application/vnd.github.v3+json'}\n",
+    "route={'artifact_id': 1234, 'archive_format': 'zip'} \n",
+    "\n",
+    "res = urlsend(url, \"get\", headers=header, route=route)\n",
+    "assert type(res) is bytes\n",
+    "\n",
+    "def _org_urlsend(url, verb, headers=None, route=None, query=None, data=None, json_data=True,\n",
+    "            return_json=True, return_headers=False, debug=None):\n",
+    "    req = urlrequest(url, verb, headers, route=route, query=query, data=data, json_data=json_data)\n",
+    "    if debug: debug(req)\n",
+    "    return urlread(req, return_json=return_json, return_headers=return_headers)\n",
+    "\n",
+    "test_fail(_org_urlsend, args=dict(url=url, verb=\"get\", headers=header, route=route), msg=\"'utf-8' codec can't decode\")"
+   ]
+  },
   {
    "cell_type": "code",
    "execution_count": null,