fixes #121

Author: jph00

fastcore/_nbdev.py

@@ -111,7 +111,6 @@
          "load_pickle": "02_utils.ipynb",
          "Path.ls": "02_utils.ipynb",
          "Path.__repr__": "02_utils.ipynb",
-         "remove_patches_path": "02_utils.ipynb",
          "bunzip": "02_utils.ipynb",
          "join_path_file": "02_utils.ipynb",
          "urlread": "02_utils.ipynb",

fastcore/utils.py

@@ -7,10 +7,10 @@
            'Float', 'tuplify', 'detuplify', 'replicate', 'uniqueify', 'setify', 'merge', 'is_listy', 'range_of',
            'groupby', 'last_index', 'shufflish', 'IterLen', 'ReindexCollection', 'num_methods', 'rnum_methods',
            'inum_methods', 'fastuple', 'trace', 'compose', 'maps', 'partialler', 'mapped', 'instantiate', 'using_attr',
-           'Self', 'Self', 'save_pickle', 'load_pickle', 'remove_patches_path', 'bunzip', 'join_path_file', 'urlread',
-           'urljson', 'run', 'do_request', 'sort_by_run', 'PrettyString', 'round_multiple', 'even_mults', 'num_cpus',
-           'add_props', 'ContextManagers', 'set_num_threads', 'ProcessPoolExecutor', 'ThreadPoolExecutor', 'parallel',
-           'run_procs', 'parallel_gen']
+           'Self', 'Self', 'save_pickle', 'load_pickle', 'bunzip', 'join_path_file', 'urlread', 'urljson', 'run',
+           'do_request', 'sort_by_run', 'PrettyString', 'round_multiple', 'even_mults', 'num_cpus', 'add_props',
+           'ContextManagers', 'set_num_threads', 'ProcessPoolExecutor', 'ThreadPoolExecutor', 'parallel', 'run_procs',
+           'parallel_gen']
 
 # Cell
 from .imports import *
@@ -545,19 +545,6 @@ def __repr__(self:Path):
         except: pass
     return f"Path({self.as_posix()!r})"
 
-# Cell
-_patched = ['read', 'readlines', 'write', 'save', 'load', 'ls']
-
-@contextmanager
-def remove_patches_path():
-    "A context manager for disabling Path extensions."
-    patches = L(getattr(Path, n) for n in _patched)
-    try:
-        for n in _patched: delattr(Path, n)
-        yield
-    finally:
-        for (n, f) in zip(_patched, patches): setattr(Path, n, f)
-
 # Cell
 def bunzip(fn):
     "bunzip `fn`, raising exception if output already exists"

nbs/02_utils.ipynb

@@ -295,7 +295,7 @@
     {
      "data": {
       "text/plain": [
-       "<__main__._t at 0x7fcf69d97d10>"
+       "<__main__._t at 0x7f85ba48cfd0>"
       ]
      },
      "execution_count": null,
@@ -2170,7 +2170,7 @@
     {
      "data": {
       "text/plain": [
-       "['b', 'f', 'h', 'a', 'c', 'g', 'e', 'd']"
+       "['e', 'g', 'f', 'b', 'c', 'a', 'd', 'h']"
       ]
      },
      "execution_count": null,
@@ -3057,44 +3057,6 @@
     "finally: Path.BASE_PATH = None"
    ]
   },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "metadata": {},
-   "outputs": [],
-   "source": [
-    "#export\n",
-    "_patched = ['read', 'readlines', 'write', 'save', 'load', 'ls']\n",
-    "\n",
-    "@contextmanager\n",
-    "def remove_patches_path():\n",
-    "    \"A context manager for disabling Path extensions.\"\n",
-    "    patches = L(getattr(Path, n) for n in _patched)\n",
-    "    try:\n",
-    "        for n in _patched: delattr(Path, n)\n",
-    "        yield\n",
-    "    finally:\n",
-    "        for (n, f) in zip(_patched, patches): setattr(Path, n, f)"
-   ]
-  },
-  {
-   "cell_type": "markdown",
-   "metadata": {},
-   "source": [
-    "You can temporarily disable the various `Path` extensions by using `remove_patches_path` as a context manager as illustrated below:"
-   ]
-  },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "metadata": {},
-   "outputs": [],
-   "source": [
-    "with remove_patches_path():\n",
-    "    assert not hasattr(Path, 'write')\n",
-    "assert hasattr(Path, 'write')"
-   ]
-  },
   {
    "cell_type": "markdown",
    "metadata": {},
@@ -3897,11 +3859,11 @@
      "name": "stdout",
      "output_type": "stream",
      "text": [
-      "0 2020-10-08 18:02:47.582440\n",
-      "1 2020-10-08 18:02:47.833442\n",
-      "2 2020-10-08 18:02:48.083059\n",
-      "3 2020-10-08 18:02:48.334451\n",
-      "4 2020-10-08 18:02:48.584491\n"
+      "0 2020-10-08 18:38:18.973557\n",
+      "1 2020-10-08 18:38:19.223553\n",
+      "2 2020-10-08 18:38:19.475253\n",
+      "3 2020-10-08 18:38:19.725614\n",
+      "4 2020-10-08 18:38:19.976216\n"
      ]
     }
    ],