dispatch object

Author: jph00

fastcore/__init__.py

@@ -1 +1 @@
-__version__ = "1.2.3"
+__version__ = "1.2.4"

fastcore/dispatch.py

@@ -25,7 +25,7 @@ def anno_ret(func):
 # Cell
 def lenient_issubclass(cls, types):
     "If possible return whether `cls` is a subclass of `types`, otherwise return False."
-    if cls is object and types is type: return False # treat `object` as higher level than `type`
+    if cls is object and types is not object: return False # treat `object` as highest level
     try: return isinstance(cls, types) or issubclass(cls, types)
     except: return False
 

nbs/03_dispatch.ipynb

@@ -203,7 +203,7 @@
     "#export\n",
     "def lenient_issubclass(cls, types):\n",
     "    \"If possible return whether `cls` is a subclass of `types`, otherwise return False.\"\n",
-    "    if cls is object and types is type: return False # treat `object` as higher level than `type`\n",
+    "    if cls is object and types is not object: return False # treat `object` as highest level\n",
     "    try: return isinstance(cls, types) or issubclass(cls, types)\n",
     "    except: return False"
    ]
@@ -229,7 +229,8 @@
     "assert lenient_issubclass(list, typing.Collection)\n",
     "assert lenient_issubclass(typing.Collection, object)\n",
     "assert lenient_issubclass(typing.List, typing.Collection)\n",
-    "assert not lenient_issubclass(typing.Collection, typing.List)"
+    "assert not lenient_issubclass(typing.Collection, typing.List)\n",
+    "assert not lenient_issubclass(object, typing.Callable)"
    ]
   },
   {

settings.ini

@@ -7,7 +7,7 @@ author = Jeremy Howard and Sylvain Gugger
 author_email = [email protected]
 copyright = fast.ai
 branch = master
-version = 1.2.3
+version = 1.2.4
 min_python = 3.6
 audience = Developers
 language = English