fix trace

Author: jph00

fastcore/__init__.py

@@ -1 +1 @@
-__version__ = "1.0.23"
+__version__ = "1.0.24"

fastcore/utils.py

@@ -18,6 +18,7 @@
 
 import mimetypes,bz2,pickle,random,json,urllib,subprocess,shlex
 from contextlib import contextmanager
+from pdb import set_trace
 from urllib.request import Request,urlopen
 from urllib.error import HTTPError
 from urllib.parse import urlencode
@@ -411,9 +412,11 @@ def _f(self,*args): return self._op(op,*args)
 # Cell
 def trace(f):
     "Add `set_trace` to an existing function `f`"
+    if getattr(f, '_traced', False): return f
     def _inner(*args,**kwargs):
         set_trace()
         return f(*args,**kwargs)
+    _inner._traced = True
     return _inner
 
 # Cell

nbs/02_utils.ipynb

@@ -22,6 +22,7 @@
     "\n",
     "import mimetypes,bz2,pickle,random,json,urllib,subprocess,shlex\n",
     "from contextlib import contextmanager\n",
+    "from pdb import set_trace\n",
     "from urllib.request import Request,urlopen\n",
     "from urllib.error import HTTPError\n",
     "from urllib.parse import urlencode"
@@ -294,7 +295,7 @@
     {
      "data": {
       "text/plain": [
-       "<__main__._t at 0x7f4a534e8730>"
+       "<__main__._t at 0x7fe83401cca0>"
       ]
      },
      "execution_count": null,
@@ -2169,7 +2170,7 @@
     {
      "data": {
       "text/plain": [
-       "['b', 'f', 'c', 'a', 'g', 'h', 'd', 'e']"
+       "['h', 'c', 'e', 'a', 'g', 'b', 'f', 'd']"
       ]
      },
      "execution_count": null,
@@ -2521,50 +2522,26 @@
     "#export\n",
     "def trace(f):\n",
     "    \"Add `set_trace` to an existing function `f`\"\n",
+    "    if getattr(f, '_traced', False): return f\n",
     "    def _inner(*args,**kwargs):\n",
     "        set_trace()\n",
     "        return f(*args,**kwargs)\n",
+    "    _inner._traced = True\n",
     "    return _inner"
    ]
   },
   {
    "cell_type": "markdown",
    "metadata": {},
    "source": [
-    "We can faciltate debugging with [the python debugger (pdb)](https://docs.python.org/3/library/pdb.html) by annotating your function with the `@trace` decorator:"
-   ]
-  },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "metadata": {},
-   "outputs": [],
-   "source": [
-    "@trace\n",
-    "def myfunc(x):return x +1"
-   ]
-  },
-  {
-   "cell_type": "markdown",
-   "metadata": {},
-   "source": [
-    "Now, when the function is called it will drop you into the debugger.  Note, you must issue  the `s` command when you begin to step into the function that is being traced:\n",
+    "You can add a breakpoint to an existing function, e.g:\n",
     "\n",
-    "```bash\n",
-    "> myfunc(3)\n",
-    "> <ipython-input-257-13ccd7456a8e>(6)_inner()\n",
-    "      3     \"Add `set_trace` to an existing function `f`\"\n",
-    "      4     def _inner(*args,**kwargs):\n",
-    "      5         set_trace()\n",
-    "----> 6         return f(*args,**kwargs)\n",
-    "      7     return _inner\n",
+    "```python\n",
+    "Path.cwd = trace(Path.cwd)\n",
+    "Path.cwd()\n",
+    "```\n",
     "\n",
-    "ipdb> s\n",
-    "--Call--\n",
-    "> <ipython-input-260-b3d1b2a13afb>(1)myfunc()\n",
-    "----> 1 @trace\n",
-    "      2 def myfunc(x):return x +1\n",
-    "```"
+    "Now, when the function is called it will drop you into the debugger.  Note, you must issue  the `s` command when you begin to step into the function that is being traced."
    ]
   },
   {

settings.ini

@@ -7,7 +7,7 @@ author = Jeremy Howard and Sylvain Gugger
 author_email = [email protected]
 copyright = fast.ai
 branch = master
-version = 1.0.23
+version = 1.0.24
 min_python = 3.6
 audience = Developers
 language = English