fixes #211

Author: jph00

fastcore/_nbdev.py

@@ -148,6 +148,7 @@
          "image_size": "03_xtras.ipynb",
          "bunzip": "03_xtras.ipynb",
          "join_path_file": "03_xtras.ipynb",
+         "urlquote": "03_xtras.ipynb",
          "urlwrap": "03_xtras.ipynb",
          "urlopen": "03_xtras.ipynb",
          "urlread": "03_xtras.ipynb",

fastcore/xtras.py

@@ -1,9 +1,9 @@
 # AUTOGENERATED! DO NOT EDIT! File to edit: nbs/03_xtras.ipynb (unless otherwise specified).
 
 __all__ = ['dict2obj', 'repr_dict', 'is_listy', 'shufflish', 'mapped', 'IterLen', 'ReindexCollection', 'open_file',
-           'save_pickle', 'load_pickle', 'maybe_open', 'image_size', 'bunzip', 'join_path_file', 'urlwrap', 'urlopen',
-           'urlread', 'urljson', 'urlcheck', 'urlclean', 'urlsave', 'urlvalid', 'untar_dir', 'repo_details', 'run',
-           'do_request', 'threaded', 'start_server', 'start_client', 'sort_by_run', 'trace', 'round_multiple',
+           'save_pickle', 'load_pickle', 'maybe_open', 'image_size', 'bunzip', 'join_path_file', 'urlquote', 'urlwrap',
+           'urlopen', 'urlread', 'urljson', 'urlcheck', 'urlclean', 'urlsave', 'urlvalid', 'untar_dir', 'repo_details',
+           'run', 'do_request', 'threaded', 'start_server', 'start_client', 'sort_by_run', 'trace', 'round_multiple',
            'modified_env', 'ContextManagers', 'str2bool', 'set_num_threads', 'ProcessPoolExecutor',
            'ThreadPoolExecutor', 'parallel', 'run_procs', 'parallel_gen']
 
@@ -181,10 +181,17 @@ def join_path_file(file, path, ext=''):
 # Cell
 _ua = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.183 Safari/537.36'
 
+# Cell
+def urlquote(url):
+    "Update url's path with `urllib.parse.quote`"
+    p = list(urlparse(url))
+    p[2] = urllib.parse.quote(p[2])
+    return urlunparse(p)
+
 # Cell
 def urlwrap(url):
     "Wrap `url` in a urllib `Request` with a user-agent header"
-    if not isinstance(url,Request): url = Request(url)
+    if not isinstance(url,Request): url = Request(urlquote(url))
     url.headers['User-Agent'] = _ua
     return url
 

nbs/03_xtras.ipynb

@@ -588,7 +588,7 @@
     {
      "data": {
       "text/plain": [
-       "['a', 'c', 'f', 'd', 'g', 'e', 'b', 'h']"
+       "['b', 'h', 'd', 'a', 'g', 'f', 'c', 'e']"
       ]
      },
      "execution_count": null,
@@ -1157,6 +1157,40 @@
     "_ua = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.183 Safari/537.36'"
    ]
   },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "metadata": {},
+   "outputs": [],
+   "source": [
+    "#export\n",
+    "def urlquote(url):\n",
+    "    \"Update url's path with `urllib.parse.quote`\"\n",
+    "    p = list(urlparse(url))\n",
+    "    p[2] = urllib.parse.quote(p[2])\n",
+    "    return urlunparse(p)"
+   ]
+  },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "metadata": {},
+   "outputs": [
+    {
+     "data": {
+      "text/plain": [
+       "'https://github.com/fastai/fastai/compare/master%40%7B1.day.ago%7D%E2%80%A6master'"
+      ]
+     },
+     "execution_count": null,
+     "metadata": {},
+     "output_type": "execute_result"
+    }
+   ],
+   "source": [
+    "urlquote(\"https://github.com/fastai/fastai/compare/master@{1.day.ago}…master\")"
+   ]
+  },
   {
    "cell_type": "code",
    "execution_count": null,
@@ -1166,7 +1200,7 @@
     "#export\n",
     "def urlwrap(url):\n",
     "    \"Wrap `url` in a urllib `Request` with a user-agent header\"\n",
-    "    if not isinstance(url,Request): url = Request(url)\n",
+    "    if not isinstance(url,Request): url = Request(urlquote(url))\n",
     "    url.headers['User-Agent'] = _ua\n",
     "    return url"
    ]