fixes #213

Author: jph00

fastcore/__init__.py

@@ -1 +1 @@
-__version__ = "1.3.6"
+__version__ = "1.3.7"

fastcore/xtras.py

@@ -184,9 +184,12 @@ def join_path_file(file, path, ext=''):
 # Cell
 def urlquote(url):
     "Update url's path with `urllib.parse.quote`"
+    subdelims = "!$&'()*+,;="
+    gendelims = ":?#[]@"
+    safe = subdelims+gendelims+"%"
     p = list(urlparse(url))
-    p[2] = urllib.parse.quote(p[2])
-    for i in range(3,6): p[i] = urllib.parse.quote(p[i], safe="/=&")
+    p[2] = urllib.parse.quote(p[2], safe=safe)
+    for i in range(3,6): p[i] = urllib.parse.quote(p[i], safe=safe)
     return urlunparse(p)
 
 # Cell

nbs/03_xtras.ipynb

@@ -588,7 +588,7 @@
     {
      "data": {
       "text/plain": [
-       "['h', 'b', 'c', 'f', 'g', 'a', 'd', 'e']"
+       "['e', 'c', 'h', 'a', 'f', 'g', 'b', 'd']"
       ]
      },
      "execution_count": null,
@@ -1166,9 +1166,12 @@
     "#export\n",
     "def urlquote(url):\n",
     "    \"Update url's path with `urllib.parse.quote`\"\n",
+    "    subdelims = \"!$&'()*+,;=\"\n",
+    "    gendelims = \":?#[]@\"\n",
+    "    safe = subdelims+gendelims+\"%\"\n",
     "    p = list(urlparse(url))\n",
-    "    p[2] = urllib.parse.quote(p[2])\n",
-    "    for i in range(3,6): p[i] = urllib.parse.quote(p[i], safe=\"/=&\")\n",
+    "    p[2] = urllib.parse.quote(p[2], safe=safe)\n",
+    "    for i in range(3,6): p[i] = urllib.parse.quote(p[i], safe=safe)\n",
     "    return urlunparse(p)"
    ]
   },
@@ -1180,7 +1183,7 @@
     {
      "data": {
       "text/plain": [
-       "'https://github.com/fastai/fastai/compare/master%40%7B1.day.ago%7D%E2%80%A6master'"
+       "'https://github.com/%2Ffastai%2Ffastai%2Fcompare%2Fmaster@%7B1.day.ago%7D%E2%80%A6master'"
       ]
      },
      "execution_count": null,
@@ -1200,7 +1203,7 @@
     {
      "data": {
       "text/plain": [
-       "'https://www.google.com/search?q=%E4%BD%A0%E5%A5%BD'"
+       "'https://www.google.com/%2Fsearch?q=%E4%BD%A0%E5%A5%BD'"
       ]
      },
      "execution_count": null,

settings.ini

@@ -7,7 +7,7 @@ author = Jeremy Howard and Sylvain Gugger
 author_email = [email protected]
 copyright = fast.ai
 branch = master
-version = 1.3.6
+version = 1.3.7
 min_python = 3.6
 audience = Developers
 language = English