fixes #145

Author: jph00

00_core.ipynb

@@ -85,16 +85,8 @@
     "    params =  [_mk_param(k) for k in req_args]\n",
     "    params += [_mk_param(k, default=v) for k,v in opt_args.items()]\n",
     "    params += [_mk_param(k, **_mk_sig_detls(v)) for k,v in anno_args.items()]\n",
-    "    return Signature(params)"
-   ]
-  },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "metadata": {},
-   "outputs": [],
-   "source": [
-    "#|export\n",
+    "    return Signature(params)\n",
+    "\n",
     "class _GhObj: pass"
    ]
   },
@@ -165,6 +157,18 @@
     "_docroot = 'https://docs.github.com/rest/reference/'"
    ]
   },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "metadata": {},
+   "outputs": [],
+   "source": [
+    "#|export\n",
+    "def print_summary(req:Request):\n",
+    "    \"Print `Request.summary` with the token (if any) removed\"\n",
+    "    pprint(req.summary('Authorization'))"
+   ]
+  },
   {
    "cell_type": "markdown",
    "metadata": {},
@@ -185,7 +189,8 @@
     "        token = token or os.getenv('GITHUB_TOKEN', None)\n",
     "        jwt_token = jwt_token or os.getenv('GITHUB_JWT_TOKEN', None)\n",
     "        if jwt_token: self.headers['Authorization'] = 'Bearer ' + jwt_token\n",
-    "        if token: self.headers['Authorization'] = 'token ' + token\n",
+    "        elif token: self.headers['Authorization'] = 'token ' + token\n",
+    "        else: warn('Neither GITHUB_TOKEN nor GITHUB_JWT_TOKEN found: running as unauthenticated')\n",
     "        if owner: kwargs['owner'] = owner\n",
     "        if repo:  kwargs['repo' ] = repo\n",
     "        funcs_ = L(funcs).starmap(_GhVerb, client=self, kwargs=kwargs)\n",
@@ -203,7 +208,8 @@
     "        if route:\n",
     "            for k,v in route.items(): route[k] = quote(str(route[k]))\n",
     "        return_json = ('json' in headers['Accept'])\n",
-    "        res,self.recv_hdrs = urlsend(path, verb, headers=headers or None, debug=self.debug, return_headers=True,\n",
+    "        debug = self.debug if self.debug else print_summary if os.getenv('GHAPI_DEBUG') else None\n",
+    "        res,self.recv_hdrs = urlsend(path, verb, headers=headers or None, debug=debug, return_headers=True,\n",
     "                                     route=route or None, query=query or None, data=data or None, return_json=return_json)\n",
     "        if 'X-RateLimit-Remaining' in self.recv_hdrs:\n",
     "            newlim = self.recv_hdrs['X-RateLimit-Remaining']\n",
@@ -253,15 +259,22 @@
       "text/markdown": [
        "---\n",
        "\n",
-       "#### GhApi.__call__\n",
+       "### GhApi.__call__\n",
        "\n",
        ">      GhApi.__call__ (path:str, verb:str=None, headers:dict=None,\n",
        ">                      route:dict=None, query:dict=None, data=None)\n",
        "\n",
        "Call a fully specified `path` using HTTP `verb`, passing arguments to `fastcore.core.urlsend`"
       ],
       "text/plain": [
-       "<nbdev.showdoc.BasicMarkdownRenderer>"
+       "---\n",
+       "\n",
+       "### GhApi.__call__\n",
+       "\n",
+       ">      GhApi.__call__ (path:str, verb:str=None, headers:dict=None,\n",
+       ">                      route:dict=None, query:dict=None, data=None)\n",
+       "\n",
+       "Call a fully specified `path` using HTTP `verb`, passing arguments to `fastcore.core.urlsend`"
       ]
      },
      "execution_count": null,
@@ -299,9 +312,9 @@
       "text/markdown": [
        "```json\n",
        "{ 'node_id': 'MDM6UmVmMzE1NzEyNTg4OnJlZnMvaGVhZHMvbWFzdGVy',\n",
-       "  'object': { 'sha': 'af24f2afd42cdaf2e368fed47e52a9f7c6065bed',\n",
+       "  'object': { 'sha': '037bf40e4e5eb32a165db42a35dd89e1c1546493',\n",
        "              'type': 'commit',\n",
-       "              'url': 'https://api.github.com/repos/fastai/ghapi-test/git/commits/af24f2afd42cdaf2e368fed47e52a9f7c6065bed'},\n",
+       "              'url': 'https://api.github.com/repos/fastai/ghapi-test/git/commits/037bf40e4e5eb32a165db42a35dd89e1c1546493'},\n",
        "  'ref': 'refs/heads/master',\n",
        "  'url': 'https://api.github.com/repos/fastai/ghapi-test/git/refs/heads/master'}\n",
        "```"
@@ -310,9 +323,9 @@
        "{'ref': 'refs/heads/master',\n",
        " 'node_id': 'MDM6UmVmMzE1NzEyNTg4OnJlZnMvaGVhZHMvbWFzdGVy',\n",
        " 'url': 'https://api.github.com/repos/fastai/ghapi-test/git/refs/heads/master',\n",
-       " 'object': {'sha': 'af24f2afd42cdaf2e368fed47e52a9f7c6065bed',\n",
+       " 'object': {'sha': '037bf40e4e5eb32a165db42a35dd89e1c1546493',\n",
        "  'type': 'commit',\n",
-       "  'url': 'https://api.github.com/repos/fastai/ghapi-test/git/commits/af24f2afd42cdaf2e368fed47e52a9f7c6065bed'}}"
+       "  'url': 'https://api.github.com/repos/fastai/ghapi-test/git/commits/037bf40e4e5eb32a165db42a35dd89e1c1546493'}}"
       ]
      },
      "execution_count": null,
@@ -335,14 +348,20 @@
       "text/markdown": [
        "---\n",
        "\n",
-       "#### GhApi.__getitem__\n",
+       "### GhApi.__getitem__\n",
        "\n",
        ">      GhApi.__getitem__ (k)\n",
        "\n",
        "Lookup and call an endpoint by path and verb (which defaults to 'GET')"
       ],
       "text/plain": [
-       "<nbdev.showdoc.BasicMarkdownRenderer>"
+       "---\n",
+       "\n",
+       "### GhApi.__getitem__\n",
+       "\n",
+       ">      GhApi.__getitem__ (k)\n",
+       "\n",
+       "Lookup and call an endpoint by path and verb (which defaults to 'GET')"
       ]
      },
      "execution_count": null,
@@ -371,9 +390,9 @@
       "text/markdown": [
        "```json\n",
        "{ 'node_id': 'MDM6UmVmMzE1NzEyNTg4OnJlZnMvaGVhZHMvbWFzdGVy',\n",
-       "  'object': { 'sha': 'af24f2afd42cdaf2e368fed47e52a9f7c6065bed',\n",
+       "  'object': { 'sha': '037bf40e4e5eb32a165db42a35dd89e1c1546493',\n",
        "              'type': 'commit',\n",
-       "              'url': 'https://api.github.com/repos/fastai/ghapi-test/git/commits/af24f2afd42cdaf2e368fed47e52a9f7c6065bed'},\n",
+       "              'url': 'https://api.github.com/repos/fastai/ghapi-test/git/commits/037bf40e4e5eb32a165db42a35dd89e1c1546493'},\n",
        "  'ref': 'refs/heads/master',\n",
        "  'url': 'https://api.github.com/repos/fastai/ghapi-test/git/refs/heads/master'}\n",
        "```"
@@ -382,9 +401,9 @@
        "{'ref': 'refs/heads/master',\n",
        " 'node_id': 'MDM6UmVmMzE1NzEyNTg4OnJlZnMvaGVhZHMvbWFzdGVy',\n",
        " 'url': 'https://api.github.com/repos/fastai/ghapi-test/git/refs/heads/master',\n",
-       " 'object': {'sha': 'af24f2afd42cdaf2e368fed47e52a9f7c6065bed',\n",
+       " 'object': {'sha': '037bf40e4e5eb32a165db42a35dd89e1c1546493',\n",
        "  'type': 'commit',\n",
-       "  'url': 'https://api.github.com/repos/fastai/ghapi-test/git/commits/af24f2afd42cdaf2e368fed47e52a9f7c6065bed'}}"
+       "  'url': 'https://api.github.com/repos/fastai/ghapi-test/git/commits/037bf40e4e5eb32a165db42a35dd89e1c1546493'}}"
       ]
      },
      "execution_count": null,
@@ -418,7 +437,7 @@
     {
      "data": {
       "text/plain": [
-       "'af24f2afd42cdaf2e368fed47e52a9f7c6065bed'"
+       "'037bf40e4e5eb32a165db42a35dd89e1c1546493'"
       ]
      },
      "execution_count": null,
@@ -455,7 +474,7 @@
      "name": "stdout",
      "output_type": "stream",
      "text": [
-      "Quota remaining: 4727 of 5000\n"
+      "Quota remaining: 4995 of 5000\n"
      ]
     },
     {
@@ -491,7 +510,7 @@
     {
      "data": {
       "text/plain": [
-       "'4727'"
+       "'4995'"
       ]
      },
      "execution_count": null,
@@ -788,7 +807,8 @@
    "outputs": [],
    "source": [
     "#|hide\n",
-    "for hook in api.repos.list_webhooks(): api.repos.delete_webhook(hook.id)"
+    "for hook in api.repos.list_webhooks():\n",
+    "    api.repos.delete_webhook(hook.id)"
    ]
   },
   {
@@ -948,18 +968,6 @@
     "print(created, '->', gh2date(created))"
    ]
   },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "metadata": {},
-   "outputs": [],
-   "source": [
-    "#|export\n",
-    "def print_summary(req:Request):\n",
-    "    \"Print `Request.summary` with the token (if any) removed\"\n",
-    "    pprint(req.summary('Authorization'))"
-   ]
-  },
   {
    "cell_type": "markdown",
    "metadata": {},

Makefile

@@ -1 +1 @@
-__version__ = "0.1.23"
+__version__ = "1.0.0"