remove mock test

Author: jph00

nbdev/doclinks.py

@@ -110,8 +110,7 @@ def nbglob(path=None, skip_folder_re = '^[_.]', file_glob='*.ipynb', skip_file_r
     recursive=get_config().recursive
     res = globtastic(path, file_glob=file_glob, skip_folder_re=skip_folder_re,
                      skip_file_re=skip_file_re, recursive=recursive, **kwargs)
-    res = res.map(Path) if as_path else res
-    return res
+    return res.map(Path) if as_path else res
 
 # %% ../nbs/api/doclinks.ipynb 21
 def nbglob_cli(
@@ -140,11 +139,11 @@ def nbdev_export(
     add_init(get_config().lib_path)
     _build_modidx()
 
-# %% ../nbs/api/doclinks.ipynb 26
+# %% ../nbs/api/doclinks.ipynb 24
 import importlib,ast
 from functools import lru_cache
 
-# %% ../nbs/api/doclinks.ipynb 27
+# %% ../nbs/api/doclinks.ipynb 25
 def _find_mod(mod):
     mp,_,mr = mod.partition('/')
     spec = importlib.util.find_spec(mp)
@@ -167,7 +166,7 @@ def _get_exps(mod):
 
 def _lineno(sym, fname): return _get_exps(fname).get(sym, None) if fname else None
 
-# %% ../nbs/api/doclinks.ipynb 29
+# %% ../nbs/api/doclinks.ipynb 27
 def _qual_sym(s, settings):
     if not isinstance(s,tuple): return s
     nb,py = s
@@ -182,10 +181,10 @@ def _qual_syms(entries):
     if 'doc_host' not in settings: return entries
     return {'syms': {mod:_qual_mod(d, settings) for mod,d in entries['syms'].items()}, 'settings':settings}
 
-# %% ../nbs/api/doclinks.ipynb 30
+# %% ../nbs/api/doclinks.ipynb 28
 _re_backticks = re.compile(r'`([^`\s]+)`')
 
-# %% ../nbs/api/doclinks.ipynb 31
+# %% ../nbs/api/doclinks.ipynb 29
 @lru_cache(None)
 class NbdevLookup:
     "Mapping from symbol names to docs and source URLs"

nbs/api/doclinks.ipynb

@@ -316,8 +316,7 @@
     "    recursive=get_config().recursive\n",
     "    res = globtastic(path, file_glob=file_glob, skip_folder_re=skip_folder_re,\n",
     "                     skip_file_re=skip_file_re, recursive=recursive, **kwargs)\n",
-    "    res = res.map(Path) if as_path else res\n",
-    "    return res"
+    "    return res.map(Path) if as_path else res"
    ]
   },
   {
@@ -361,53 +360,6 @@
     "    _build_modidx()"
    ]
   },
-  {
-   "cell_type": "markdown",
-   "metadata": {},
-   "source": [
-    "When exporting the notebooks, they should be exported in order of the filename to ensure deterministic build behaviour. The below test patches `nbglob` to return a non-ordered list, then checks that `nb_export` is still called on the notebooks in the right order:"
-   ]
-  },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "metadata": {},
-   "outputs": [],
-   "source": [
-    "from copy import copy\n",
-    "\n",
-    "\n",
-    "class EscapeException(Exception):\n",
-    "    pass\n",
-    "\n",
-    "def nb_export_mock(nb_path: str):\n",
-    "    expected = expected_order.pop()\n",
-    "    assert nb_path==expected, f'Expected {expected}, got {nb_path}'\n",
-    "    \n",
-    "    # escape from the outer function as the tests are done\n",
-    "    if not expected_order:\n",
-    "        raise EscapeException()\n",
-    "        \n",
-    "# replace those functions by mocks, saving the original objects\n",
-    "nbglob_save = copy(nbglob)\n",
-    "nb_export_save = copy(nb_export)\n",
-    "\n",
-    "nbglob = lambda *args, **kwargs: L(['../../8.ipynb', 'api/3.ipynb', '4.ipynb']).map(Path)\n",
-    "\n",
-    "expected_order = reversed(L(['api/3.ipynb', '4.ipynb', '../../8.ipynb']).map(Path))\n",
-    "#expected_order.reverse()\n",
-    "nb_export = nb_export_mock\n",
-    "\n",
-    "try:\n",
-    "    nbdev_export()\n",
-    "except EscapeException:\n",
-    "    pass # this silences the exception used to end nbdev_export early\n",
-    "\n",
-    "# restore original objects to make sure the notebook runs as intended\n",
-    "nbglob = nbglob_save\n",
-    "nb_export = nb_export_save"
-   ]
-  },
   {
    "cell_type": "markdown",
    "metadata": {},