Merge pull request #1295 from xl0/no-newline

No newline

Author: jph00

README.md

@@ -3,12 +3,8 @@ Getting Started
 
 <!-- WARNING: THIS FILE WAS AUTOGENERATED! DO NOT EDIT! -->
 
-<div>
-
 ![CI](https://github.com/fastai/nbdev/actions/workflows/test.yaml/badge.svg)
 
-</div>
-
 *NB: This is nbdev v2, a major upgrade of nbdev. Whilst the differences
 to nbdev1 aren’t huge, it does require some changes. The old version
 docs are at [nbdev1.fast.ai](https://nbdev1.fast.ai). You can use
@@ -75,8 +71,6 @@ The best way to learn how to use nbdev is to complete either the
 [written walkthrough](https://nbdev.fast.ai/tutorials/tutorial.html) or
 video walkthrough:
 
-<div style="text-align: center">
-
 <div>
 
 <a href="http://www.youtube.com/watch?v=l7zS8Ld4_iA" target="_blank"
@@ -86,8 +80,6 @@ style="border-radius: 10px" width="560" height="315" /></a>
 
 </div>
 
-</div>
-
 Alternatively, there’s a [shortened version of the video
 walkthrough](https://youtu.be/67FdzLSt4aA) with coding sections sped up
 using the `unsilence` Python library – it’s 27 minutes faster, but a bit

nbdev/_modidx.py

@@ -6,7 +6,6 @@
                 'git_url': 'https://github.com/fastai/nbdev',
                 'lib_path': 'nbdev'},
   'syms': { 'nbdev.clean': { 'nbdev.clean._add_jupyter_hooks': ('api/clean.html#_add_jupyter_hooks', 'nbdev/clean.py'),
-                             'nbdev.clean._add_trailing_n': ('api/clean.html#_add_trailing_n', 'nbdev/clean.py'),
                              'nbdev.clean._clean_cell': ('api/clean.html#_clean_cell', 'nbdev/clean.py'),
                              'nbdev.clean._clean_cell_output': ('api/clean.html#_clean_cell_output', 'nbdev/clean.py'),
                              'nbdev.clean._clean_cell_output_id': ('api/clean.html#_clean_cell_output_id', 'nbdev/clean.py'),

nbdev/clean.py

@@ -55,11 +55,6 @@ def _clean_cell_output_id(lines):
     return _skip_or_sub(lines) if isinstance(lines,str) else [_skip_or_sub(o) for o in lines]
 
 # %% ../nbs/api/11_clean.ipynb 11
-def _add_trailing_n(img):
-    if not isinstance(img,str): return [ _add_trailing_n(o) for o in img ]
-    return img + "\n" if img[-1] != "\n" else img
-
-# %% ../nbs/api/11_clean.ipynb 12
 def _clean_cell_output(cell, clean_ids):
     "Remove `cell` output execution count and optionally ids from text reprs"
     outputs = cell.get('outputs', [])
@@ -69,11 +64,11 @@ def _clean_cell_output(cell, clean_ids):
         data.pop("application/vnd.google.colaboratory.intrinsic+json", None)
         for k in data:
             if k.startswith('text') and clean_ids: data[k] = _clean_cell_output_id(data[k])
-            if k.startswith('image'): data[k] = _add_trailing_n(data[k])
+            if k.startswith('image') and "svg" not in k: data[k] = data[k].rstrip()
         if 'text' in o and clean_ids: o['text'] = _clean_cell_output_id(o['text'])
         o.get('metadata', {}).pop('tags', None)
 
-# %% ../nbs/api/11_clean.ipynb 13
+# %% ../nbs/api/11_clean.ipynb 12
 def _clean_cell(cell, clear_all, allowed_metadata_keys, clean_ids):
     "Clean `cell` by removing superfluous metadata or everything except the input if `clear_all`"
     if 'execution_count' in cell: cell['execution_count'] = None
@@ -84,7 +79,7 @@ def _clean_cell(cell, clear_all, allowed_metadata_keys, clean_ids):
     cell['metadata'] = {} if clear_all else {
         k:v for k,v in cell['metadata'].items() if k in allowed_metadata_keys}
 
-# %% ../nbs/api/11_clean.ipynb 14
+# %% ../nbs/api/11_clean.ipynb 13
 def clean_nb(
     nb, # The notebook to clean
     clear_all=False, # Remove all cell metadata and cell outputs?
@@ -93,43 +88,42 @@ def clean_nb(
     clean_ids=True, # Remove ids from plaintext reprs?
 ):
     "Clean `nb` from superfluous metadata"
-    assert isinstance(nb, AttrDict)
     metadata_keys = {"kernelspec", "jekyll", "jupytext", "doc", "widgets"}
     if allowed_metadata_keys: metadata_keys.update(allowed_metadata_keys)
     cell_metadata_keys = {"hide_input"}
     if allowed_cell_metadata_keys: cell_metadata_keys.update(allowed_cell_metadata_keys)
     for c in nb['cells']: _clean_cell(c, clear_all, cell_metadata_keys, clean_ids)
-    if nested_attr(nb, 'metadata.kernelspec.name'):
-        nb['metadata']['kernelspec']['display_name'] = nb.metadata.kernelspec.name
+    if nb.get('metadata', {}).get('kernelspec', {}).get('name', None):
+        nb['metadata']['kernelspec']['display_name'] = nb["metadata"]["kernelspec"]["name"]
     nb['metadata'] = {k:v for k,v in nb['metadata'].items() if k in metadata_keys}
 
-# %% ../nbs/api/11_clean.ipynb 27
+# %% ../nbs/api/11_clean.ipynb 26
 def _reconfigure(*strms):
     for s in strms:
         if hasattr(s,'reconfigure'): s.reconfigure(encoding='utf-8')
 
-# %% ../nbs/api/11_clean.ipynb 28
+# %% ../nbs/api/11_clean.ipynb 27
 def process_write(warn_msg, proc_nb, f_in, f_out=None, disp=False):
     if not f_out: f_out = f_in
     if isinstance(f_in, (str,Path)): f_in = Path(f_in).open(encoding="utf-8")
     try:
         _reconfigure(f_in, f_out)
-        nb = dict2nb(loads(f_in.read()))
+        nb = loads(f_in.read())
         proc_nb(nb)
         write_nb(nb, f_out) if not disp else sys.stdout.write(nb2str(nb))
     except Exception as e:
         warn(f'{warn_msg}')
         warn(e)
 
-# %% ../nbs/api/11_clean.ipynb 29
+# %% ../nbs/api/11_clean.ipynb 28
 def _nbdev_clean(nb, path=None, clear_all=None):
     cfg = get_config(path=path)
     clear_all = clear_all or cfg.clear_all
     allowed_metadata_keys = cfg.get("allowed_metadata_keys").split()
     allowed_cell_metadata_keys = cfg.get("allowed_cell_metadata_keys").split()
     return clean_nb(nb, clear_all, allowed_metadata_keys, allowed_cell_metadata_keys, cfg.clean_ids)
 
-# %% ../nbs/api/11_clean.ipynb 30
+# %% ../nbs/api/11_clean.ipynb 29
 @call_parse
 def nbdev_clean(
     fname:str=None, # A notebook name or glob to clean
@@ -145,15 +139,15 @@ def nbdev_clean(
     if fname is None: fname = get_config().nbs_path
     for f in globtastic(fname, file_glob='*.ipynb', skip_folder_re='^[_.]'): _write(f_in=f, disp=disp)
 
-# %% ../nbs/api/11_clean.ipynb 33
+# %% ../nbs/api/11_clean.ipynb 32
 def clean_jupyter(path, model, **kwargs):
     "Clean Jupyter `model` pre save to `path`"
     if not (model['type']=='notebook' and model['content']['nbformat']==4): return
     get_config.cache_clear() # Allow config changes without restarting Jupyter
     jupyter_hooks = get_config(path=path).jupyter_hooks
     if jupyter_hooks: _nbdev_clean(model['content'], path=path)
 
-# %% ../nbs/api/11_clean.ipynb 36
+# %% ../nbs/api/11_clean.ipynb 35
 _pre_save_hook_src = '''
 def nbdev_clean_jupyter(**kwargs):
     try: from nbdev.clean import clean_jupyter
@@ -163,7 +157,7 @@ def nbdev_clean_jupyter(**kwargs):
 c.ContentsManager.pre_save_hook = nbdev_clean_jupyter'''.strip()
 _pre_save_hook_re = re.compile(r'c\.(File)?ContentsManager\.pre_save_hook')
 
-# %% ../nbs/api/11_clean.ipynb 37
+# %% ../nbs/api/11_clean.ipynb 36
 def _add_jupyter_hooks(src, path):
     if _pre_save_hook_src in src: return
     mod = ast.parse(src)
@@ -181,12 +175,12 @@ def _add_jupyter_hooks(src, path):
     if src: src+='\n\n'
     return src+_pre_save_hook_src
 
-# %% ../nbs/api/11_clean.ipynb 41
+# %% ../nbs/api/11_clean.ipynb 40
 def _git_root(): 
     try: return Path(run('git rev-parse --show-toplevel'))
     except OSError: return None
 
-# %% ../nbs/api/11_clean.ipynb 44
+# %% ../nbs/api/11_clean.ipynb 43
 @call_parse
 def nbdev_install_hooks():
     "Install Jupyter and git hooks to automatically clean, trust, and fix merge conflicts in notebooks"

nbs/api/11_clean.ipynb

@@ -144,18 +144,6 @@
     "test_eq(_clean_cell_output_id('foo\\n<function _add2 at 0x7f8252378820>\\nbar'), 'foo\\n<function _add2>\\nbar')"
    ]
   },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "metadata": {},
-   "outputs": [],
-   "source": [
-    "#|exporti\n",
-    "def _add_trailing_n(img):\n",
-    "    if not isinstance(img,str): return [ _add_trailing_n(o) for o in img ]\n",
-    "    return img + \"\\n\" if img[-1] != \"\\n\" else img"
-   ]
-  },
   {
    "cell_type": "code",
    "execution_count": null,
@@ -172,7 +160,7 @@
     "        data.pop(\"application/vnd.google.colaboratory.intrinsic+json\", None)\n",
     "        for k in data:\n",
     "            if k.startswith('text') and clean_ids: data[k] = _clean_cell_output_id(data[k])\n",
-    "            if k.startswith('image'): data[k] = _add_trailing_n(data[k])\n",
+    "            if k.startswith('image') and \"svg\" not in k: data[k] = data[k].rstrip()\n",
     "        if 'text' in o and clean_ids: o['text'] = _clean_cell_output_id(o['text'])\n",
     "        o.get('metadata', {}).pop('tags', None)"
    ]
@@ -210,14 +198,13 @@
     "    clean_ids=True, # Remove ids from plaintext reprs?\n",
     "):\n",
     "    \"Clean `nb` from superfluous metadata\"\n",
-    "    assert isinstance(nb, AttrDict)\n",
     "    metadata_keys = {\"kernelspec\", \"jekyll\", \"jupytext\", \"doc\", \"widgets\"}\n",
     "    if allowed_metadata_keys: metadata_keys.update(allowed_metadata_keys)\n",
     "    cell_metadata_keys = {\"hide_input\"}\n",
     "    if allowed_cell_metadata_keys: cell_metadata_keys.update(allowed_cell_metadata_keys)\n",
     "    for c in nb['cells']: _clean_cell(c, clear_all, cell_metadata_keys, clean_ids)\n",
-    "    if nested_attr(nb, 'metadata.kernelspec.name'):\n",
-    "        nb['metadata']['kernelspec']['display_name'] = nb.metadata.kernelspec.name\n",
+    "    if nb.get('metadata', {}).get('kernelspec', {}).get('name', None):\n",
+    "        nb['metadata']['kernelspec']['display_name'] = nb[\"metadata\"][\"kernelspec\"][\"name\"]\n",
     "    nb['metadata'] = {k:v for k,v in nb['metadata'].items() if k in metadata_keys}"
    ]
   },
@@ -237,9 +224,9 @@
    "outputs": [],
    "source": [
     "test_nb = read_nb('../../tests/image.ipynb')\n",
-    "assert test_nb.cells[0].outputs[0].data['image/png'][-1] != \"\\n\" # Make sure it was not converted by acccident\n",
+    "assert test_nb.cells[0].outputs[0].data['image/png'][-1] == \"\\n\" # Make sure it was not converted by acccident\n",
     "clean_nb(test_nb)\n",
-    "assert test_nb.cells[0].outputs[0].data['image/png'][-1] == \"\\n\""
+    "assert test_nb.cells[0].outputs[0].data['image/png'][-1] != \"\\n\""
    ]
   },
   {
@@ -368,7 +355,7 @@
     "    if isinstance(f_in, (str,Path)): f_in = Path(f_in).open(encoding=\"utf-8\")\n",
     "    try:\n",
     "        _reconfigure(f_in, f_out)\n",
-    "        nb = dict2nb(loads(f_in.read()))\n",
+    "        nb = loads(f_in.read())\n",
     "        proc_nb(nb)\n",
     "        write_nb(nb, f_out) if not disp else sys.stdout.write(nb2str(nb))\n",
     "    except Exception as e:\n",

tests/image.ipynb

@@ -7,7 +7,7 @@
    "outputs": [
     {
      "data": {
-      "image/png": "iVBORw0KGgoAAAANSUhEUgAAAAgAAAAICAIAAABLbSncAAAAE0lEQVR4nGNkaGDACpiwCw9WCQBqCACQJ5at+QAAAABJRU5ErkJggg==",
+      "image/png": "iVBORw0KGgoAAAANSUhEUgAAAAgAAAAICAIAAABLbSncAAAAE0lEQVR4nGNkaGDACpiwCw9WCQBqCACQJ5at+QAAAABJRU5ErkJggg==\n",
       "text/plain": [
        "<PIL.Image.Image image mode=RGB size=8x8>"
       ]