Skip to content

Commit 4e60e3c

Browse files
authored
Merge pull request #686 from geigerfa/master
Fix documentation
2 parents b004dc3 + 35a2f91 commit 4e60e3c

File tree

5 files changed

+16
-17
lines changed

5 files changed

+16
-17
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,7 @@ practices because tests and documentation are first class.
3232
each push and rebuild docs on each merge.
3333
- **Git-friendly notebooks** with tools that clean unwanted metadata
3434
and render merge conflicts in a human-readable format.
35-
- … and much more! See the [Getting Started](#Getting-Started) section
36-
below for more.
35+
- … and much more!
3736

3837
## Install
3938

@@ -138,7 +137,8 @@ strive to abide by generally accepted best practices in open-source
138137
software development.
139138

140139
Make sure you have `nbdev`’s git hooks installed by running
141-
`nbdev_install_git_hooks` in the cloned repository.
140+
[nbdev_install_hooks](https://nbdev.fast.ai/clean.html#nbdev_install_hooks)
141+
in the cloned repository.
142142

143143
## Copyright
144144

nbdev/clean.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ def nbdev_install_hooks():
128128
fn.write_text("#!/bin/bash\nnbdev_trust")
129129
os.chmod(fn, os.stat(fn).st_mode | stat.S_IEXEC)
130130
#Clean notebooks on commit/diff
131-
(path/'.gitconfig').write_text("""# Generated by nbdev_install_git_hooks
131+
(path/'.gitconfig').write_text("""# Generated by nbdev_install_hooks
132132
#
133133
# If you need to disable this instrumentation do:
134134
# git config --local --unset include.path

nbs/11_clean.ipynb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
"cell_type": "markdown",
5656
"metadata": {},
5757
"source": [
58-
"To avoid pointless conflicts while working with jupyter notebooks (with different execution counts or cell metadata), it is recommended to clean the notebooks before committing anything (done automatically if you install the git hooks with `nbdev_install_git_hooks`). The following functions are used to do that."
58+
"To avoid pointless conflicts while working with jupyter notebooks (with different execution counts or cell metadata), it is recommended to clean the notebooks before committing anything (done automatically if you install the git hooks with `nbdev_install_hooks`). The following functions are used to do that."
5959
]
6060
},
6161
{
@@ -333,7 +333,7 @@
333333
" fn.write_text(\"#!/bin/bash\\nnbdev_trust\")\n",
334334
" os.chmod(fn, os.stat(fn).st_mode | stat.S_IEXEC)\n",
335335
" #Clean notebooks on commit/diff\n",
336-
" (path/'.gitconfig').write_text(\"\"\"# Generated by nbdev_install_git_hooks\n",
336+
" (path/'.gitconfig').write_text(\"\"\"# Generated by nbdev_install_hooks\n",
337337
"#\n",
338338
"# If you need to disable this instrumentation do:\n",
339339
"# git config --local --unset include.path\n",
@@ -388,7 +388,7 @@
388388
"split_at_heading": true
389389
},
390390
"kernelspec": {
391-
"display_name": "Python 3 (ipykernel)",
391+
"display_name": "Python 3.9.13 64-bit",
392392
"language": "python",
393393
"name": "python3"
394394
}

nbs/getting_started.ipynb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"- **Tests** written as ordinary notebook cells are run in parallel with a single command. You have fine-grained control over which tests are run.\n",
2929
"- **Continuous integration** out-of-the-box with [GitHub Actions](https://github.com/features/actions) that run your tests on each push and rebuild docs on each merge.\n",
3030
"- **Git-friendly notebooks** with tools that clean unwanted metadata and render merge conflicts in a human-readable format.\n",
31-
"- ... and much more! See the [Getting Started](#Getting-Started) section below for more."
31+
"- ... and much more!"
3232
]
3333
},
3434
{
@@ -183,7 +183,7 @@
183183
"source": [
184184
"If you want to contribute to `nbdev`, be sure to review the [contributions guidelines](https://github.com/fastai/nbdev/blob/master/CONTRIBUTING.md). This project adheres to fastai's [code of conduct](https://github.com/fastai/nbdev/blob/master/CODE_OF_CONDUCT.md). By participating, you are expected to uphold this code. In general, we strive to abide by generally accepted best practices in open-source software development.\n",
185185
"\n",
186-
"Make sure you have `nbdev`'s git hooks installed by running `nbdev_install_git_hooks` in the cloned repository."
186+
"Make sure you have `nbdev`'s git hooks installed by running `nbdev_install_hooks` in the cloned repository."
187187
]
188188
},
189189
{
@@ -203,7 +203,7 @@
203203
],
204204
"metadata": {
205205
"kernelspec": {
206-
"display_name": "Python 3 (ipykernel)",
206+
"display_name": "Python 3.9.13 64-bit",
207207
"language": "python",
208208
"name": "python3"
209209
}

nbs/tutorial.ipynb

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -327,9 +327,7 @@
327327
"outputs": [
328328
{
329329
"data": {
330-
"image/svg+xml": [
331-
"<svg height=\"100\"><circle cx=\"50\" cy=\"50\" r=\"40\"/></svg>"
332-
],
330+
"image/svg+xml": "<svg height=\"100\"><circle cx=\"50\" cy=\"50\" r=\"40\"/></svg>",
333331
"text/plain": [
334332
"<IPython.core.display.SVG object>"
335333
]
@@ -392,7 +390,8 @@
392390
"cell_type": "markdown",
393391
"metadata": {},
394392
"source": [
395-
"Now you can create your Python module. To do so, just run `nbdev_prepare` from the terminal at the root of your project folder. `nbdev_prepare` bundles the following commands together for you to test your code and build the library. While running `nbdev_prepare` is convenient, you have the flexibility to choose these seperate pieces.\n",
393+
"Now you can create your Python module. To do so, just run `nbdev_prepare` from the terminal at the root of your project folder. `nbdev_prepare` bundles the following commands together for you to test your code and build the library. While running `nbdev_prepare` is convenient, you have the flexibility to choose these separate pieces.\n",
394+
"\n",
396395
"- `nbdev_export`: Builds the .py modules and library from the jupyter notebook\n",
397396
"- `nbdev_test`: Tests all your notebooks\n",
398397
"- `nbdev_clean`: Cleans your notebooks to get rid of extreanous output for Github\n",
@@ -405,7 +404,7 @@
405404
"cell_type": "markdown",
406405
"metadata": {},
407406
"source": [
408-
"## Preview The docs\n",
407+
"## Preview the docs\n",
409408
"\n",
410409
"If you have not already, you should view your docs in fully rendered form to catch any mistakes. You can preview your documentation site with the command `nbdev_preview`. Note that your docs will build automatically in CI (discussed below)."
411410
]
@@ -448,7 +447,7 @@
448447
"\n",
449448
"If you have a red cross, that means something failed. Click on the cross, then click *Details*, and you'll be able to see what failed.\n",
450449
"\n",
451-
"#### Automatically Building Docs\n",
450+
"#### Automatically building Docs\n",
452451
"\n",
453452
"CI will automatically build docs and deploy them for you. You can see the code for this in `.github/workflows/deploy.yaml`, but you normally don't have to worry about this unless you need to customize something. There might be certain circumstances in which your organization has disabled GitHub pages by default. If this is the case, you can enable Github Pages by clicking on the *Settings* tab in your repo, then click *Pages* on the left side bar. Set \"Source\" to *`gh-pages` branch and the `/root` folder*. Once you've saved, if you refresh that page, Github will have a link to your new website. Copy that URL, and then go back to your main repo page, click \"edit\" next to the description and paste the URL into the \"website\" section. While you're there, go ahead and put in your project description too. \n",
454453
"\n",
@@ -1041,7 +1040,7 @@
10411040
"split_at_heading": true
10421041
},
10431042
"kernelspec": {
1044-
"display_name": "Python 3 (ipykernel)",
1043+
"display_name": "Python 3.9.13 64-bit",
10451044
"language": "python",
10461045
"name": "python3"
10471046
}

0 commit comments

Comments
 (0)