Skip to content

Commit 73929f7

Browse files
authored
Merge pull request #1071 from fastai/del-deploy
get rid of `nbdev_deploy`
2 parents c450343 + 4da1669 commit 73929f7

File tree

6 files changed

+32
-69
lines changed

6 files changed

+32
-69
lines changed

nbdev/_modidx.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,6 @@
235235
'nbdev.quarto._pre_docs': ('api/quarto.html#_pre_docs', 'nbdev/quarto.py'),
236236
'nbdev.quarto._sort': ('api/quarto.html#_sort', 'nbdev/quarto.py'),
237237
'nbdev.quarto._sprun': ('api/quarto.html#_sprun', 'nbdev/quarto.py'),
238-
'nbdev.quarto.deploy': ('api/quarto.html#deploy', 'nbdev/quarto.py'),
239238
'nbdev.quarto.fs_watchdog': ('api/quarto.html#fs_watchdog', 'nbdev/quarto.py'),
240239
'nbdev.quarto.install': ('api/quarto.html#install', 'nbdev/quarto.py'),
241240
'nbdev.quarto.install_quarto': ('api/quarto.html#install_quarto', 'nbdev/quarto.py'),

nbdev/quarto.py

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
# %% auto 0
2020
__all__ = ['BASE_QUARTO_URL', 'install_quarto', 'install', 'nbdev_sidebar', 'refresh_quarto_yml', 'nbdev_readme', 'nbdev_docs',
21-
'deploy', 'prepare', 'fs_watchdog', 'nbdev_preview']
21+
'prepare', 'fs_watchdog', 'nbdev_preview']
2222

2323
# %% ../nbs/api/quarto.ipynb 4
2424
def _sprun(cmd):
@@ -221,19 +221,6 @@ def nbdev_docs(
221221

222222
# %% ../nbs/api/quarto.ipynb 21
223223
@call_parse
224-
@delegates(nbdev_docs)
225-
def deploy(
226-
path:str=None, # Path to notebooks
227-
skip_build:bool=False, # Don't build docs first
228-
**kwargs):
229-
"Deploy docs to GitHub Pages"
230-
if not skip_build: nbdev_docs.__wrapped__(path, **kwargs)
231-
try: from ghp_import import ghp_import
232-
except: return warnings.warn('Please install ghp-import with `pip install ghp-import`')
233-
ghp_import(get_config().doc_path, push=True, stderr=True, no_history=True)
234-
235-
# %% ../nbs/api/quarto.ipynb 22
236-
@call_parse
237224
def prepare():
238225
"Export, test, and clean notebooks, and render README if needed"
239226
import nbdev.test, nbdev.clean
@@ -243,7 +230,7 @@ def prepare():
243230
refresh_quarto_yml()
244231
nbdev_readme.__wrapped__(chk_time=True)
245232

246-
# %% ../nbs/api/quarto.ipynb 24
233+
# %% ../nbs/api/quarto.ipynb 23
247234
@contextmanager
248235
def fs_watchdog(func, path, recursive:bool=True):
249236
"File system watchdog dispatching to `func`"
@@ -259,7 +246,7 @@ class _ProcessHandler(FileSystemEventHandler): dispatch=func
259246
observer.stop()
260247
observer.join()
261248

262-
# %% ../nbs/api/quarto.ipynb 25
249+
# %% ../nbs/api/quarto.ipynb 24
263250
@call_parse
264251
@delegates(_nbglob_docs)
265252
def nbdev_preview(

nbs/api/cli.ipynb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,6 @@
269269
"\u001b[1m\u001b[94mnbdev_clean\u001b[0m Clean all notebooks in `fname` to avoid merge conflicts\n",
270270
"\u001b[1m\u001b[94mnbdev_conda\u001b[0m Create a `meta.yaml` file ready to be built into a package, and optionally build and upload it\n",
271271
"\u001b[1m\u001b[94mnbdev_create_config\u001b[0m Create a config file.\n",
272-
"\u001b[1m\u001b[94mnbdev_deploy\u001b[0m Deploy docs to GitHub Pages\n",
273272
"\u001b[1m\u001b[94mnbdev_docs\u001b[0m Create Quarto docs and README.md\n",
274273
"\u001b[1m\u001b[94mnbdev_export\u001b[0m Export notebooks in `path` to Python modules\n",
275274
"\u001b[1m\u001b[94mnbdev_filter\u001b[0m A notebook filter for Quarto\n",

nbs/api/quarto.ipynb

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -399,27 +399,6 @@
399399
"# nbdev_docs.__wrapped__()"
400400
]
401401
},
402-
{
403-
"cell_type": "code",
404-
"execution_count": null,
405-
"id": "a5c29641",
406-
"metadata": {},
407-
"outputs": [],
408-
"source": [
409-
"#|export\n",
410-
"@call_parse\n",
411-
"@delegates(nbdev_docs)\n",
412-
"def deploy(\n",
413-
" path:str=None, # Path to notebooks\n",
414-
" skip_build:bool=False, # Don't build docs first\n",
415-
" **kwargs):\n",
416-
" \"Deploy docs to GitHub Pages\"\n",
417-
" if not skip_build: nbdev_docs.__wrapped__(path, **kwargs)\n",
418-
" try: from ghp_import import ghp_import\n",
419-
" except: return warnings.warn('Please install ghp-import with `pip install ghp-import`')\n",
420-
" ghp_import(get_config().doc_path, push=True, stderr=True, no_history=True)"
421-
]
422-
},
423402
{
424403
"cell_type": "code",
425404
"execution_count": null,

nbs/getting_started.ipynb

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -133,35 +133,35 @@
133133
"name": "stdout",
134134
"output_type": "stream",
135135
"text": [
136-
"\u001b[1m\u001b[94mnbdev_bump_version\u001b[0m Increment version in settings.ini by one\r\n",
137-
"\u001b[1m\u001b[94mnbdev_changelog\u001b[0m Create a CHANGELOG.md file from closed and labeled GitHub issues\r\n",
138-
"\u001b[1m\u001b[94mnbdev_clean\u001b[0m Clean all notebooks in `fname` to avoid merge conflicts\r\n",
139-
"\u001b[1m\u001b[94mnbdev_conda\u001b[0m Create a `meta.yaml` file ready to be built into a package, and optionally build and upload it\r\n",
140-
"\u001b[1m\u001b[94mnbdev_create_config\u001b[0m Create a config file.\r\n",
141-
"\u001b[1m\u001b[94mnbdev_deploy\u001b[0m Deploy docs to GitHub Pages\r\n",
142-
"\u001b[1m\u001b[94mnbdev_docs\u001b[0m Create Quarto docs and README.md\r\n",
143-
"\u001b[1m\u001b[94mnbdev_export\u001b[0m Export notebooks in `path` to Python modules\r\n",
144-
"\u001b[1m\u001b[94mnbdev_filter\u001b[0m A notebook filter for Quarto\r\n",
145-
"\u001b[1m\u001b[94mnbdev_fix\u001b[0m Create working notebook from conflicted notebook `nbname`\r\n",
146-
"\u001b[1m\u001b[94mnbdev_help\u001b[0m Show help for all console scripts\r\n",
147-
"\u001b[1m\u001b[94mnbdev_install\u001b[0m Install Quarto and the current library\r\n",
148-
"\u001b[1m\u001b[94mnbdev_install_hooks\u001b[0m Install Jupyter and git hooks to automatically clean, trust, and fix merge conflicts in notebooks\r\n",
149-
"\u001b[1m\u001b[94mnbdev_install_quarto\u001b[0m Install latest Quarto on macOS or Linux, prints instructions for Windows\r\n",
150-
"\u001b[1m\u001b[94mnbdev_merge\u001b[0m Git merge driver for notebooks\r\n",
151-
"\u001b[1m\u001b[94mnbdev_migrate\u001b[0m Convert all directives and callouts in `fname` from v1 to v2\r\n",
152-
"\u001b[1m\u001b[94mnbdev_new\u001b[0m Create an nbdev project.\r\n",
153-
"\u001b[1m\u001b[94mnbdev_prepare\u001b[0m Export, test, and clean notebooks, and render README if needed\r\n",
154-
"\u001b[1m\u001b[94mnbdev_preview\u001b[0m Preview docs locally\r\n",
155-
"\u001b[1m\u001b[94mnbdev_proc_nbs\u001b[0m Process notebooks in `path` for docs rendering\r\n",
156-
"\u001b[1m\u001b[94mnbdev_pypi\u001b[0m Create and upload Python package to PyPI\r\n",
157-
"\u001b[1m\u001b[94mnbdev_readme\u001b[0m None\r\n",
158-
"\u001b[1m\u001b[94mnbdev_release_both\u001b[0m Release both conda and PyPI packages\r\n",
159-
"\u001b[1m\u001b[94mnbdev_release_gh\u001b[0m Calls `nbdev_changelog`, lets you edit the result, then pushes to git and calls `nbdev_release_git`\r\n",
160-
"\u001b[1m\u001b[94mnbdev_release_git\u001b[0m Tag and create a release in GitHub for the current version\r\n",
161-
"\u001b[1m\u001b[94mnbdev_sidebar\u001b[0m Create sidebar.yml\r\n",
162-
"\u001b[1m\u001b[94mnbdev_test\u001b[0m Test in parallel notebooks matching `path`, passing along `flags`\r\n",
163-
"\u001b[1m\u001b[94mnbdev_trust\u001b[0m Trust notebooks matching `fname`\r\n",
164-
"\u001b[1m\u001b[94mnbdev_update\u001b[0m Propagate change in modules matching `fname` to notebooks that created them\r\n"
136+
"\u001b[1m\u001b[94mnbdev_bump_version\u001b[0m Increment version in settings.ini by one\n",
137+
"\u001b[1m\u001b[94mnbdev_changelog\u001b[0m Create a CHANGELOG.md file from closed and labeled GitHub issues\n",
138+
"\u001b[1m\u001b[94mnbdev_clean\u001b[0m Clean all notebooks in `fname` to avoid merge conflicts\n",
139+
"\u001b[1m\u001b[94mnbdev_conda\u001b[0m Create a `meta.yaml` file ready to be built into a package, and optionally build and upload it\n",
140+
"\u001b[1m\u001b[94mnbdev_create_config\u001b[0m Create a config file.\n",
141+
"\u001b[1m\u001b[94mnbdev_deploy\u001b[0m Deploy docs to GitHub Pages\n",
142+
"\u001b[1m\u001b[94mnbdev_docs\u001b[0m Create Quarto docs and README.md\n",
143+
"\u001b[1m\u001b[94mnbdev_export\u001b[0m Export notebooks in `path` to Python modules\n",
144+
"\u001b[1m\u001b[94mnbdev_filter\u001b[0m A notebook filter for Quarto\n",
145+
"\u001b[1m\u001b[94mnbdev_fix\u001b[0m Create working notebook from conflicted notebook `nbname`\n",
146+
"\u001b[1m\u001b[94mnbdev_help\u001b[0m Show help for all console scripts\n",
147+
"\u001b[1m\u001b[94mnbdev_install\u001b[0m Install Quarto and the current library\n",
148+
"\u001b[1m\u001b[94mnbdev_install_hooks\u001b[0m Install Jupyter and git hooks to automatically clean, trust, and fix merge conflicts in notebooks\n",
149+
"\u001b[1m\u001b[94mnbdev_install_quarto\u001b[0m Install latest Quarto on macOS or Linux, prints instructions for Windows\n",
150+
"\u001b[1m\u001b[94mnbdev_merge\u001b[0m Git merge driver for notebooks\n",
151+
"\u001b[1m\u001b[94mnbdev_migrate\u001b[0m Convert all directives and callouts in `fname` from v1 to v2\n",
152+
"\u001b[1m\u001b[94mnbdev_new\u001b[0m Create an nbdev project.\n",
153+
"\u001b[1m\u001b[94mnbdev_prepare\u001b[0m Export, test, and clean notebooks, and render README if needed\n",
154+
"\u001b[1m\u001b[94mnbdev_preview\u001b[0m Preview docs locally\n",
155+
"\u001b[1m\u001b[94mnbdev_proc_nbs\u001b[0m Process notebooks in `path` for docs rendering\n",
156+
"\u001b[1m\u001b[94mnbdev_pypi\u001b[0m Create and upload Python package to PyPI\n",
157+
"\u001b[1m\u001b[94mnbdev_readme\u001b[0m None\n",
158+
"\u001b[1m\u001b[94mnbdev_release_both\u001b[0m Release both conda and PyPI packages\n",
159+
"\u001b[1m\u001b[94mnbdev_release_gh\u001b[0m Calls `nbdev_changelog`, lets you edit the result, then pushes to git and calls `nbdev_release_git`\n",
160+
"\u001b[1m\u001b[94mnbdev_release_git\u001b[0m Tag and create a release in GitHub for the current version\n",
161+
"\u001b[1m\u001b[94mnbdev_sidebar\u001b[0m Create sidebar.yml\n",
162+
"\u001b[1m\u001b[94mnbdev_test\u001b[0m Test in parallel notebooks matching `path`, passing along `flags`\n",
163+
"\u001b[1m\u001b[94mnbdev_trust\u001b[0m Trust notebooks matching `fname`\n",
164+
"\u001b[1m\u001b[94mnbdev_update\u001b[0m Propagate change in modules matching `fname` to notebooks that created them\n"
165165
]
166166
}
167167
],

settings.ini

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ console_scripts = nbdev_create_config=nbdev.config:nbdev_create_config
3737
nbdev_install=nbdev.quarto:install
3838
nbdev_docs=nbdev.quarto:nbdev_docs
3939
nbdev_preview=nbdev.quarto:nbdev_preview
40-
nbdev_deploy=nbdev.quarto:deploy
4140
nbdev_prepare=nbdev.quarto:prepare
4241
nbdev_readme=nbdev.quarto:nbdev_readme
4342
nbdev_release_gh=nbdev.release:release_gh

0 commit comments

Comments
 (0)