clean_nb: Don't exect nb to be AttrDict

Author: xl0

README.md

@@ -3,12 +3,8 @@ Getting Started
 
 <!-- WARNING: THIS FILE WAS AUTOGENERATED! DO NOT EDIT! -->
 
-<div>
-
 ![CI](https://github.com/fastai/nbdev/actions/workflows/test.yaml/badge.svg)
 
-</div>
-
 *NB: This is nbdev v2, a major upgrade of nbdev. Whilst the differences
 to nbdev1 aren’t huge, it does require some changes. The old version
 docs are at [nbdev1.fast.ai](https://nbdev1.fast.ai). You can use
@@ -75,8 +71,6 @@ The best way to learn how to use nbdev is to complete either the
 [written walkthrough](https://nbdev.fast.ai/tutorials/tutorial.html) or
 video walkthrough:
 
-<div style="text-align: center">
-
 <div>
 
 <a href="http://www.youtube.com/watch?v=l7zS8Ld4_iA" target="_blank"
@@ -86,8 +80,6 @@ style="border-radius: 10px" width="560" height="315" /></a>
 
 </div>
 
-</div>
-
 Alternatively, there’s a [shortened version of the video
 walkthrough](https://youtu.be/67FdzLSt4aA) with coding sections sped up
 using the `unsilence` Python library – it’s 27 minutes faster, but a bit

nbdev/clean.py

@@ -93,14 +93,13 @@ def clean_nb(
     clean_ids=True, # Remove ids from plaintext reprs?
 ):
     "Clean `nb` from superfluous metadata"
-    assert isinstance(nb, AttrDict)
     metadata_keys = {"kernelspec", "jekyll", "jupytext", "doc", "widgets"}
     if allowed_metadata_keys: metadata_keys.update(allowed_metadata_keys)
     cell_metadata_keys = {"hide_input"}
     if allowed_cell_metadata_keys: cell_metadata_keys.update(allowed_cell_metadata_keys)
     for c in nb['cells']: _clean_cell(c, clear_all, cell_metadata_keys, clean_ids)
-    if nested_attr(nb, 'metadata.kernelspec.name'):
-        nb['metadata']['kernelspec']['display_name'] = nb.metadata.kernelspec.name
+    if nb.get('metadata', {}).get('kernelspec', {}).get('name', None):
+        nb['metadata']['kernelspec']['display_name'] = nb["metadata"]["kernelspec"]["name"]
     nb['metadata'] = {k:v for k,v in nb['metadata'].items() if k in metadata_keys}
 
 # %% ../nbs/api/11_clean.ipynb 27
@@ -114,7 +113,7 @@ def process_write(warn_msg, proc_nb, f_in, f_out=None, disp=False):
     if isinstance(f_in, (str,Path)): f_in = Path(f_in).open()
     try:
         _reconfigure(f_in, f_out)
-        nb = dict2nb(loads(f_in.read()))
+        nb = loads(f_in.read())
         proc_nb(nb)
         write_nb(nb, f_out) if not disp else sys.stdout.write(nb2str(nb))
     except Exception as e:

nbs/api/11_clean.ipynb

@@ -210,14 +210,13 @@
     "    clean_ids=True, # Remove ids from plaintext reprs?\n",
     "):\n",
     "    \"Clean `nb` from superfluous metadata\"\n",
-    "    assert isinstance(nb, AttrDict)\n",
     "    metadata_keys = {\"kernelspec\", \"jekyll\", \"jupytext\", \"doc\", \"widgets\"}\n",
     "    if allowed_metadata_keys: metadata_keys.update(allowed_metadata_keys)\n",
     "    cell_metadata_keys = {\"hide_input\"}\n",
     "    if allowed_cell_metadata_keys: cell_metadata_keys.update(allowed_cell_metadata_keys)\n",
     "    for c in nb['cells']: _clean_cell(c, clear_all, cell_metadata_keys, clean_ids)\n",
-    "    if nested_attr(nb, 'metadata.kernelspec.name'):\n",
-    "        nb['metadata']['kernelspec']['display_name'] = nb.metadata.kernelspec.name\n",
+    "    if nb.get('metadata', {}).get('kernelspec', {}).get('name', None):\n",
+    "        nb['metadata']['kernelspec']['display_name'] = nb[\"metadata\"][\"kernelspec\"][\"name\"]\n",
     "    nb['metadata'] = {k:v for k,v in nb['metadata'].items() if k in metadata_keys}"
    ]
   },
@@ -368,7 +367,7 @@
     "    if isinstance(f_in, (str,Path)): f_in = Path(f_in).open()\n",
     "    try:\n",
     "        _reconfigure(f_in, f_out)\n",
-    "        nb = dict2nb(loads(f_in.read()))\n",
+    "        nb = loads(f_in.read())\n",
     "        proc_nb(nb)\n",
     "        write_nb(nb, f_out) if not disp else sys.stdout.write(nb2str(nb))\n",
     "    except Exception as e:\n",