Add a comment about highest block number

linh2931 · linh2931 · commit c0f88375c1c5 · 2024-10-22T16:50:19.000-04:00
diff --git a/plugins/trace_api_plugin/store_provider.cpp b/plugins/trace_api_plugin/store_provider.cpp
@@ -136,7 +136,7 @@ namespace eosio::trace_api {
             } else if (std::holds_alternative<lib_entry_v0>(entry)) {
                auto lib = std::get<lib_entry_v0>(entry).lib;
                if (!trx_block_nums.empty() && lib >= *(--trx_block_nums.end())) {
-                  return *(--trx_block_nums.end());
+                  return *(--trx_block_nums.end()); // *(--trx_block_nums.end()) is the block with highest block number which is final
                }
             } else {
                FC_ASSERT( false, "unpacked data should be a block_trxs_entry or a lib_entry_v0" );;

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ namespace eosio::trace_api {`
`136`	`136`	`} else if (std::holds_alternative<lib_entry_v0>(entry)) {`
`137`	`137`	`auto lib = std::get<lib_entry_v0>(entry).lib;`
`138`	`138`	`if (!trx_block_nums.empty() && lib >= *(--trx_block_nums.end())) {`
`139`		`- return *(--trx_block_nums.end());`
	`139`	`+ return (--trx_block_nums.end()); // (--trx_block_nums.end()) is the block with highest block number which is final`
`140`	`140`	`}`
`141`	`141`	`} else {`
`142`	`142`	`FC_ASSERT( false, "unpacked data should be a block_trxs_entry or a lib_entry_v0" );;`