Merge pull request #134 from AnthonyGress/dev

use toast feedback for media request, exponential backoff for weather

Author: AnthonyGress

backend/src/routes/weather.route.ts

@@ -5,6 +5,39 @@ import StatusCodes from 'http-status-codes';
 
 export const weatherRoute = Router();
 
+// Helper function for retry logic with exponential backoff
+const retryWithBackoff = async <T>(
+    fn: () => Promise<T>,
+    maxRetries: number = 3,
+    baseDelay: number = 1000
+): Promise<T> => {
+    let lastError: Error | unknown;
+    
+    for (let attempt = 0; attempt <= maxRetries; attempt++) {
+        try {
+            return await fn();
+        } catch (error) {
+            lastError = error;
+            
+            // Don't retry on client errors (4xx) or if it's the last attempt
+            if (axios.isAxiosError(error) && error.response?.status && error.response.status < 500) {
+                throw error;
+            }
+            
+            if (attempt === maxRetries) {
+                throw error;
+            }
+            
+            // Exponential backoff: 1s, 2s, 4s
+            const delay = baseDelay * Math.pow(2, attempt);
+            console.log(`Weather API attempt ${attempt + 1} failed, retrying in ${delay}ms...`);
+            await new Promise(resolve => setTimeout(resolve, delay));
+        }
+    }
+    
+    throw lastError;
+};
+
 /**
  * GET /weather
  * Requires query parameters `latitude` and `longitude`.
@@ -22,17 +55,19 @@ weatherRoute.get('/', async (req: Request, res: Response): Promise<void> => {
         const latitude = req.query.latitude;
         const longitude = req.query.longitude;
 
-        // Fetch weather data from Open-Meteo with timeout
-        const weatherResponse = await axios.get('https://api.open-meteo.com/v1/forecast', {
-            params: {
-                latitude: latitude,
-                longitude: longitude,
-                current: 'temperature_2m,weathercode,windspeed_10m',
-                daily: 'temperature_2m_max,temperature_2m_min,weathercode,sunrise,sunset',
-                timezone: 'auto'
-            },
-            timeout: 5000 // 5 second timeout
-        });
+        // Fetch weather data from Open-Meteo with retry logic
+        const weatherResponse = await retryWithBackoff(async () => {
+            return await axios.get('https://api.open-meteo.com/v1/forecast', {
+                params: {
+                    latitude: latitude,
+                    longitude: longitude,
+                    current: 'temperature_2m,weathercode,windspeed_10m',
+                    daily: 'temperature_2m_max,temperature_2m_min,weathercode,sunrise,sunset',
+                    timezone: 'auto'
+                },
+                timeout: 5000 // 5 second timeout
+            });
+        }, 3, 1000); // 3 retries with 1 second base delay
 
         res.json(weatherResponse.data);
 
@@ -43,20 +78,20 @@ weatherRoute.get('/', async (req: Request, res: Response): Promise<void> => {
         if (axios.isAxiosError(error)) {
             if (error.code === 'ECONNABORTED') {
                 statusCode = StatusCodes.GATEWAY_TIMEOUT;
-                errorMessage = 'Weather API timeout';
+                errorMessage = 'Weather API timeout after retries';
             } else if (error.response) {
                 statusCode = error.response.status;
                 errorMessage = `Weather API error: ${error.response.statusText}`;
             }
 
-            console.error(`Weather API error: ${errorMessage}`, {
+            console.error(`Weather API error after retries: ${errorMessage}`, {
                 status: statusCode,
                 message: error.message,
                 url: error.config?.url,
                 params: error.config?.params
             });
         } else {
-            console.error('Unknown error fetching weather:', error);
+            console.error('Unknown error fetching weather after retries:', error);
         }
 
         res.status(statusCode).json({ error: errorMessage });

frontend/src/components/dashboard/base-items/widgets/MediaRequestManagerWidget.tsx

@@ -42,6 +42,7 @@ import { COLORS } from '../../../../theme/styles';
 import { theme } from '../../../../theme/theme';
 import { CenteredModal } from '../../../modals/CenteredModal';
 import { PopupManager } from '../../../modals/PopupManager';
+import { ToastManager } from '../../../toast/ToastManager';
 
 export interface MediaRequestManagerWidgetProps {
     id: string;
@@ -273,6 +274,7 @@ export const MediaRequestManagerWidget: React.FC<MediaRequestManagerWidgetProps>
         try {
             // Filter out already available seasons before sending the request
             let seasonsToRequest = seasons;
+            const title = item.title || item.name;
             if (item.mediaType === 'tv' && seasons && tvShowDetails) {
                 seasonsToRequest = seasons.filter(seasonNumber => {
                     const season = tvShowDetails.seasons?.find((s: any) => s.seasonNumber === seasonNumber);
@@ -286,17 +288,21 @@ export const MediaRequestManagerWidget: React.FC<MediaRequestManagerWidgetProps>
                 item.id.toString(),
                 seasonsToRequest
             );
+
             if (response.success) {
                 // Refresh requests after creating one
                 fetchRequests();
                 // Clear search results and query
                 setSearchResults([]);
                 setSearchQuery('');
+                ToastManager.success(`Successfully requested ${title}`);
             } else {
                 console.error('Request creation failed:', response.error);
+                ToastManager.error(`Failed to request ${title}`);
             }
         } catch (requestError) {
             console.error('Request creation error:', requestError);
+            ToastManager.error('An error occured while requesting');
         }
     };
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "lab-dash",
-  "version": "1.2.5",
+  "version": "1.2.6",
   "description": "This is an open-source user interface designed to manage your server and homelab",
   "main": "index.js",
   "scripts": {